<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:serval2412@yahoo.fr" title="Julien Nabet <serval2412@yahoo.fr>"> <span class="fn">Julien Nabet</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - FILEOPEN: Spreadsheet takes long to open"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=130795">bug 130795</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>erack@redhat.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - FILEOPEN: Spreadsheet takes long to open"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=130795#c23">Comment # 23</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - FILEOPEN: Spreadsheet takes long to open"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=130795">bug 130795</a>
from <span class="vcard"><a class="email" href="mailto:serval2412@yahoo.fr" title="Julien Nabet <serval2412@yahoo.fr>"> <span class="fn">Julien Nabet</span></a>
</span></b>
<pre>(In reply to Luboš Luňák from <a href="show_bug.cgi?id=130795#c21">comment #21</a>)
<span class="quote">> The real problem here is not that SharedStringPool would be slow, but that
> ScTable::ValidQuery()/QueryEvaluator calls it at all. If you look at how
> it's used, those strings are interned only to do a "fast" case-insensitive
> comparison _once_, but interning a string apparently takes way longer than a
> normal comparison would. The concurrent hashmap change is band-aid (at least
> in this case), the real fix should be removing the SharedStringPool usage
> from QueryEvaluator. <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Deleting 10.000 rows column in a spreadsheet: 15 sec with 4.1| 10 sec up to 300+ sec with 6.2| 130 sec with 7.3"
href="show_bug.cgi?id=144249">Bug #144249</a> has a similar problem.</span >
So we could also remove the brand new lib dependency on cuckoo (unless it could
be used for something else?)
About SharedStringPool, I took a look at git history.
git log --follow -S 'svl::SharedStringPool' sc/source/core/data/table3.cxx
commit 2f39c27be2bd66f149e0a4efdd7fa37daee43fb1
Author: Kohei Yoshida <<a href="mailto:kohei.yoshida@collabora.com">kohei.yoshida@collabora.com</a>>
Date: Wed Oct 9 10:50:23 2013 -0400
Use shared string's fast equality check for ValidQuery().
Change-Id: Ib84087a10cc10a7533e64c4e8998354b52017df7
commit a11e224e07a4fda0de64a9a0a181f6034e08d2e5
Author: Kohei Yoshida <<a href="mailto:kohei.yoshida@collabora.com">kohei.yoshida@collabora.com</a>>
Date: Tue Oct 8 21:46:56 2013 -0400
Store svl::SharedString in query entry items, and adjust all call sites.
Change-Id: Ifd3bbb84c7abbe983a017a169c7e05914ef33450
Kohei was in the trio Calc experts (Eike, Kohei, Markus), so I suppose he had
done some perf tests but perhaps with all code change after all these years,
those are no more relevant?
Eike: any thoughts here?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>