[Libreoffice-commits] .: 3 commits - binfilter/bf_svtools binfilter/bf_svx hwpfilter/source

[Caolán McNamara]

 binfilter/bf_svtools/source/svdde/svt_ddeml1.cxx |   10 ----------
 binfilter/bf_svx/source/editeng/svx_impedit3.cxx |   15 +++++++--------
 hwpfilter/source/formula.h                       |   22 ++++++++--------------
 3 files changed, 15 insertions(+), 32 deletions(-)

New commits:
commit 7ea4657df35b81a39fd9e451e94097dba6bd96d2
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Dec 9 12:45:58 2010 +0000

    cppcheck: unused variables

diff --git a/binfilter/bf_svtools/source/svdde/svt_ddeml1.cxx b/binfilter/bf_svtools/source/svdde/svt_ddeml1.cxx
index 81ee2dd..3541582 100644
--- a/binfilter/bf_svtools/source/svdde/svt_ddeml1.cxx
+++ b/binfilter/bf_svtools/source/svdde/svt_ddeml1.cxx
@@ -2382,9 +2382,6 @@ MRESULT	ImpDdeMgr::DdeUnadvise( ImpWndProcParams* pParams )
             ULONG nTransId = GetTransaction(pData, hConv, hszItem, nFormat);
             if( nTransId )
             {
-                ////WRITELOG("DdeUnadvise:Transaction found")
-                Transaction* pTrans = pTransTable;
-                pTrans += (USHORT)nTransId;
                 ImpHCONV* pConv = pConvTable;
                 pConv += (USHORT)hConv;
                 nClosedTransactions = 1;
@@ -2429,13 +2426,6 @@ BOOL ImpDdeMgr::WaitTransState( Transaction* pTrans, ULONG nTransId,
     ULONG nTimerId = WinStartTimer( hAB, 0, 0, 50 );
     QMSG aQueueMsg;
 
-//	while( WinGetMsg( hAB, &aQueueMsg, 0, 0, 0 ) 	&&
-//			WinIsWindow( hAB, pConv->hWndPartner) 	&&
-//			pTrans->nConvst != nNewState )
-//	{
-//		WinDispatchMsg( hAB, &aQueueMsg );
-//	}
-
     BOOL bContinue = TRUE;
     while( bContinue )
     {
commit b7656e0ff894f412df5d2fcf08dc34ca10ab96fb
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Dec 9 12:33:23 2010 +0000

    cppcheck: unit members

diff --git a/hwpfilter/source/formula.h b/hwpfilter/source/formula.h
index 31c82cf..ad7a9a2 100644
--- a/hwpfilter/source/formula.h
+++ b/hwpfilter/source/formula.h
@@ -46,15 +46,15 @@ using namespace ::com::sun::star::xml::sax;
 
 class Formula{
 public:
-     Formula(char *_eq, int _ishwpeq = 1) {
-          eq = _eq;
-          isHwpEQ = _ishwpeq;
-          trim();
-     }
-     virtual ~Formula(){ }
+    Formula(char *_eq, int _ishwpeq = 1)
+        : pList(NULL)
+    {
+        eq = _eq;
+        isHwpEQ = _ishwpeq;
+        trim();
+    }
+    virtual ~Formula(){ }
 
-// DVO: remove DEBUG dependency
-// #ifndef DEBUG
      void setDocumentHandler(Reference < XDocumentHandler > xHandler ){
           rDocumentHandler = xHandler;
      }
@@ -62,8 +62,6 @@ public:
           pList = p;
           rList = (XAttributeList *) pList;
      }
-// DVO: remove DEBUG dependency
-// #endif
      int parse();
 private:
      void trim();
@@ -89,13 +87,9 @@ private:
      void makeEnd(Node *res);
 
 private:
-// DVO: remove DEBUG dependency
-// #ifndef DEBUG
      Reference< XDocumentHandler >   rDocumentHandler;
      Reference< XAttributeList > rList;
      AttributeListImpl *pList;
-// DVO: remove DEBUG dependency
-// #endif
      char *eq;
      int isHwpEQ;
 };
commit 859d7aaa9ba3ba2e73b752454bb1e7304df06dcb
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Dec 9 12:06:25 2010 +0000

    cppcheck: uninit members

diff --git a/binfilter/bf_svx/source/editeng/svx_impedit3.cxx b/binfilter/bf_svx/source/editeng/svx_impedit3.cxx
index dbb13db..23227fe 100644
--- a/binfilter/bf_svx/source/editeng/svx_impedit3.cxx
+++ b/binfilter/bf_svx/source/editeng/svx_impedit3.cxx
@@ -119,16 +119,15 @@ struct TabInfo
     long		nStartPosX;
     long		nTabPos;
 
-    TabInfo() { bValid = FALSE; }
+    TabInfo()
+        : bValid(FALSE)
+        , nCharPos(0)
+        , nTabPortion(0)
+        , nStartPosX(0)
+        , nTabPos(0)
+    {}
 };
 
-
-
-
-
-
-
-
 //	----------------------------------------------------------------------
 //	class ImpEditEngine
 //	----------------------------------------------------------------------