[Libreoffice-commits] .: 2 commits - sax/test unotools/source

Caolán McNamara caolan at kemper.freedesktop.org
Wed Dec 22 07:04:02 PST 2010


 sax/test/sax/testwriter.cxx         |   12 ++++++++----
 unotools/source/config/accelcfg.cxx |    6 +++---
 2 files changed, 11 insertions(+), 7 deletions(-)

New commits:
commit 88c273d1dcaeb9619b87c300561dfd603f5a1652
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Dec 22 13:49:39 2010 +0000

    cppcheck: prefer prefix variants

diff --git a/unotools/source/config/accelcfg.cxx b/unotools/source/config/accelcfg.cxx
index 8432d94..fa8ada3 100644
--- a/unotools/source/config/accelcfg.cxx
+++ b/unotools/source/config/accelcfg.cxx
@@ -235,7 +235,7 @@ SvtAcceleratorConfiguration::~SvtAcceleratorConfiguration()
         nCode = rKeyEvent.KeyFunc;
 
     std::list< SvtAcceleratorConfigItem>::const_iterator p;
-    for ( p = pImp->aList.begin(); p != pImp->aList.end(); p++ )
+    for ( p = pImp->aList.begin(); p != pImp->aList.end(); ++p )
         if ( p->nCode == nCode && p->nModifier == nModifier )
             return p->aCommand;
 
@@ -250,7 +250,7 @@ const SvtAcceleratorItemList& SvtAcceleratorConfiguration::GetItems()
 void SvtAcceleratorConfiguration::SetCommand( const SvtAcceleratorConfigItem& rItem )
 {
     std::list< SvtAcceleratorConfigItem>::iterator p;
-    for ( p = pImp->aList.begin(); p != pImp->aList.end(); p++ )
+    for ( p = pImp->aList.begin(); p != pImp->aList.end(); ++p )
         if ( p->nCode == rItem.nCode && p->nModifier == rItem.nModifier )
         {
             p->aCommand = rItem.aCommand;
@@ -270,7 +270,7 @@ void SvtAcceleratorConfiguration::SetItems( const SvtAcceleratorItemList& rItems
     else
     {
         std::list< SvtAcceleratorConfigItem>::const_iterator p;
-        for ( p = rItems.begin(); p != rItems.end(); p++ )
+        for ( p = rItems.begin(); p != rItems.end(); ++p )
             SetCommand( *p );
     }
 }
commit 9274b1af9ad1f07aba7e51b662974fb5c07fb183
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Dec 22 13:43:24 2010 +0000

    cppcheck: prefer prefix variants

diff --git a/sax/test/sax/testwriter.cxx b/sax/test/sax/testwriter.cxx
index 1cb71ab..cc2fc5f 100644
--- a/sax/test/sax/testwriter.cxx
+++ b/sax/test/sax/testwriter.cxx
@@ -253,8 +253,10 @@ OUString AttributeListImpl::getTypeByName( const OUString& sName ) throw  (Runti
 {
     vector<struct TagAttribute>::iterator ii = m_pImpl->vecAttribute.begin();
 
-    for( ; ii != m_pImpl->vecAttribute.end() ; ii ++ ) {
-        if( (*ii).sName == sName ) {
+    for (; ii != m_pImpl->vecAttribute.end(); ++ii)
+    {
+        if( (*ii).sName == sName )
+        {
             return (*ii).sType;
         }
     }
@@ -265,8 +267,10 @@ OUString AttributeListImpl::getValueByName(const OUString& sName) throw  (Runtim
 {
     vector<struct TagAttribute>::iterator ii = m_pImpl->vecAttribute.begin();
 
-    for( ; ii != m_pImpl->vecAttribute.end() ; ii ++ ) {
-        if( (*ii).sName == sName ) {
+    for(; ii != m_pImpl->vecAttribute.end(); ++ii)
+    {
+        if( (*ii).sName == sName )
+        {
             return (*ii).sValue;
         }
     }


More information about the Libreoffice-commits mailing list