[Libreoffice-commits] .: 3 commits - sax/source toolkit/source ucbhelper/workben

[Caolán McNamara]

 sax/source/expatwrap/attrlistimpl.cxx          |   12 ++++++++----
 toolkit/source/controls/roadmapcontrol.cxx     |    4 ++--
 ucbhelper/workben/myucp/myucp_datasupplier.cxx |    2 +-
 3 files changed, 11 insertions(+), 7 deletions(-)

New commits:
commit 877cfdef6bdeef8d33bbd2e7753661245b448809
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Dec 23 12:52:51 2010 +0000

    cppcheck: prefer prefix variant

diff --git a/ucbhelper/workben/myucp/myucp_datasupplier.cxx b/ucbhelper/workben/myucp/myucp_datasupplier.cxx
index ecdf861..baefab3 100644
--- a/ucbhelper/workben/myucp/myucp_datasupplier.cxx
+++ b/ucbhelper/workben/myucp/myucp_datasupplier.cxx
@@ -110,7 +110,7 @@ DataSupplier_Impl::~DataSupplier_Impl()
     while ( it != end )
     {
         delete (*it);
-        it++;
+        ++it;
     }
 }
 
commit dc4ca8a90869e03f7abe992442c131732c0a3e66
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Dec 23 12:49:15 2010 +0000

    cppcheck: prefer prefix variant

diff --git a/sax/source/expatwrap/attrlistimpl.cxx b/sax/source/expatwrap/attrlistimpl.cxx
index 7d4cc19..b363642 100644
--- a/sax/source/expatwrap/attrlistimpl.cxx
+++ b/sax/source/expatwrap/attrlistimpl.cxx
@@ -112,8 +112,10 @@ OUString AttributeList::getTypeByName( const OUString& sName ) throw (RuntimeExc
 {
     vector<struct TagAttribute>::iterator ii = m_pImpl->vecAttribute.begin();
 
-    for( ; ii != m_pImpl->vecAttribute.end() ; ii ++ ) {
-        if( (*ii).sName == sName ) {
+    for (; ii != m_pImpl->vecAttribute.end(); ++ii )
+    {
+        if( (*ii).sName == sName )
+        {
             return (*ii).sType;
         }
     }
@@ -124,8 +126,10 @@ OUString AttributeList::getValueByName(const OUString& sName) throw (RuntimeExce
 {
     vector<struct TagAttribute>::iterator ii = m_pImpl->vecAttribute.begin();
 
-    for( ; ii != m_pImpl->vecAttribute.end() ; ii ++ ) {
-        if( (*ii).sName == sName ) {
+    for (; ii != m_pImpl->vecAttribute.end(); ++ii)
+    {
+        if( (*ii).sName == sName )
+        {
             return (*ii).sValue;
         }
     }
commit 2bae4c1e231b8b63e44574ed1c10e39efada72c8
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Dec 23 12:48:39 2010 +0000

    cppcheck: prefer prefix variant

diff --git a/toolkit/source/controls/roadmapcontrol.cxx b/toolkit/source/controls/roadmapcontrol.cxx
index 9172928..f756f53 100644
--- a/toolkit/source/controls/roadmapcontrol.cxx
+++ b/toolkit/source/controls/roadmapcontrol.cxx
@@ -233,8 +233,8 @@ static void lcl_throwIndexOutOfBoundsException( )
           Reference< XInterface > CurRoadmapItem;
           while ( bIncrement )
           {
-           bIncrement = sal_False;
-              for ( RoadmapItemHolderList::iterator i = maRoadmapItems.begin(); i < maRoadmapItems.end(); i++ )
+              bIncrement = sal_False;
+              for ( RoadmapItemHolderList::iterator i = maRoadmapItems.begin(); i < maRoadmapItems.end(); ++i )
               {
                 CurRoadmapItem = *i;
                 Reference< XPropertySet > xPropertySet( CurRoadmapItem, UNO_QUERY );