[Libreoffice-commits] .: 18 commits - binfilter/legacysmgr filter/source hwpfilter/source lotuswordpro/source oox/source unoxml/source writerfilter/source writerperfect/source

Caolán McNamara caolan at kemper.freedesktop.org
Thu Dec 23 13:12:44 PST 2010


 binfilter/legacysmgr/source/legacy/legacy_binfilters_smgr.cxx |   28 +++++-----
 filter/source/msfilter/msdffimp.cxx                           |    2 
 filter/source/xsltdialog/typedetectionimport.cxx              |    2 
 filter/source/xsltdialog/xmlfiltertabpagebasic.cxx            |    2 
 hwpfilter/source/attributes.cxx                               |    4 -
 lotuswordpro/source/filter/bencont.cxx                        |    4 -
 lotuswordpro/source/filter/lwpglobalmgr.cxx                   |    2 
 lotuswordpro/source/filter/xfilter/xfdrawpath.cxx             |    8 +-
 lotuswordpro/source/filter/xfilter/xfdrawpolyline.cxx         |    4 -
 lotuswordpro/source/filter/xfilter/xfstylemanager.cxx         |    2 
 lotuswordpro/source/filter/xfilter/xftimestyle.cxx            |    2 
 oox/source/drawingml/diagram/diagram.cxx                      |    4 -
 oox/source/ppt/pptshapecontext.cxx                            |    2 
 oox/source/ppt/presentationfragmenthandler.cxx                |    2 
 unoxml/source/events/eventdispatcher.cxx                      |   14 ++---
 writerfilter/source/dmapper/DomainMapper.cxx                  |    2 
 writerfilter/source/dmapper/NumberingManager.cxx              |    2 
 writerperfect/source/filter/TableStyle.cxx                    |    8 +-
 18 files changed, 47 insertions(+), 47 deletions(-)

New commits:
commit 4205775c79af1b50378f72ec557febd6cac2cfc4
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Dec 23 21:00:56 2010 +0000

    cppcheck: prefer prefix variant

diff --git a/lotuswordpro/source/filter/xfilter/xfstylemanager.cxx b/lotuswordpro/source/filter/xfilter/xfstylemanager.cxx
index dcdd966..7ececd9 100644
--- a/lotuswordpro/source/filter/xfilter/xfstylemanager.cxx
+++ b/lotuswordpro/source/filter/xfilter/xfstylemanager.cxx
@@ -323,7 +323,7 @@ void	XFStyleManager::ToXml(IXFStream *pStrm)
     pStrm->StartElement( A2OUSTR("office:font-decls") );
 
     //font declarations:
-    for( itDecl = s_aFontDecls.begin(); itDecl != s_aFontDecls.end(); itDecl++ )
+    for( itDecl = s_aFontDecls.begin(); itDecl != s_aFontDecls.end(); ++itDecl )
     {
         XFFontDecl &f = *itDecl;
 
commit e1524241e269630f8bcb713429c34646cb1916ed
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Dec 23 21:00:39 2010 +0000

    cppcheck: prefer prefix variant

diff --git a/binfilter/legacysmgr/source/legacy/legacy_binfilters_smgr.cxx b/binfilter/legacysmgr/source/legacy/legacy_binfilters_smgr.cxx
index ddda91e..bc525cd 100644
--- a/binfilter/legacysmgr/source/legacy/legacy_binfilters_smgr.cxx
+++ b/binfilter/legacysmgr/source/legacy/legacy_binfilters_smgr.cxx
@@ -217,7 +217,7 @@ static Sequence< OUString > retrieveAsciiValueList(
                     seq.realloc( n1Len + n2Len );
                     const OUString *pSource = seq2.getConstArray();
                     OUString *pTarget = seq.getArray();
-                    for( int i = 0 ; i < n2Len ; i ++ )
+                    for( int i = 0; i < n2Len; ++i )
                     {
                         pTarget[i+n1Len] = pSource[i];
                     }
@@ -687,7 +687,7 @@ void OServiceManager::onUnloadingNotify()
     list<IT_MM> listDeleteServiceMap;
     typedef list<IT_MM>::const_iterator CIT_DMM;
     // find occurrences in m_ServiceMap
-    for(IT_MM it_i1= m_ServiceMap.begin(); it_i1 != it_end1; it_i1++)
+    for(IT_MM it_i1= m_ServiceMap.begin(); it_i1 != it_end1; ++it_i1)
     {
         if( m_SetLoadedFactories.find( it_i1->second) != it_SetEnd)
         {
@@ -703,7 +703,7 @@ void OServiceManager::onUnloadingNotify()
     }
     // delete elements from m_ServiceMap
     CIT_DMM it_end2= listDeleteServiceMap.end();
-    for( CIT_DMM it_i2= listDeleteServiceMap.begin(); it_i2 != it_end2; it_i2++)
+    for( CIT_DMM it_i2= listDeleteServiceMap.begin(); it_i2 != it_end2; ++it_i2)
         m_ServiceMap.erase( *it_i2);
 
     // find elements in m_ImplementationNameMap
@@ -711,7 +711,7 @@ void OServiceManager::onUnloadingNotify()
     IT_M it_end3= m_ImplementationNameMap.end();
     list<IT_M> listDeleteImplementationNameMap;
     typedef list<IT_M>::const_iterator CIT_DM;
-    for( IT_M it_i3= m_ImplementationNameMap.begin();  it_i3 != it_end3; it_i3++)
+    for( IT_M it_i3= m_ImplementationNameMap.begin();  it_i3 != it_end3; ++it_i3)
     {
         if( m_SetLoadedFactories.find( it_i3->second) != it_SetEnd)
         {
@@ -727,7 +727,7 @@ void OServiceManager::onUnloadingNotify()
     }
     // delete elements from m_ImplementationNameMap
     CIT_DM it_end4= listDeleteImplementationNameMap.end();
-    for( CIT_DM it_i4= listDeleteImplementationNameMap.begin(); it_i4 != it_end4; it_i4++)
+    for( CIT_DM it_i4= listDeleteImplementationNameMap.begin(); it_i4 != it_end4; ++it_i4)
         m_ImplementationNameMap.erase( *it_i4);
 
     // find elements in m_ImplementationMap
@@ -735,7 +735,7 @@ void OServiceManager::onUnloadingNotify()
     IT_S it_end5= m_ImplementationMap.end();
     list<IT_S> listDeleteImplementationMap;
     typedef list<IT_S>::const_iterator CIT_DS;
-    for( IT_S it_i5= m_ImplementationMap.begin(); it_i5 != it_end5; it_i5++)
+    for( IT_S it_i5= m_ImplementationMap.begin(); it_i5 != it_end5; ++it_i5)
     {
         if( m_SetLoadedFactories.find( *it_i5) != it_SetEnd)
         {
@@ -751,14 +751,14 @@ void OServiceManager::onUnloadingNotify()
     }
     // delete elements from m_ImplementationMap
     CIT_DS it_end6= listDeleteImplementationMap.end();
-    for( CIT_DS it_i6= listDeleteImplementationMap.begin(); it_i6 != it_end6; it_i6++)
+    for( CIT_DS it_i6= listDeleteImplementationMap.begin(); it_i6 != it_end6; ++it_i6)
         m_ImplementationMap.erase( *it_i6);
 
     // remove Event listener before the factories are released.
     IT_S it_end7= m_SetLoadedFactories.end();
 
     Reference<XEventListener> xlistener= getFactoryListener();
-    for( IT_S it_i7= m_SetLoadedFactories.begin(); it_i7 != it_end7; it_i7++)
+    for( IT_S it_i7= m_SetLoadedFactories.begin(); it_i7 != it_end7; ++it_i7)
     {
         Reference<XComponent> xcomp( *it_i7, UNO_QUERY);
         if( xcomp.is())
@@ -1117,7 +1117,7 @@ sal_Bool OServiceManager::supportsService(const OUString& ServiceName)
     check_undisposed();
     Sequence< OUString > aSNL = getSupportedServiceNames();
     const OUString * pArray = aSNL.getConstArray();
-    for( sal_Int32 i = 0; i < aSNL.getLength(); i++ )
+    for( sal_Int32 i = 0; i < aSNL.getLength(); ++i )
         if( pArray[i] == ServiceName )
             return sal_True;
     return sal_False;
@@ -1270,7 +1270,7 @@ void OServiceManager::insert( const Any & Element )
     {
         Sequence< OUString > aServiceNames = xSF->getSupportedServiceNames();
         const OUString * pArray = aServiceNames.getConstArray();
-        for( sal_Int32 i = 0; i < aServiceNames.getLength(); i++ )
+        for( sal_Int32 i = 0; i < aServiceNames.getLength(); ++i )
         {
             m_ServiceMap.insert( HashMultimap_OWString_Interface::value_type(
                 pArray[i], *(Reference<XInterface > *)Element.getValue() ) );
@@ -1337,7 +1337,7 @@ void OServiceManager::remove( const Any & Element )
     {
         Sequence< OUString > aServiceNames = xSF->getSupportedServiceNames();
         const OUString * pArray = aServiceNames.getConstArray();
-        for( sal_Int32 i = 0; i < aServiceNames.getLength(); i++ )
+        for( sal_Int32 i = 0; i < aServiceNames.getLength(); ++i )
         {
             pair<HashMultimap_OWString_Interface::iterator, HashMultimap_OWString_Interface::iterator> p =
                 m_ServiceMap.equal_range( pArray[i] );
@@ -1536,7 +1536,7 @@ Reference<XInterface > ORegistryServiceManager::loadWithServiceName(
     const OUString& serviceName, Reference< XComponentContext > const & xContext )
 {
     Sequence<OUString> implEntries = getFromServiceName( serviceName );
-    for (sal_Int32 i = 0; i < implEntries.getLength(); i++)
+    for (sal_Int32 i = 0; i < implEntries.getLength(); ++i)
     {
         Reference< XInterface > x(
             loadWithImplementationName( implEntries.getConstArray()[i], xContext ) );
@@ -1565,7 +1565,7 @@ void ORegistryServiceManager::fillAllNamesFromRegistry( HashSet_OWString & rSet
         {
             sal_Int32 nPrefix = xServicesKey->getKeyName().getLength() +1;
             Sequence<Reference<XRegistryKey > > aKeys = xServicesKey->openKeys();
-            for( sal_Int32 i = 0; i < aKeys.getLength(); i++ )
+            for( sal_Int32 i = 0; i < aKeys.getLength(); ++i )
                 rSet.insert( aKeys.getConstArray()[i]->getKeyName().copy( nPrefix ) );
         }
     }
@@ -1648,7 +1648,7 @@ Reference<XEnumeration > ORegistryServiceManager::createContentEnumeration(
     // load and insert all factories specified by the registry
     sal_Int32 i;
     OUString aImplName;
-    for( i = 0; i < aImpls.getLength(); i++ )
+    for( i = 0; i < aImpls.getLength(); ++i )
     {
         aImplName = aImpls.getConstArray()[i];
         if ( !haveFactoryWithThisImplementation(aImplName) )
commit c25417f8ce9629b71e63bfc314d6c62c66f13b7e
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Dec 23 20:56:35 2010 +0000

    cppcheck: prefer prefix variant

diff --git a/filter/source/msfilter/msdffimp.cxx b/filter/source/msfilter/msdffimp.cxx
index 71f9772..386bbfa 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -1687,7 +1687,7 @@ void ApplyRectangularGradientAsBitmap( const SvxMSDffManager& rManager, SvStream
                                 aColorB = aIter->aColor;
                             }
                         }
-                        aIter++;
+                        ++aIter;
                     }			
                     double fRed = aColorA.GetRed(), fGreen = aColorA.GetGreen(), fBlue = aColorA.GetBlue();
                     double fD1 = fB - fA;
commit 7349b3697b5dfd7bb2a64d6a846aff24a7786657
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Dec 23 16:35:32 2010 +0000

    cppcheck: prefer prefix variant

diff --git a/lotuswordpro/source/filter/xfilter/xftimestyle.cxx b/lotuswordpro/source/filter/xfilter/xftimestyle.cxx
index fbc7323..ed21437 100644
--- a/lotuswordpro/source/filter/xfilter/xftimestyle.cxx
+++ b/lotuswordpro/source/filter/xfilter/xftimestyle.cxx
@@ -141,7 +141,7 @@ void	XFTimeStyle::ToXml(IXFStream *pStrm)
     pStrm->StartElement( A2OUSTR("number:time-style") );
 
     std::vector<XFTimePart>::iterator it;
-    for( it = m_aParts.begin(); it != m_aParts.end(); it++ )
+    for( it = m_aParts.begin(); it != m_aParts.end(); ++it )
     {
         (*it).ToXml(pStrm);
     }
commit 79debda5b411cabea780d143d14dedd9a6fee345
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Dec 23 16:35:13 2010 +0000

    cppcheck: prefer prefix variant

diff --git a/lotuswordpro/source/filter/xfilter/xfdrawpath.cxx b/lotuswordpro/source/filter/xfilter/xfdrawpath.cxx
index e793c76..cb93494 100644
--- a/lotuswordpro/source/filter/xfilter/xfdrawpath.cxx
+++ b/lotuswordpro/source/filter/xfilter/xfdrawpath.cxx
@@ -78,7 +78,7 @@ rtl::OUString XFSvgPathEntry::ToString()
     rtl::OUString str = m_strCommand;
     std::vector<XFPoint>::iterator it;
 
-    for( it = m_aPoints.begin(); it != m_aPoints.end(); it++ )
+    for( it = m_aPoints.begin(); it != m_aPoints.end(); ++it )
     {
         XFPoint aPt= *it;
         str += DoubleToOUString(aPt.GetX()*1000) + A2OUSTR(" ") + DoubleToOUString(aPt.GetY()*1000) + A2OUSTR(" ");
@@ -171,7 +171,7 @@ void	XFDrawPath::ToXml(IXFStream *pStrm)
     //points
     rtl::OUString	strPath;
     std::vector<XFSvgPathEntry>::iterator it;
-    for( it = m_aPaths.begin(); it != m_aPaths.end(); it++ )
+    for( it = m_aPaths.begin(); it != m_aPaths.end(); ++it )
     {
         XFSvgPathEntry	aSvg = *it;
         strPath += aSvg.ToString();
@@ -203,7 +203,7 @@ XFRect	XFDrawPath::CalcViewBox()
         aPath = *itPath;
         points = aPath.m_aPoints;
 
-        for( itPoint = points.begin(); itPoint != points.end(); itPoint++ )
+        for( itPoint = points.begin(); itPoint != points.end(); ++itPoint )
         {
             aPoint = *itPoint;
             if( x1>aPoint.GetX() )
@@ -216,7 +216,7 @@ XFRect	XFDrawPath::CalcViewBox()
             if( y2<aPoint.GetY() )
                 y2 = aPoint.GetY();
         }
-        itPath++;
+        ++itPath;
     }while(itPath!=m_aPaths.end());
 
     return XFRect(x1,y1,x2-x1,y2-y1);
commit 6207d3f056a7ed7129b5f8fd0e1d0cc0893e44db
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Dec 23 16:34:20 2010 +0000

    cppcheck: prefer prefix variant

diff --git a/lotuswordpro/source/filter/bencont.cxx b/lotuswordpro/source/filter/bencont.cxx
index 58a789c..9f2d6a9 100644
--- a/lotuswordpro/source/filter/bencont.cxx
+++ b/lotuswordpro/source/filter/bencont.cxx
@@ -416,7 +416,7 @@ BenError LtcBenContainer::CreateGraphicStreams(std::vector<SvStream *> * pStream
 
     /* traverse the found properties and construct the stream vectors */
     std::vector<std::string>::iterator itor;
-    for (itor = aGrPropertyVector.begin(); itor != aGrPropertyVector.end(); itor ++)
+    for (itor = aGrPropertyVector.begin(); itor != aGrPropertyVector.end(); ++itor)
     {
         // get property names with suffix of S&D
         char sSName[32], sDName[32];
@@ -427,7 +427,7 @@ BenError LtcBenContainer::CreateGraphicStreams(std::vector<SvStream *> * pStream
 
         // erase strings in vector
         std::vector<std::string>::iterator itorSearch;
-        for (itorSearch = aGrPropertyVector.begin(); itorSearch != aGrPropertyVector.end(); itorSearch ++)
+        for (itorSearch = aGrPropertyVector.begin(); itorSearch != aGrPropertyVector.end(); ++itorSearch)
         {
             if( (*itorSearch == sSName) || (*itorSearch == sDName) )
             {
commit 21b9f0f096b32f3423c451a1976bab830348a54b
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Dec 23 16:33:44 2010 +0000

    cppcheck: prefer prefix variant

diff --git a/oox/source/ppt/pptshapecontext.cxx b/oox/source/ppt/pptshapecontext.cxx
index 06fbcba..d8fc780 100644
--- a/oox/source/ppt/pptshapecontext.cxx
+++ b/oox/source/ppt/pptshapecontext.cxx
@@ -83,7 +83,7 @@ oox::drawingml::ShapePtr findPlaceholder( const sal_Int32 nMasterPlaceholder, sa
         aShapePtr = findPlaceholder( nMasterPlaceholder, nSubTypeIndex, rChildren );
         if ( aShapePtr.get() )
             break;
-        aRevIter++;
+        ++aRevIter;
     }
     return aShapePtr;
 }
commit 92a75aba0ce3406313a37e2746c6643b8e84ba77
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Dec 23 16:33:19 2010 +0000

    cppcheck: prefer prefix variant

diff --git a/oox/source/drawingml/diagram/diagram.cxx b/oox/source/drawingml/diagram/diagram.cxx
index baa0250..0ce0148 100644
--- a/oox/source/drawingml/diagram/diagram.cxx
+++ b/oox/source/drawingml/diagram/diagram.cxx
@@ -132,7 +132,7 @@ void DiagramLayout::layout( const dgm::PointsTreePtr & pTree, const awt::Point &
     awt::Point nextPt = pt;
     nextPt.Y += 50;
     dgm::PointsTree::Childrens::const_iterator iter;
-    for( iter = pTree->beginChild(); iter != pTree->endChild(); iter++ )
+    for( iter = pTree->beginChild(); iter != pTree->endChild(); ++iter )
     {
         layout( *iter, nextPt );
         nextPt.X += 50;
@@ -244,7 +244,7 @@ void Diagram::build(  )
         mpRoot = aRoots.begin()->second;
         OSL_TRACE( "root is %s", OUSTRING_TO_CSTR( mpRoot->getPoint()->getModelId() ) );
         for( PointsTreeMap::iterator iter = aTreeMap.begin();
-             iter != aTreeMap.end(); iter++ )
+             iter != aTreeMap.end(); ++iter )
         {
             if(! iter->second->getParent() )
             {
commit 1a19aefda18c1b0193652d7c6f5e13a0b8eff72f
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Dec 23 16:32:39 2010 +0000

    cppcheck: prefer prefix variant

diff --git a/lotuswordpro/source/filter/lwpglobalmgr.cxx b/lotuswordpro/source/filter/lwpglobalmgr.cxx
index 82b2196..ce3167e 100644
--- a/lotuswordpro/source/filter/lwpglobalmgr.cxx
+++ b/lotuswordpro/source/filter/lwpglobalmgr.cxx
@@ -98,7 +98,7 @@ LwpGlobalMgr::~LwpGlobalMgr()
         m_pXFStyleManager = NULL;
     }
     std::map<sal_uInt16,LwpEditorAttr*>::iterator iter;
-    for (iter =m_EditorAttrMap.begin();iter != m_EditorAttrMap.end(); iter++)
+    for (iter =m_EditorAttrMap.begin();iter != m_EditorAttrMap.end(); ++iter)
     {
         delete iter->second;
         iter->second = NULL;
commit 6d4de3f5a8fc3725d50b4f89b3ec9096215379a4
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Dec 23 16:32:18 2010 +0000

    cppcheck: prefer prefix variant

diff --git a/filter/source/xsltdialog/xmlfiltertabpagebasic.cxx b/filter/source/xsltdialog/xmlfiltertabpagebasic.cxx
index b4d336d..f5557c5 100644
--- a/filter/source/xsltdialog/xmlfiltertabpagebasic.cxx
+++ b/filter/source/xsltdialog/xmlfiltertabpagebasic.cxx
@@ -126,7 +126,7 @@ bool XMLFilterTabPageBasic::FillInfo( filter_info_impl* pInfo )
                     pInfo->maImportService = (*aIter)->maXMLImporter;
                     break;
                 }
-                aIter++;
+                ++aIter;
             }
         }
     }
commit 824d4ac1e008372d950fb7cfaecea0114eb6c8fc
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Dec 23 16:32:09 2010 +0000

    cppcheck: prefer prefix variant

diff --git a/unoxml/source/events/eventdispatcher.cxx b/unoxml/source/events/eventdispatcher.cxx
index cb291cb..69a4d53 100644
--- a/unoxml/source/events/eventdispatcher.cxx
+++ b/unoxml/source/events/eventdispatcher.cxx
@@ -47,11 +47,11 @@ namespace DOM { namespace events {
                 if ((iter->second).is() && iter->second == aListener)
                 {
                     ListenerMap::iterator tmp_iter = iter;
-                    iter++;
+                    ++iter;
                     pMap->erase(tmp_iter);
                 }
                 else
-                    iter++;
+                    ++iter;
             }
         }
     }
@@ -67,7 +67,7 @@ namespace DOM { namespace events {
             ListenerMap *pMap = tIter->second;
             ListenerMap::const_iterator iter = pMap->lower_bound(pNode);
             ListenerMap::const_iterator ibound = pMap->upper_bound(pNode);
-            for( ; iter != ibound; iter++ )
+            for( ; iter != ibound; ++iter )
             {
                 if((iter->second).is())
                     (iter->second)->handleEvent(xEvent);
@@ -163,7 +163,7 @@ namespace DOM { namespace events {
         
         // start at the root
         inode = captureVector.end();
-        inode--;
+        --inode;
         if (inode != captureVector.end())
         {
             // capturing phase:
@@ -174,7 +174,7 @@ namespace DOM { namespace events {
                 pEvent->m_currentTarget = Reference< XEventTarget >(DOM::CNode::get(*inode));
                 callListeners(*inode, aType, xEvent, sal_True);
                 if  (pEvent->m_canceled) return sal_True;
-                inode--;
+                --inode;
             }
 
             // target phase
@@ -182,7 +182,7 @@ namespace DOM { namespace events {
             callListeners(*inode, aType, xEvent, sal_False);
             if  (pEvent->m_canceled) return sal_True;
             // bubbeling phase
-            inode++;
+            ++inode;
             if (aEvent->getBubbles()) {
                 pEvent->m_phase = PhaseType_BUBBLING_PHASE;
                 while (inode != captureVector.end())
@@ -190,7 +190,7 @@ namespace DOM { namespace events {
                     pEvent->m_currentTarget = Reference< XEventTarget >(DOM::CNode::get(*inode));
                     callListeners(*inode, aType, xEvent, sal_False);
                     if  (pEvent->m_canceled) return sal_True;
-                    inode++;
+                    ++inode;
                 }
             }
         }                
commit 47ce42de67571b97c61f0706c5eaccf64714aae9
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Dec 23 15:11:05 2010 +0000

    cppcheck: prefer prefix variant

diff --git a/writerfilter/source/dmapper/DomainMapper.cxx b/writerfilter/source/dmapper/DomainMapper.cxx
index e2748ab..e5a7559 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -3138,7 +3138,7 @@ void DomainMapper::sprm( Sprm& rSprm, PropertyMapPtr rContext, SprmType eSprmTyp
                     pSectionContext->SetColumnDistance( pSectHdl->GetSpace() );
                     pSectionContext->SetColumnCount( (sal_Int16)(pSectHdl->GetColumns().size() -1));
                     std::vector<_Column>::const_iterator tmpIter = pSectHdl->GetColumns().begin();
-                    for (; tmpIter != pSectHdl->GetColumns().end(); tmpIter++)
+                    for (; tmpIter != pSectHdl->GetColumns().end(); ++tmpIter)
                     {
                         pSectionContext->AppendColumnWidth( tmpIter->nWidth );
                         if ((tmpIter != pSectHdl->GetColumns().end() - 1) || (tmpIter->nSpace > 0))
commit cb71eb2c2ec7157780efeef15f321ace8889ee4c
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Dec 23 15:10:15 2010 +0000

    cppcheck: prefer prefix variant

diff --git a/filter/source/xsltdialog/typedetectionimport.cxx b/filter/source/xsltdialog/typedetectionimport.cxx
index 787b95d..6f5a753 100644
--- a/filter/source/xsltdialog/typedetectionimport.cxx
+++ b/filter/source/xsltdialog/typedetectionimport.cxx
@@ -153,7 +153,7 @@ Node* TypeDetectionImporter::findTypeNode( const OUString& rType )
         if( (*aIter)->maName == rType )
             return (*aIter);
 
-        aIter++;
+        ++aIter;
     }
     
     return NULL;
commit 74706fba18f4b35987cf8c94d8490a4d883b563e
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Dec 23 15:10:00 2010 +0000

    cppcheck: prefer prefix variant

diff --git a/writerfilter/source/dmapper/NumberingManager.cxx b/writerfilter/source/dmapper/NumberingManager.cxx
index 86cee87..15a3cc2 100644
--- a/writerfilter/source/dmapper/NumberingManager.cxx
+++ b/writerfilter/source/dmapper/NumberingManager.cxx
@@ -976,7 +976,7 @@ void ListsManager::CreateNumberingRules( )
 {
     // Loop over the definitions
     std::vector< ListDef::Pointer >::iterator listIt = m_aLists.begin( );
-    for ( ; listIt != m_aLists.end( ); listIt++ )
+    for ( ; listIt != m_aLists.end( ); ++listIt )
     {
         (*listIt)->CreateNumberingRules( m_rDMapper, m_xFactory );
     }
commit 0ee73851085238090907618d0aeff8c4811ee171
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Dec 23 15:05:30 2010 +0000

    cppcheck: prefer prefix variant

diff --git a/hwpfilter/source/attributes.cxx b/hwpfilter/source/attributes.cxx
index df96501..e7c9345 100644
--- a/hwpfilter/source/attributes.cxx
+++ b/hwpfilter/source/attributes.cxx
@@ -112,7 +112,7 @@ OUString AttributeListImpl::getTypeByName( const OUString& sName ) throw (Runtim
 {
     std::vector<struct TagAttribute>::iterator ii = m_pImpl->vecAttribute.begin();
 
-    for( ; ii != m_pImpl->vecAttribute.end() ; ii ++ )
+    for (; ii != m_pImpl->vecAttribute.end(); ++ii)
     {
         if( (*ii).sName == sName )
         {
@@ -127,7 +127,7 @@ OUString AttributeListImpl::getValueByName(const OUString& sName) throw (Runtime
 {
     std::vector<struct TagAttribute>::iterator ii = m_pImpl->vecAttribute.begin();
 
-    for( ; ii != m_pImpl->vecAttribute.end() ; ii ++ )
+    for (; ii != m_pImpl->vecAttribute.end(); ++ii)
     {
         if( (*ii).sName == sName )
         {
commit 389ae057209732954b2e83956ac1e76f8cfb8934
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Dec 23 15:03:59 2010 +0000

    cppcheck: prefer prefix variant

diff --git a/lotuswordpro/source/filter/xfilter/xfdrawpolyline.cxx b/lotuswordpro/source/filter/xfilter/xfdrawpolyline.cxx
index 8ec330c..ef427cb 100644
--- a/lotuswordpro/source/filter/xfilter/xfdrawpolyline.cxx
+++ b/lotuswordpro/source/filter/xfilter/xfdrawpolyline.cxx
@@ -82,7 +82,7 @@ void XFDrawPolyline::ToXml(IXFStream *pStrm)
 
     //points
     rtl::OUString	strPoints;
-    for( it = m_aPoints.begin(); it != m_aPoints.end(); it++ )
+    for( it = m_aPoints.begin(); it != m_aPoints.end(); ++it )
     {
         XFPoint pt = *it;
         double	x = (pt.GetX()-rect.GetX())*1000;
@@ -117,7 +117,7 @@ XFRect	XFDrawPolyline::CalcViewBox()
     x2 = aPoint.GetX();
     y1 = aPoint.GetY();
     y2 = aPoint.GetY();
-    for( ; it != m_aPoints.end(); it++ )
+    for( ; it != m_aPoints.end(); ++it )
     {
         aPoint = *it;
         if( x1>aPoint.GetX() )
commit 7571ffdda2dc16771fc025433214fe2b1bc2f5e6
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Dec 23 15:02:45 2010 +0000

    cppcheck: prefer prefix variant

diff --git a/writerperfect/source/filter/TableStyle.cxx b/writerperfect/source/filter/TableStyle.cxx
index 4157a42..1fdc1b0 100644
--- a/writerperfect/source/filter/TableStyle.cxx
+++ b/writerperfect/source/filter/TableStyle.cxx
@@ -104,9 +104,9 @@ TableStyle::~TableStyle()
 {
     typedef std::vector<TableCellStyle *>::iterator TCSVIter;
     typedef std::vector<TableRowStyle *>::iterator TRSVIter;
-    for (TCSVIter iterTableCellStyles = mTableCellStyles.begin() ; iterTableCellStyles != mTableCellStyles.end(); iterTableCellStyles++)
+    for (TCSVIter iterTableCellStyles = mTableCellStyles.begin() ; iterTableCellStyles != mTableCellStyles.end(); ++iterTableCellStyles)
         delete(*iterTableCellStyles);
-    for (TRSVIter iterTableRowStyles = mTableRowStyles.begin() ; iterTableRowStyles != mTableRowStyles.end(); iterTableRowStyles++)
+    for (TRSVIter iterTableRowStyles = mTableRowStyles.begin() ; iterTableRowStyles != mTableRowStyles.end(); ++iterTableRowStyles)
         delete(*iterTableRowStyles);
 }
 
@@ -156,11 +156,11 @@ void TableStyle::write(DocumentHandlerInterface *pHandler) const
     }
 
     typedef std::vector<TableRowStyle *>::const_iterator TRSVIter;
-    for (TRSVIter iterTableRow = mTableRowStyles.begin() ; iterTableRow != mTableRowStyles.end(); iterTableRow++)
+    for (TRSVIter iterTableRow = mTableRowStyles.begin() ; iterTableRow != mTableRowStyles.end(); ++iterTableRow)
         (*iterTableRow)->write(pHandler);
 
     typedef std::vector<TableCellStyle *>::const_iterator TCSVIter;
-    for (TCSVIter iterTableCell = mTableCellStyles.begin() ; iterTableCell != mTableCellStyles.end(); iterTableCell++)
+    for (TCSVIter iterTableCell = mTableCellStyles.begin() ; iterTableCell != mTableCellStyles.end(); ++iterTableCell)
         (*iterTableCell)->write(pHandler);
 }
 
commit 6c42b9e0ddc658f653385fd299ee38c7b2385fd0
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Dec 23 14:59:21 2010 +0000

    cppcheck: prefer prefix variant

diff --git a/oox/source/ppt/presentationfragmenthandler.cxx b/oox/source/ppt/presentationfragmenthandler.cxx
index 302e811..4034af8 100644
--- a/oox/source/ppt/presentationfragmenthandler.cxx
+++ b/oox/source/ppt/presentationfragmenthandler.cxx
@@ -201,7 +201,7 @@ void PresentationFragmentHandler::endDocument() throw (SAXException, RuntimeExce
                                 pMasterPersistPtr = *aIter;
                                 break;
                             }
-                            aIter++;
+                            ++aIter;
                         }
                         if ( aIter == rMasterPages.end() )
                         {   // masterpersist not found, we have to load it


More information about the Libreoffice-commits mailing list