[Libreoffice-commits] .: Branch 'feature/layout' - README.layout vcl/source

[Ricardo Cruz]

 README.layout                |    9 +++++++++
 vcl/source/layout/layout.cxx |    2 +-
 2 files changed, 10 insertions(+), 1 deletion(-)

New commits:
commit ddfabd438dfebf05675aef91cbafa1906b75ff4a
Author: Ricardo Cruz <rpmcruz at alunos.dcc.fc.up.pt>
Date:   Mon Dec 27 00:13:31 2010 +0000

    A couple more points for TODO.

diff --git a/README.layout b/README.layout
index ea2515d..a7792da 100644
--- a/README.layout
+++ b/README.layout
@@ -51,6 +51,15 @@ trivial nevertheless.
 
 * Integration code should return a ButtonOrder with the
   appropriate spec (see buttonbox.hxx)
+* Children of Notebook are not re-using TabControl background:
+  apparently because we initially set their Window parent as
+  being LDialog or some other dummy parent.
+* Window::Invalidate() is being called twice and is drawing
+  the widget twice: internally when the resize is changed,
+  and another time when we change the size.
+  We may also want to make it call QueueResize() when the
+  all thing needs to be redrawn...
+
 * Widgets thickness: at the present, the border around
   the widget's label is always (2*12, 2*6) -- see ctrl.cxx
   We could use gtk style properties like xthickness and
diff --git a/vcl/source/layout/layout.cxx b/vcl/source/layout/layout.cxx
index ef0f0ec..68704b1 100644
--- a/vcl/source/layout/layout.cxx
+++ b/vcl/source/layout/layout.cxx
@@ -203,7 +203,7 @@ void Widget::SetParentWindow (Window *parent_window)
     if (m_window)
         m_window->SetParent (parent_window);
     else {
-        // is lonely layout: propagate new parent to children of Window type
+        // is pure Layout impl: propagate new parent to children of Window type
         std::list <Widget> children = m_layout->GetChildren();
         for (std::list <Widget>::iterator it = children.begin();
              it != children.end(); it++)