[Libreoffice-commits] .: 2 commits - starmath/source starmath/visual-editor-todo

[Jonas Finnemann Jensen]

 starmath/source/view.cxx    |    5 ++++-
 starmath/visual-editor-todo |    2 ++
 2 files changed, 6 insertions(+), 1 deletion(-)

New commits:
commit 619872ac447854c359f9231d50c4bbd7d88809d1
Author: Jonas Finnemann Jensen <jopsen at gmail.com>
Date:   Tue Nov 2 20:13:22 2010 +0100

    Fixed crash when choosing starmath from start screen

diff --git a/starmath/source/view.cxx b/starmath/source/view.cxx
index 120e3b5..7874d06 100644
--- a/starmath/source/view.cxx
+++ b/starmath/source/view.cxx
@@ -207,7 +207,10 @@ void SmGraphicWindow::MouseButtonDown(const MouseEvent& rMEvt)
 
 bool SmGraphicWindow::IsInlineEditEnabled() const
 {
-    return pViewShell->GetEditWindow()->IsInlineEditEnabled();
+    //Avoid crash on startup (happens when starmath is selected from splash screen)
+    if(pViewShell->GetEditWindow())
+        return pViewShell->GetEditWindow()->IsInlineEditEnabled();
+    return false;
 }
 
 void SmGraphicWindow::GetFocus()
commit 884cf1f01a37c4f0a97215a653f1d51eb64991ad
Author: Jonas Finnemann Jensen <jopsen at gmail.com>
Date:   Sun Oct 31 18:12:54 2010 +0100

    Added a few details to the todo

diff --git a/starmath/visual-editor-todo b/starmath/visual-editor-todo
index 027140f..e2555ab 100644
--- a/starmath/visual-editor-todo
+++ b/starmath/visual-editor-todo
@@ -17,6 +17,7 @@ Easy
 3. Code style (missing spaces, linebreaks and a few renames)
 4. More documentation
 5. Replace j_assert with DBG_ASSERT (don't do this yet).
+6. Remove the CreateTextFromNode methods and replace calls to it with NodeToTextVisitor
 
 Medium
 ------
@@ -42,3 +43,4 @@ Complex and non-essential
 4. Consider allowing users to enter commands in visual editor, by prefixing the command...
 5. Optimize things, for instance SmCursor::AnnotateSelection() is called way too many places...
 6. Improve handling of MoveUp and MoveDown in SmCursor::Move, SmCaretPos2LineVisitor might need improvement.
+7. Synchronized command text caret and visual editor caret.