[Libreoffice-commits] .: sfx2/source

Lionel Elie Mamane lmamane at kemper.freedesktop.org
Wed Aug 17 10:46:41 PDT 2011


 sfx2/source/appl/appbaslib.cxx |   15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)

New commits:
commit 7f3a944146879d2f0e6ee3f69cf721eb14f18689
Author: Lionel Elie Mamane <lionel at mamane.lu>
Date:   Wed Aug 17 19:43:25 2011 +0200

    Do not silently ignore exceptions when saving Libraries
    
    It may lead to data loss

diff --git a/sfx2/source/appl/appbaslib.cxx b/sfx2/source/appl/appbaslib.cxx
index eb2c43a..7e72889 100644
--- a/sfx2/source/appl/appbaslib.cxx
+++ b/sfx2/source/appl/appbaslib.cxx
@@ -125,17 +125,10 @@ void SfxBasicManagerHolder::storeLibrariesToStorage( const Reference< XStorage >
 {
     OSL_PRECOND( isValid(), "SfxBasicManagerHolder::storeLibrariesToStorage: not initialized!" );
 
-    try
-    {
-        if ( mxBasicContainer.is() )
-            mxBasicContainer->storeLibrariesToStorage( _rxStorage );
-        if ( mxDialogContainer.is() )
-            mxDialogContainer->storeLibrariesToStorage( _rxStorage );
-    }
-    catch( const Exception& )
-    {
-        DBG_UNHANDLED_EXCEPTION();
-    }
+    if ( mxBasicContainer.is() )
+        mxBasicContainer->storeLibrariesToStorage( _rxStorage );
+    if ( mxDialogContainer.is() )
+        mxDialogContainer->storeLibrariesToStorage( _rxStorage );
 }
 
 Reference< XLibraryContainer > SfxBasicManagerHolder::getLibraryContainer( ContainerType _eType )


More information about the Libreoffice-commits mailing list