[Libreoffice-commits] .: sc/source

Kohei Yoshida kohei at kemper.freedesktop.org
Mon Dec 12 11:20:49 PST 2011


 sc/source/core/data/table3.cxx |    6 ++++++
 1 file changed, 6 insertions(+)

New commits:
commit 99977d7864f632a6fd74d3e0490f545905ac4b96
Author: Kohei Yoshida <kohei.yoshida at suse.com>
Date:   Mon Dec 12 14:18:59 2011 -0500

    fdo#35539: Don't evaluate error cells as values during filtering.
    
    E.g., if filtering for cells < 5, we should skip error cells.  Previously,
    error cells are unintentionally treated as having a numeric value of 0.

diff --git a/sc/source/core/data/table3.cxx b/sc/source/core/data/table3.cxx
index ffd5d6f..b0d261f 100644
--- a/sc/source/core/data/table3.cxx
+++ b/sc/source/core/data/table3.cxx
@@ -1157,7 +1157,13 @@ public:
             return false;
 
         if (pCell)
+        {
+            if (pCell->GetErrorCode())
+                // Error values are compared as string.
+                return false;
+
             return pCell->HasValueData();
+        }
 
         return mrTab.HasValueData(nCol, nRow);
     }


More information about the Libreoffice-commits mailing list