[Libreoffice-commits] .: sw/source

Cédric Bosdonnat cbosdo at kemper.freedesktop.org
Thu Jan 6 00:29:29 PST 2011


 sw/source/core/crsr/callnk.cxx |    8 --------
 1 file changed, 8 deletions(-)

New commits:
commit 46cfbf716597038cb24747745ddeed03fc67673b
Author: Octavio Alvarez <alvarezp at alvarezp.ods.org>
Date:   Mon Jan 3 07:23:09 2011 -0800

    SwCallLink: Removed unnecesarry Invalidate() call.
    
    In commit 47472e8 the author intended to fix some repainting
    issues with nested tables. This made the cursor flicker and
    disappear everytime it moved inside the table.
    
    The problem was tracked down to an Invalidate() call inside
    SwCallLink::~SwCallLink(). The lines are removed. Neither of
    both problems reproduce on tests so far.
    
    See discussion "Annoying cursor behavior on sw tables"
    http://www.mail-archive.com/libreoffice@lists.freedesktop.org/msg04197.html

diff --git a/sw/source/core/crsr/callnk.cxx b/sw/source/core/crsr/callnk.cxx
index 4dd5930..64363ef 100644
--- a/sw/source/core/crsr/callnk.cxx
+++ b/sw/source/core/crsr/callnk.cxx
@@ -102,7 +102,6 @@ SwCallLink::~SwCallLink()
     if( !pCNd )
         return;
 
-    bool bUpdatedTable = false;
     SwFrm *myFrm=pCNd->GetFrm();
     if (myFrm!=NULL)
     {
@@ -114,8 +113,6 @@ SwCallLink::~SwCallLink()
             const SwTableLine* pLine = pRow->GetTabLine( );
             SwFmtFrmSize pSize = pLine->GetFrmFmt( )->GetFrmSize( );
             pRow->Modify( NULL, &pSize );
-
-            bUpdatedTable = true;
         }
     }
 
@@ -138,15 +135,10 @@ SwCallLink::~SwCallLink()
                 const SwTableLine* pLine = pRow->GetTabLine( );
                 SwFmtFrmSize pSize = pLine->GetFrmFmt( )->GetFrmSize( );
                 pRow->Modify( NULL, &pSize );
-
-                bUpdatedTable = true;
             }
         }
     }
 
-    if ( bUpdatedTable )
-        rShell.GetWin( )->Invalidate( 0 );
-
     xub_StrLen nCmp, nAktCntnt = pCurCrsr->GetPoint()->nContent.GetIndex();
     USHORT nNdWhich = pCNd->GetNodeType();
     ULONG nAktNode = pCurCrsr->GetPoint()->nNode.GetIndex();


More information about the Libreoffice-commits mailing list