[Libreoffice-commits] .: dbaccess/source reportdesign/source
Caolán McNamara
caolan at kemper.freedesktop.org
Fri Jan 7 03:08:07 PST 2011
dbaccess/source/core/api/CRowSetColumn.cxx | 1 -
dbaccess/source/core/api/CRowSetDataColumn.cxx | 1 -
dbaccess/source/core/api/OptimisticSet.cxx | 3 +--
dbaccess/source/core/api/definitioncolumn.cxx | 1 -
dbaccess/source/core/dataaccess/ModelImpl.hxx | 2 +-
dbaccess/source/ui/app/subcomponentmanager.cxx | 2 +-
dbaccess/source/ui/browser/brwctrlr.cxx | 7 -------
dbaccess/source/ui/control/tabletree.cxx | 4 +---
dbaccess/source/ui/misc/RowSetDrop.cxx | 5 +++--
reportdesign/source/filter/xml/xmlComponent.hxx | 2 +-
reportdesign/source/filter/xml/xmlFixedContent.cxx | 2 +-
reportdesign/source/filter/xml/xmlFunction.hxx | 2 +-
reportdesign/source/filter/xml/xmlGroup.hxx | 2 +-
13 files changed, 11 insertions(+), 23 deletions(-)
New commits:
commit 47e68d01327a85c0fa58f02958a2076770ac647b
Author: Guillaume Poussel <gpoussel at gmail.com>
Date: Thu Jan 6 20:29:25 2011 +0100
cppcheck cleanliness
diff --git a/dbaccess/source/core/api/CRowSetColumn.cxx b/dbaccess/source/core/api/CRowSetColumn.cxx
index 41a5cd8..bbda9df 100644
--- a/dbaccess/source/core/api/CRowSetColumn.cxx
+++ b/dbaccess/source/core/api/CRowSetColumn.cxx
@@ -57,7 +57,6 @@ ORowSetColumn::ORowSetColumn( const Reference < XResultSetMetaData >& _xMetaData
{
const sal_Int32 nDerivedProperties = 21;
Sequence< Property> aDerivedProperties( nDerivedProperties );
- Property* pDesc = aDerivedProperties.getArray();
sal_Int32 nPos = 0;
DECL_PROP1( CATALOGNAME, ::rtl::OUString, READONLY );
diff --git a/dbaccess/source/core/api/CRowSetDataColumn.cxx b/dbaccess/source/core/api/CRowSetDataColumn.cxx
index 8d7c872..6942dd9 100644
--- a/dbaccess/source/core/api/CRowSetDataColumn.cxx
+++ b/dbaccess/source/core/api/CRowSetDataColumn.cxx
@@ -79,7 +79,6 @@ ORowSetDataColumn::~ORowSetDataColumn()
{
const sal_Int32 nDerivedProperties = 21;
Sequence< Property> aDerivedProperties( nDerivedProperties );
- Property* pDesc = aDerivedProperties.getArray();
sal_Int32 nPos = 0;
DECL_PROP1( CATALOGNAME, ::rtl::OUString, READONLY );
diff --git a/dbaccess/source/core/api/OptimisticSet.cxx b/dbaccess/source/core/api/OptimisticSet.cxx
index 7e604f4..be2a0dd 100644
--- a/dbaccess/source/core/api/OptimisticSet.cxx
+++ b/dbaccess/source/core/api/OptimisticSet.cxx
@@ -1,3 +1,4 @@
+
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*************************************************************************
*
@@ -256,10 +257,8 @@ void SAL_CALL OptimisticSet::updateRow(const ORowSetRow& _rInsertRow ,const ORow
sSql.append(s_sSET);
sSql.append(aSqlIter->second);
::rtl::OUStringBuffer& rCondition = aKeyConditions[aSqlIter->first];
- bool bAddWhere = true;
if ( rCondition.getLength() )
{
- bAddWhere = false;
sSql.appendAscii(" WHERE ");
sSql.append( rCondition );
}
diff --git a/dbaccess/source/core/api/definitioncolumn.cxx b/dbaccess/source/core/api/definitioncolumn.cxx
index c38443c..044039a 100644
--- a/dbaccess/source/core/api/definitioncolumn.cxx
+++ b/dbaccess/source/core/api/definitioncolumn.cxx
@@ -471,7 +471,6 @@ Sequence< ::rtl::OUString > OTableColumnDescriptorWrapper::getSupportedServiceNa
const sal_Int32 nPropertyCount( nHaveAlways + nHaveOptionally );
Sequence< Property > aTableDescProperties( nPropertyCount );
- Property* pDesc = aTableDescProperties.getArray();
sal_Int32 nPos = 0;
DECL_PROP0_BOOL( ISAUTOINCREMENT );
diff --git a/dbaccess/source/core/dataaccess/ModelImpl.hxx b/dbaccess/source/core/dataaccess/ModelImpl.hxx
index fe4cf4f..78247ea 100644
--- a/dbaccess/source/core/dataaccess/ModelImpl.hxx
+++ b/dbaccess/source/core/dataaccess/ModelImpl.hxx
@@ -564,7 +564,7 @@ public:
{
return getMutex();
}
- inline ::rtl::Reference< ODatabaseModelImpl > getImpl( GuardAccess )
+ inline ::rtl::Reference< ODatabaseModelImpl > getImpl( GuardAccess ) const
{
return m_pImpl;
}
diff --git a/dbaccess/source/ui/app/subcomponentmanager.cxx b/dbaccess/source/ui/app/subcomponentmanager.cxx
index 7193d70..695d642 100644
--- a/dbaccess/source/ui/app/subcomponentmanager.cxx
+++ b/dbaccess/source/ui/app/subcomponentmanager.cxx
@@ -180,7 +180,7 @@ namespace dbaui
//..............................................................................................................
struct SelectSubComponent : public ::std::unary_function< SubComponentDescriptor, Reference< XComponent > >
{
- Reference< XComponent > operator()( const SubComponentDescriptor _desc ) const
+ Reference< XComponent > operator()( const SubComponentDescriptor _desc & ) const
{
if ( _desc.xModel.is() )
return _desc.xModel.get();
diff --git a/dbaccess/source/ui/browser/brwctrlr.cxx b/dbaccess/source/ui/browser/brwctrlr.cxx
index e952cba..1be4f4d 100644
--- a/dbaccess/source/ui/browser/brwctrlr.cxx
+++ b/dbaccess/source/ui/browser/brwctrlr.cxx
@@ -1442,13 +1442,6 @@ sal_Bool SbaXDataBrowserController::approveParameter(const ::com::sun::star::for
Reference< ::com::sun::star::container::XIndexAccess > xParameters = aEvent.Parameters;
SolarMutexGuard aSolarGuard;
- // this may be executed in a non-main thread and we want to use vcl ...
- Window* pParent = Application::GetDefDialogParent();
- // don't use the content as parent if it isn't visible
- // (and don't use NULL as parent : this may be displayed in the beamer and really shouldn't be task-local)
- // 69297 - FS - 25.10.99
- if (getBrowserView() && getBrowserView()->IsVisible())
- pParent = getBrowserView();
// default handling: instantiate an interaction handler and let it handle the parameter request
try
diff --git a/dbaccess/source/ui/control/tabletree.cxx b/dbaccess/source/ui/control/tabletree.cxx
index 6021411..cd0a0b6 100644
--- a/dbaccess/source/ui/control/tabletree.cxx
+++ b/dbaccess/source/ui/control/tabletree.cxx
@@ -282,8 +282,6 @@ void OTableTreeListBox::UpdateTableList( const Reference< XConnection >& _rxConn
try
{
- // the root entry saying "all objects"
- SvLBoxEntry* pAllObjects = NULL;
if (haveVirtualRoot())
{
String sRootEntryText;
@@ -298,7 +296,7 @@ void OTableTreeListBox::UpdateTableList( const Reference< XConnection >& _rxConn
sRootEntryText = String(ModuleRes(STR_ALL_VIEWS));
else
sRootEntryText = String(ModuleRes(STR_ALL_TABLES_AND_VIEWS));
- pAllObjects = InsertEntry( sRootEntryText, NULL, FALSE, LIST_APPEND, reinterpret_cast< void* >( DatabaseObjectContainer::TABLES ) );
+ InsertEntry( sRootEntryText, NULL, FALSE, LIST_APPEND, reinterpret_cast< void* >( DatabaseObjectContainer::TABLES ) );
}
if ( _rTables.empty() )
diff --git a/dbaccess/source/ui/misc/RowSetDrop.cxx b/dbaccess/source/ui/misc/RowSetDrop.cxx
index 787aa5f..f1d7288 100644
--- a/dbaccess/source/ui/misc/RowSetDrop.cxx
+++ b/dbaccess/source/ui/misc/RowSetDrop.cxx
@@ -1,3 +1,4 @@
+
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*************************************************************************
*
@@ -119,8 +120,6 @@ BOOL ORowSetImportExport::Read()
if(::std::find_if(m_aColumnMapping.begin(),m_aColumnMapping.end(),
::std::bind2nd(::std::greater<sal_Int32>(),0)) == m_aColumnMapping.end())
return FALSE;
- sal_Int32 nCurrentRow = 0;
- sal_Int32 nRowFilterIndex = 0;
sal_Bool bContinue = sal_True;
if(m_aSelection.getLength())
{
@@ -138,6 +137,8 @@ BOOL ORowSetImportExport::Read()
{
Reference<XPropertySet> xProp(m_xResultSet,UNO_QUERY);
sal_Int32 nRowCount = 0;
+ sal_Int32 nCurrentRow = 0;
+ sal_Int32 nRowFilterIndex = 0;
if ( xProp.is() && xProp->getPropertySetInfo()->hasPropertyByName(PROPERTY_ISROWCOUNTFINAL) )
{
sal_Bool bFinal = sal_False;
diff --git a/reportdesign/source/filter/xml/xmlComponent.hxx b/reportdesign/source/filter/xml/xmlComponent.hxx
index 217de36..0dd9d58 100644
--- a/reportdesign/source/filter/xml/xmlComponent.hxx
+++ b/reportdesign/source/filter/xml/xmlComponent.hxx
@@ -43,7 +43,7 @@ namespace rptxml
::rtl::OUString m_sTextStyleName;
OXMLComponent(const OXMLComponent&);
- void operator =(const OXMLComponent&);
+ OXMLComponent operator =(const OXMLComponent&);
public:
OXMLComponent( ORptFilter& rImport
diff --git a/reportdesign/source/filter/xml/xmlFixedContent.cxx b/reportdesign/source/filter/xml/xmlFixedContent.cxx
index 284a678..e4b22fd 100644
--- a/reportdesign/source/filter/xml/xmlFixedContent.cxx
+++ b/reportdesign/source/filter/xml/xmlFixedContent.cxx
@@ -52,7 +52,7 @@ class OXMLCharContent : public XMLCharContext
{
OXMLFixedContent* m_pFixedContent;
OXMLCharContent(const OXMLCharContent&);
- void operator =(const OXMLCharContent&);
+ OXMLCharContent operator =(const OXMLCharContent&);
public:
OXMLCharContent(
SvXMLImport& rImport,
diff --git a/reportdesign/source/filter/xml/xmlFunction.hxx b/reportdesign/source/filter/xml/xmlFunction.hxx
index 9e81d07..a3e9c6e 100644
--- a/reportdesign/source/filter/xml/xmlFunction.hxx
+++ b/reportdesign/source/filter/xml/xmlFunction.hxx
@@ -47,7 +47,7 @@ namespace rptxml
ORptFilter& GetOwnImport();
OXMLFunction(const OXMLFunction&);
- void operator =(const OXMLFunction&);
+ OXMLFunction operator =(const OXMLFunction&);
public:
OXMLFunction( ORptFilter& rImport
diff --git a/reportdesign/source/filter/xml/xmlGroup.hxx b/reportdesign/source/filter/xml/xmlGroup.hxx
index 5aa34fe..d7719f5 100644
--- a/reportdesign/source/filter/xml/xmlGroup.hxx
+++ b/reportdesign/source/filter/xml/xmlGroup.hxx
@@ -44,7 +44,7 @@ namespace rptxml
ORptFilter& GetOwnImport();
OXMLGroup(const OXMLGroup&);
- void operator =(const OXMLGroup&);
+ OXMLGroup operator =(const OXMLGroup&);
public:
OXMLGroup( ORptFilter& rImport
More information about the Libreoffice-commits
mailing list