[Libreoffice-commits] .: binfilter/bf_svtools
Joseph Powers
jpowers at kemper.freedesktop.org
Mon Jan 10 20:25:11 PST 2011
binfilter/bf_svtools/source/config/svt_menuoptions.cxx | 19 +----------------
1 file changed, 2 insertions(+), 17 deletions(-)
New commits:
commit 33e4df498de9931127eda7e252d383f605af4f85
Author: Joseph Powers <jpowers27 at cox.net>
Date: Mon Jan 10 20:25:05 2011 -0800
remove DECLARE_LIST( LinkList, Link * )
The list was read-only (no insert). I don't see why I should keep an empty
list around and try to process it's non-existant entries.
diff --git a/binfilter/bf_svtools/source/config/svt_menuoptions.cxx b/binfilter/bf_svtools/source/config/svt_menuoptions.cxx
index 126a672..b9447fa 100644
--- a/binfilter/bf_svtools/source/config/svt_menuoptions.cxx
+++ b/binfilter/bf_svtools/source/config/svt_menuoptions.cxx
@@ -2,7 +2,7 @@
/*************************************************************************
*
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
- *
+ *
* Copyright 2000, 2010 Oracle and/or its affiliates.
*
* OpenOffice.org - a multi-platform office productivity suite
@@ -81,8 +81,6 @@ namespace binfilter
#define PROPERTYCOUNT 3
-DECLARE_LIST( LinkList, Link * )
-
//_________________________________________________________________________________________________________________
// private declarations!
//_________________________________________________________________________________________________________________
@@ -94,7 +92,6 @@ class SvtMenuOptions_Impl : public ConfigItem
//-------------------------------------------------------------------------------------------------------------
private:
- LinkList aList;
sal_Bool m_bDontHideDisabledEntries ; /// cache "DontHideDisabledEntries" of Menu section
sal_Bool m_bFollowMouse ; /// cache "FollowMouse" of Menu section
sal_Bool m_bMenuIcons ; /// cache "MenuIcons" of Menu section
@@ -177,8 +174,6 @@ class SvtMenuOptions_Impl : public ConfigItem
{
m_bDontHideDisabledEntries = bState;
SetModified();
- for ( USHORT n=0; n<aList.Count(); n++ )
- aList.GetObject(n)->Call( this );
Commit();
}
@@ -186,8 +181,6 @@ class SvtMenuOptions_Impl : public ConfigItem
{
m_bFollowMouse = bState;
SetModified();
- for ( USHORT n=0; n<aList.Count(); n++ )
- aList.GetObject(n)->Call( this );
Commit();
}
@@ -195,8 +188,6 @@ class SvtMenuOptions_Impl : public ConfigItem
{
m_bMenuIcons = bState;
SetModified();
- for ( USHORT n=0; n<aList.Count(); n++ )
- aList.GetObject(n)->Call( this );
Commit();
}
@@ -289,9 +280,6 @@ SvtMenuOptions_Impl::~SvtMenuOptions_Impl()
{
Commit();
}
-
- for ( USHORT n=0; n<aList.Count(); )
- delete aList.Remove(n);
}
//*****************************************************************************************************************
@@ -328,9 +316,6 @@ void SvtMenuOptions_Impl::Notify( const Sequence< OUString >& seqPropertyNames )
else DBG_ASSERT( sal_False, "SvtMenuOptions_Impl::Notify()\nUnkown property detected ... I can't handle these!\n" );
#endif
}
-
- for ( USHORT n=0; n<aList.Count(); n++ )
- aList.GetObject(n)->Call( this );
}
//*****************************************************************************************************************
@@ -405,7 +390,7 @@ SvtMenuOptions::SvtMenuOptions()
{
RTL_LOGFILE_CONTEXT(aLog, "svtools ( ??? ) ::SvtMenuOptions_Impl::ctor()");
m_pDataContainer = new SvtMenuOptions_Impl();
-
+
ItemHolder1::holdConfigItem(E_MENUOPTIONS);
}
}
More information about the Libreoffice-commits
mailing list