[Libreoffice-commits] .: solenv/gbuild

David Tardon dtardon at kemper.freedesktop.org
Mon Jul 25 23:28:35 PDT 2011


 solenv/gbuild/LinkTarget.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9c13b745a1afaada0165d8cfa1079826a14a5470
Author: David Tardon <dtardon at redhat.com>
Date:   Tue Jul 26 08:19:57 2011 +0200

    must call eval there
    
    foreach concatenates the partial results by space, which creates lines like
    
    target : LIBS += lib1 target : LIBS += lib2 ...
    
    Obviously, evaluation of that is different from
    
    target : LIBS += lib1
    target : LIBS += lib2
    ...
    
    So we really must evaluate every partial result.

diff --git a/solenv/gbuild/LinkTarget.mk b/solenv/gbuild/LinkTarget.mk
index 4413f09..d249db7 100644
--- a/solenv/gbuild/LinkTarget.mk
+++ b/solenv/gbuild/LinkTarget.mk
@@ -889,7 +889,7 @@ endef
 
 # $(call gb_LinkTarget_use_externals,library,externals)
 gb_LinkTarget_use_externals = \
- $(foreach external,$(2),$(call gb_LinkTarget_use_external,$(1),$(external)))
+ $(foreach external,$(2),$(eval $(call gb_LinkTarget_use_external,$(1),$(external))))
 
 
 # vim: set noet sw=4:


More information about the Libreoffice-commits mailing list