[Libreoffice-commits] .: Branch 'libreoffice-3-4' - sd/source

Cédric Bosdonnat cbosdo at kemper.freedesktop.org
Wed Jun 1 00:33:50 PDT 2011


 sd/source/filter/eppt/pptx-epptbase.cxx |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 347a80976ef3f0f41077be80a8f8c42af968be7a
Author: Tor Lillqvist <tlillqvist at novell.com>
Date:   Fri May 20 12:49:55 2011 +0300

    Typo
    
    Signed-off-by: Cédric Bosdonnat <cedric.bosdonnat.ooo at free.fr>

diff --git a/sd/source/filter/eppt/pptx-epptbase.cxx b/sd/source/filter/eppt/pptx-epptbase.cxx
index 864f4ca..e4f0c5f 100644
--- a/sd/source/filter/eppt/pptx-epptbase.cxx
+++ b/sd/source/filter/eppt/pptx-epptbase.cxx
@@ -165,7 +165,11 @@ PPTWriterBase::PPTWriterBase( const Reference< XModel > & rXModel,
 
 PPTWriterBase::~PPTWriterBase()
 {
-    if ( mbStatusIndicator && mXStatusIndicator.is() ))
+    // Possibly unnecessary sanity check for mXStatusIndicator.is().
+    // In 3.3 we had a bug report of a crash where it was null,
+    // https://bugzilla.novell.com/show_bug.cgi?id=694119 (non-public,
+    // bug report, sorry).
+    if ( mbStatusIndicator && mXStatusIndicator.is() )
         mXStatusIndicator->end();
 }
 


More information about the Libreoffice-commits mailing list