[Libreoffice-commits] .: sc/source

Katarina Machalkova bubli at kemper.freedesktop.org
Thu Jun 30 05:51:18 PDT 2011


 sc/source/core/data/dpobject.cxx |    3 ---
 1 file changed, 3 deletions(-)

New commits:
commit ce3d64a6f43f943cd368d743b056fd897716f80c
Author: Katarina Machalkova <kmachalkova at suse.cz>
Date:   Mon Jun 27 13:35:01 2011 +0200

    fdo#38457: Always set column offset to 0
    
    Setting it to anything else moves field indexes off-by-N and causes crash
    in some cases (the original code has been unused since 2004 at least)

diff --git a/sc/source/core/data/dpobject.cxx b/sc/source/core/data/dpobject.cxx
index b3feea8..ec8644f 100644
--- a/sc/source/core/data/dpobject.cxx
+++ b/sc/source/core/data/dpobject.cxx
@@ -1876,9 +1876,6 @@ bool ScDPObject::FillOldParam(ScPivotParam& rParam) const
     // ppLabelArr / nLabels is not changed
 
     SCCOL nSrcColOffset = 0;
-    if (IsSheetData())
-        // source data column offset is only for internal sheet source.
-        nSrcColOffset = pSheetDesc->GetSourceRange().aStart.Col();
 
     bool bAddData = ( lcl_GetDataGetOrientation( xSource ) == sheet::DataPilotFieldOrientation_HIDDEN );
     lcl_FillOldFields(


More information about the Libreoffice-commits mailing list