[Libreoffice-commits] .: comphelper/source svtools/inc svtools/source toolkit/source vcl/source
Lubos Lunak
llunak at kemper.freedesktop.org
Fri Mar 4 11:00:57 PST 2011
comphelper/source/property/propagg.cxx | 1 -
comphelper/source/property/propertycontainerhelper.cxx | 3 +--
svtools/inc/svtools/brwbox.hxx | 1 -
svtools/inc/svtools/editbrowsebox.hxx | 1 -
svtools/source/brwbox/editbrowsebox.cxx | 2 --
svtools/source/contnr/fileview.cxx | 3 +--
svtools/source/contnr/svimpbox.cxx | 1 -
svtools/source/control/fmtfield.cxx | 1 -
svtools/source/control/inettbc.cxx | 2 +-
svtools/source/misc/transfer.cxx | 2 +-
svtools/source/productregistration/productregistration.cxx | 1 -
svtools/source/uno/unoiface.cxx | 2 +-
toolkit/source/awt/vclxwindow.cxx | 1 -
toolkit/source/awt/vclxwindows.cxx | 8 --------
toolkit/source/controls/dialogcontrol.cxx | 4 ----
toolkit/source/controls/unocontrol.cxx | 8 +++-----
toolkit/source/controls/unocontrolmodel.cxx | 5 ++---
toolkit/source/controls/unocontrols.cxx | 2 +-
vcl/source/window/taskpanelist.cxx | 2 --
vcl/source/window/window.cxx | 2 --
20 files changed, 11 insertions(+), 41 deletions(-)
New commits:
commit d8c8b4fb19475e022e50339776440832a7c4148e
Author: Guillaume Poussel <gpoussel at gmail.com>
Date: Fri Mar 4 00:11:02 2011 +0100
Remove bogus and useless comments.
Signed-off-by: LuboÅ¡ LuÅák <l.lunak at suse.cz>
diff --git a/comphelper/source/property/propagg.cxx b/comphelper/source/property/propagg.cxx
index 496dce0..1b9e4d7 100644
--- a/comphelper/source/property/propagg.cxx
+++ b/comphelper/source/property/propagg.cxx
@@ -747,7 +747,6 @@ void SAL_CALL OPropertySetAggregationHelper::setPropertyValues(
throw WrappedTargetException( ::rtl::OUString(), static_cast< XMultiPropertySet* >( this ), makeAny( UnknownPropertyException( ) ) );
// due to a flaw in the API design, this method is not allowed to throw an UnknownPropertyException
// so we wrap it into a WrappedTargetException
- // #107545# - 2002-02-20 - fs at openoffice.org
if ( OPropertyArrayAggregationHelper::AGGREGATE_PROPERTY == ePropOrg )
++nAggCount;
diff --git a/comphelper/source/property/propertycontainerhelper.cxx b/comphelper/source/property/propertycontainerhelper.cxx
index 7c3ac62..0b03765 100644
--- a/comphelper/source/property/propertycontainerhelper.cxx
+++ b/comphelper/source/property/propertycontainerhelper.cxx
@@ -275,8 +275,7 @@ sal_Bool OPropertyContainerHelper::convertFastPropertyValue(
Any aNewRequestedValue( _rValue );
// normalization
- // (#102329# - 2002-08-14 - fs at openoffice.org)
- // (#i29490# - 2004-06-16 - fs at openoffice.org)
+ // #i29490#
if ( !aNewRequestedValue.getValueType().equals( aPos->aProperty.Type ) )
{ // the actually given value is not of the same type as the one required
Any aProperlyTyped( NULL, aPos->aProperty.Type.getTypeLibType() );
diff --git a/svtools/inc/svtools/brwbox.hxx b/svtools/inc/svtools/brwbox.hxx
index 2c806f3..08a46fb 100644
--- a/svtools/inc/svtools/brwbox.hxx
+++ b/svtools/inc/svtools/brwbox.hxx
@@ -228,7 +228,6 @@ public:
// whole class, which is planned for a long time :)
//
// sorry for the ranting. could not resist
-// 98483 - 11.04.2002 - fs at openoffice.org
class SVT_DLLPUBLIC BrowseBox
:public Control
diff --git a/svtools/inc/svtools/editbrowsebox.hxx b/svtools/inc/svtools/editbrowsebox.hxx
index c4c004e..8a54220 100644
--- a/svtools/inc/svtools/editbrowsebox.hxx
+++ b/svtools/inc/svtools/editbrowsebox.hxx
@@ -114,7 +114,6 @@ namespace svt
// commit any current changes. Especially, do any reformatting you need (from input formatting
// to output formatting) here
- // 95826 - 2002-10-14 - fs at openoffice.org
virtual void CommitModifications();
// suspending the controller is not culmulative!
diff --git a/svtools/source/brwbox/editbrowsebox.cxx b/svtools/source/brwbox/editbrowsebox.cxx
index 75b00f5..d6d3419 100644
--- a/svtools/source/brwbox/editbrowsebox.cxx
+++ b/svtools/source/brwbox/editbrowsebox.cxx
@@ -501,7 +501,6 @@ namespace svt
// we are about to leave the current cell. If there is a "this cell has been modified" notification
// pending (asynchronously), this may be deadly -> do it synchronously
- // 95826 - 2002-10-14 - fs at openoffice.org
if ( nCellModifiedEvent )
{
Application::RemoveUserEvent( nCellModifiedEvent );
@@ -512,7 +511,6 @@ namespace svt
if (0 == rEvt.GetColumnId())
{ // it was the handle column. save the current cell content if necessary
// (clicking on the handle column results in selecting the current row)
- // 23.01.2001 - 82797 - FS
if (IsEditing() && aController->IsModified())
SaveModified();
}
diff --git a/svtools/source/contnr/fileview.cxx b/svtools/source/contnr/fileview.cxx
index ae65e96..3a9efa5 100644
--- a/svtools/source/contnr/fileview.cxx
+++ b/svtools/source/contnr/fileview.cxx
@@ -1142,7 +1142,6 @@ BOOL ViewTabListBox_Impl::DoubleClickHdl()
// - which is not what in the case of content replace
// (I really doubt that this behaviour of the SvImpLBox does make any sense at all, but
// who knows ...)
- // 07.12.2001 - 95727 - fs at openoffice.org
}
::rtl::OUString ViewTabListBox_Impl::GetAccessibleObjectDescription( ::svt::AccessibleBrowseBoxObjType _eType, sal_Int32 _nPos ) const
@@ -2455,7 +2454,7 @@ void SvtFileView_Impl::Resort_Impl( sal_Int16 nColumn, sal_Bool bAscending )
{
pEntry = mpView->GetEntry( nPos );
- ++mnSuspendSelectCallback; // #i15668# - 2004-04-25 - fs at openoffice.org
+ ++mnSuspendSelectCallback; // #i15668#
mpView->SetCurEntry( pEntry );
--mnSuspendSelectCallback;
}
diff --git a/svtools/source/contnr/svimpbox.cxx b/svtools/source/contnr/svimpbox.cxx
index a7118d3..0115edf 100644
--- a/svtools/source/contnr/svimpbox.cxx
+++ b/svtools/source/contnr/svimpbox.cxx
@@ -2257,7 +2257,6 @@ BOOL SvImpLBox::KeyInput( const KeyEvent& rKEvt)
// if there is no next entry, take the current one
// this ensures that in case of _one_ entry in the list, this entry is selected when pressing
// the cursor key
- // 06.09.20001 - 83416 - fs at openoffice.org
if ( !pNewCursor && pCursor )
pNewCursor = pCursor;
diff --git a/svtools/source/control/fmtfield.cxx b/svtools/source/control/fmtfield.cxx
index 8cadc52..fe943a2 100644
--- a/svtools/source/control/fmtfield.cxx
+++ b/svtools/source/control/fmtfield.cxx
@@ -813,7 +813,6 @@ void FormattedField::FormatChanged( FORMAT_CHANGE_TYPE _nWhat )
if ( ( 0 != ( _nWhat & FCT_FORMATTER ) ) && m_pFormatter )
m_pFormatter->SetEvalDateFormat( NF_EVALDATEFORMAT_INTL_FORMAT );
- // 95845 - 03.04.2002 - fs at openoffice.org
ReFormat();
}
diff --git a/svtools/source/control/inettbc.cxx b/svtools/source/control/inettbc.cxx
index 12bf9bd..1cb8529 100644
--- a/svtools/source/control/inettbc.cxx
+++ b/svtools/source/control/inettbc.cxx
@@ -1167,7 +1167,7 @@ String SvtURLBox::GetURL()
aText.EraseTrailingChars();
if ( !aText.Len() )
return aText;
- // #i9739# - 2002-12-03 - fs at openoffice.org
+ // #i9739#
#endif
INetURLObject aObj( aText );
diff --git a/svtools/source/misc/transfer.cxx b/svtools/source/misc/transfer.cxx
index 2637db2..7601aa2 100644
--- a/svtools/source/misc/transfer.cxx
+++ b/svtools/source/misc/transfer.cxx
@@ -2301,7 +2301,7 @@ TransferableDataHelper TransferableDataHelper::CreateFromSystemClipboard( Window
{
aRet = TransferableDataHelper( xTransferable );
aRet.mxClipboard = xClipboard;
- // also copy the clipboard - 99030 - 23.05.2002 - fs at openoffice.org
+ // also copy the clipboard
}
}
catch( const ::com::sun::star::uno::Exception& )
diff --git a/svtools/source/productregistration/productregistration.cxx b/svtools/source/productregistration/productregistration.cxx
index df2e6b9..3c50f6c 100644
--- a/svtools/source/productregistration/productregistration.cxx
+++ b/svtools/source/productregistration/productregistration.cxx
@@ -333,7 +333,6 @@ namespace svt
// thus, there is no help during the lifetime of the dialog.
// To fake this, we explicitly load the necessary services when the user
// really requests help herein.
- // #110791# - 2003-06-11 - fs at openoffice.org
Reference < XInitialization > xOfficeWrapper(
m_xORB->createInstance(
OUString( RTL_CONSTASCII_USTRINGPARAM( "com.sun.star.office.OfficeWrapper" ) )
diff --git a/svtools/source/uno/unoiface.cxx b/svtools/source/uno/unoiface.cxx
index 0be9aef..4952a54 100644
--- a/svtools/source/uno/unoiface.cxx
+++ b/svtools/source/uno/unoiface.cxx
@@ -529,7 +529,7 @@ void SAL_CALL VCLXMultiLineEdit::setFocus( ) throw(::com::sun::star::uno::Runti
// does is forwarding the focus to it's text window. This text window then does a "select all".
// So if the text window already has the focus, and we give the focus to the multi line
// edit, then all which happens is that everything is selected.
- // #i27072# - 2004-04-25 - fs at openoffice.org
+ // #i27072#
if ( GetWindow() && !GetWindow()->HasChildPathFocus() )
GetWindow()->GrabFocus();
}
diff --git a/toolkit/source/awt/vclxwindow.cxx b/toolkit/source/awt/vclxwindow.cxx
index fa64c6d..fad0e06 100644
--- a/toolkit/source/awt/vclxwindow.cxx
+++ b/toolkit/source/awt/vclxwindow.cxx
@@ -745,7 +745,6 @@ void VCLXWindow::ProcessWindowEvent( const VclWindowEvent& rVclWindowEvent )
// handles a context menu command as special case of a mouse event, which is simply wrong.
// Without extending the API, we would not have another chance to notify listeners of a
// keyboard-triggered context menu request
- // 102205 - 16.08.2002 - fs at openoffice.org
aWhere = Point( -1, -1 );
}
diff --git a/toolkit/source/awt/vclxwindows.cxx b/toolkit/source/awt/vclxwindows.cxx
index 0a75b54..2257a84 100644
--- a/toolkit/source/awt/vclxwindows.cxx
+++ b/toolkit/source/awt/vclxwindows.cxx
@@ -581,7 +581,6 @@ void VCLXButton::ProcessWindowEvent( const VclWindowEvent& rVclWindowEvent )
// since we call listeners below, there is a potential that we will be destroyed
// during the listener call. To prevent the resulting crashs, we keep us
// alive as long as we're here
- // #20178# - 2003-10-01 - fs at openoffice.org
if ( maActionListeners.getLength() )
{
@@ -1024,7 +1023,6 @@ void VCLXCheckBox::ProcessWindowEvent( const VclWindowEvent& rVclWindowEvent )
// since we call listeners below, there is a potential that we will be destroyed
// in during the listener call. To prevent the resulting crashs, we keep us
// alive as long as we're here
- // #20178# - 2003-10-01 - fs at openoffice.org
CheckBox* pCheckBox = (CheckBox*)GetWindow();
if ( pCheckBox )
@@ -1298,7 +1296,6 @@ void VCLXRadioButton::ProcessWindowEvent( const VclWindowEvent& rVclWindowEvent
// since we call listeners below, there is a potential that we will be destroyed
// in during the listener call. To prevent the resulting crashs, we keep us
// alive as long as we're here
- // #20178# - 2003-10-01 - fs at openoffice.org
switch ( rVclWindowEvent.GetId() )
{
@@ -1451,7 +1448,6 @@ void VCLXSpinField::ProcessWindowEvent( const VclWindowEvent& rVclWindowEvent )
// since we call listeners below, there is a potential that we will be destroyed
// in during the listener call. To prevent the resulting crashs, we keep us
// alive as long as we're here
- // #20178# - 2003-10-01 - fs at openoffice.org
if ( maSpinListeners.getLength() )
{
@@ -1808,7 +1804,6 @@ void VCLXListBox::ProcessWindowEvent( const VclWindowEvent& rVclWindowEvent )
// since we call listeners below, there is a potential that we will be destroyed
// in during the listener call. To prevent the resulting crashs, we keep us
// alive as long as we're here
- // #20178# - 2003-10-01 - fs at openoffice.org
switch ( rVclWindowEvent.GetId() )
{
@@ -3772,7 +3767,6 @@ void VCLXScrollBar::ProcessWindowEvent( const VclWindowEvent& rVclWindowEvent )
// since we call listeners below, there is a potential that we will be destroyed
// in during the listener call. To prevent the resulting crashs, we keep us
// alive as long as we're here
- // #20178# - 2003-10-01 - fs at openoffice.org
if ( maAdjustmentListeners.getLength() )
{
@@ -4185,7 +4179,6 @@ void VCLXEdit::ProcessWindowEvent( const VclWindowEvent& rVclWindowEvent )
// since we call listeners below, there is a potential that we will be destroyed
// during the listener call. To prevent the resulting crashs, we keep us
// alive as long as we're here
- // #20178# - 2003-10-01 - fs at openoffice.org
if ( GetTextListeners().getLength() )
{
@@ -4492,7 +4485,6 @@ void VCLXComboBox::ProcessWindowEvent( const VclWindowEvent& rVclWindowEvent )
// since we call listeners below, there is a potential that we will be destroyed
// during the listener call. To prevent the resulting crashs, we keep us
// alive as long as we're here
- // #20178# - 2003-10-01 - fs at openoffice.org
switch ( rVclWindowEvent.GetId() )
{
diff --git a/toolkit/source/controls/dialogcontrol.cxx b/toolkit/source/controls/dialogcontrol.cxx
index 9dca486..0a6bd9a 100644
--- a/toolkit/source/controls/dialogcontrol.cxx
+++ b/toolkit/source/controls/dialogcontrol.cxx
@@ -1616,7 +1616,6 @@ void UnoDialogControl::ImplInsertControl( Reference< XControlModel >& rxModel, c
addControl( rName, xCtrl );
// will implicitly call addingControl, where we can add the PropertiesChangeListener to the model
// (which we formerly did herein)
- // 08.01.2001 - 96008 - fs at openoffice.org
ImplSetPosSize( xCtrl );
}
@@ -1759,7 +1758,6 @@ sal_Bool UnoDialogControl::setModel( const Reference< XControlModel >& rxModel )
removeControl( *pCtrls );
// will implicitly call removingControl, which will remove the PropertyChangeListener
// (which we formerly did herein)
- // 08.01.2001 - 96008 - fs at openoffice.org
Reference< XContainer > xC( getModel(), UNO_QUERY );
if ( xC.is() )
@@ -2412,7 +2410,6 @@ void UnoParentControl::ImplInsertControl( Reference< XControlModel >& rxModel, c
addControl( rName, xCtrl );
// will implicitly call addingControl, where we can add the PropertiesChangeListener to the model
// (which we formerly did herein)
- // 08.01.2001 - 96008 - fs at openoffice.org
ImplSetPosSize( xCtrl );
}
@@ -2519,7 +2516,6 @@ sal_Bool UnoParentControl::setModel( const Reference< XControlModel >& rxModel )
removeControl( *pCtrls );
// will implicitly call removingControl, which will remove the PropertyChangeListener
// (which we formerly did herein)
- // 08.01.2001 - 96008 - fs at openoffice.org
Reference< XContainer > xC( getModel(), UNO_QUERY );
if ( xC.is() )
diff --git a/toolkit/source/controls/unocontrol.cxx b/toolkit/source/controls/unocontrol.cxx
index 483d00f..e3f51e9 100644
--- a/toolkit/source/controls/unocontrol.cxx
+++ b/toolkit/source/controls/unocontrol.cxx
@@ -649,14 +649,13 @@ void UnoControl::ImplModelPropertiesChanged( const Sequence< PropertyChangeEvent
aGuard.clear();
// clear the guard before creating a new peer - as usual, our peer implementations use the SolarMutex
- // #82300# - 2000-12-21 - fs at openoffice.org
+
if (bNeedNewPeer && xParent.is())
{
SolarMutexGuard aVclGuard;
// and now this is the final withdrawal:
- // With 83561, I have no other idea than locking the SolarMutex here ....
+ // I have no other idea than locking the SolarMutex here ....
// I really hate the fact that VCL is not theadsafe ....
- // #83561# - 2001-03-01 - fs at openoffice.org
// Funktioniert beim Container nicht!
getPeer()->dispose();
@@ -674,7 +673,7 @@ void UnoControl::ImplModelPropertiesChanged( const Sequence< PropertyChangeEvent
// model did not cause the listeners of the controls/peers to be called
// Since the implementations for the listeners changed a lot towards 1.1, this
// would not be the case anymore, if we would not do this listener-lock below
- // #i14703# - 2003-05-23 - fs at openoffice.org
+ // #i14703#
Window* pVclPeer = VCLUnoHelper::GetWindow( getPeer() );
VCLXWindow* pPeer = pVclPeer ? pVclPeer->GetWindowPeer() : NULL;
VclListenerLock aNoVclEventMultiplexing( pPeer );
@@ -682,7 +681,6 @@ void UnoControl::ImplModelPropertiesChanged( const Sequence< PropertyChangeEvent
// setting peer properties may result in an attemp to acquire the solar mutex, 'cause the peers
// usually don't have an own mutex but use the SolarMutex instead.
// To prevent deadlocks resulting from this, we do this without our own mutex locked
- // 2000-11-03 - fs at openoffice.org
PropertyValueVectorIterator aEnd = aPeerPropertiesToSet.end();
for ( PropertyValueVectorIterator aLoop = aPeerPropertiesToSet.begin();
aLoop != aEnd;
diff --git a/toolkit/source/controls/unocontrolmodel.cxx b/toolkit/source/controls/unocontrolmodel.cxx
index 6d64763..45394f4 100644
--- a/toolkit/source/controls/unocontrolmodel.cxx
+++ b/toolkit/source/controls/unocontrolmodel.cxx
@@ -1170,7 +1170,7 @@ sal_Bool UnoControlModel::convertFastPropertyValue( Any & rConvertedValue, Any &
if ( bConverted )
rConvertedValue <<= nAsDouble;
else
- { // try as integer - 96136 - 2002-10-08 - fs at openoffice.org
+ { // try as integer
sal_Int32 nAsInteger = 0;
bConverted = ( rValue >>= nAsInteger );
if ( bConverted )
@@ -1395,7 +1395,6 @@ void UnoControlModel::setPropertyValues( const ::com::sun::star::uno::Sequence<
sal_Int32* pHandles = aHandles.getArray();
// may need to change the order in the sequence, for this we need a non-const value sequence
- // 15.05.2002 - 99314 - fs at openoffice.org
uno::Sequence< uno::Any > aValues( Values );
uno::Any* pValues = aValues.getArray();
@@ -1429,7 +1428,7 @@ void UnoControlModel::setPropertyValues( const ::com::sun::star::uno::Sequence<
// clear our guard before calling into setFastPropertyValues - this method
// will implicitly call property listeners, and this should not happen with
// our mutex locked
- // #i23451# - 2004-03-18 - fs at openoffice.org
+ // #i23451#
setFastPropertyValues( nProps, pHandles, pValues, nValidHandles );
}
else
diff --git a/toolkit/source/controls/unocontrols.cxx b/toolkit/source/controls/unocontrols.cxx
index 3a4fdfa..566f818 100644
--- a/toolkit/source/controls/unocontrols.cxx
+++ b/toolkit/source/controls/unocontrols.cxx
@@ -1131,7 +1131,7 @@ void UnoRadioButtonControl::itemStateChanged( const awt::ItemEvent& rEvent ) thr
// Thus, we suppress all events with a new state other than "1". This is unlogical, and weird, when looking
// from a pure API perspective, but it's _compatible_ with older product versions, and this is
// all which matters here.
- // #i14703# - 2003-05-23 - fs at openoffice.org
+ // #i14703#
if ( 1 == rEvent.Selected )
{
if ( maItemListeners.getLength() )
diff --git a/vcl/source/window/taskpanelist.cxx b/vcl/source/window/taskpanelist.cxx
index a65e824..c5a940b 100644
--- a/vcl/source/window/taskpanelist.cxx
+++ b/vcl/source/window/taskpanelist.cxx
@@ -127,8 +127,6 @@ void TaskPaneList::AddWindow( Window *pWindow )
// beginning, until the first window is found which has the ChildPathFocus. Now
// if this would be the ancestor window of another pane window, this would fudge
// the result
- // 2004-09-27 - fs at openoffice.org, while fixing #i33573#, which included replacing
- // the original fix for #98916# with this one here.
if ( pWindow->IsWindowOrChild( *p ) )
{
insertionPos = p + 1;
diff --git a/vcl/source/window/window.cxx b/vcl/source/window/window.cxx
index 512dd6c..62607d2 100644
--- a/vcl/source/window/window.cxx
+++ b/vcl/source/window/window.cxx
@@ -1550,7 +1550,6 @@ void Window::ImplResetReallyVisible()
// the SHOW/HIDE events serve as indicators to send child creation/destroy events to the access bridge.
// For this, the data member of the event must not be NULL.
// Previously, we did this in Window::Show, but there some events got lost in certain situations.
- // #104887# - 2004-08-10 - fs at openoffice.org
if( bBecameReallyInvisible && ImplIsAccessibleCandidate() )
ImplCallEventListeners( VCLEVENT_WINDOW_HIDE, this );
// TODO. It's kind of a hack that we're re-using the VCLEVENT_WINDOW_HIDE. Normally, we should
@@ -1593,7 +1592,6 @@ void Window::ImplSetReallyVisible()
// For this, the data member of the event must not be NULL.
// Previously, we did this in Window::Show, but there some events got lost in certain situations. Now
// we're doing it when the visibility really changes
- // #104887# - 2004-08-10 - fs at openoffice.org
if( bBecameReallyVisible && ImplIsAccessibleCandidate() )
ImplCallEventListeners( VCLEVENT_WINDOW_SHOW, this );
// TODO. It's kind of a hack that we're re-using the VCLEVENT_WINDOW_SHOW. Normally, we should
More information about the Libreoffice-commits
mailing list