[Libreoffice-commits] .: set_soenv.in

Tor Lillqvist tml at kemper.freedesktop.org
Sat May 14 17:42:56 PDT 2011


 set_soenv.in |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2f5fad1a4c28717aa4cf2a2620291d30d60d5739
Author: Tor Lillqvist <tlillqvist at novell.com>
Date:   Mon Apr 18 12:21:34 2011 +0300

    Fix from-scratch build breakage: Don't call realpath on Windows path
    
    In a from-scratch build, when running the configure script, which then
    runs the set_soenv script, the default_images symlink (that is passed
    to this function in the form of a Windows path, for some reason) does
    not exist yet, and realpath fails anyway. So don't bother calling
    realpath on Windows paths.
    
    Although I don't know whether it then will cause a problem that the
    cygpath -m call won't be able to expand the symlink as it doesn't
    exist anyway. This is a mess. And if cygpath -m expands symlinks
    anyway, why is the realpath needed at all?

diff --git a/set_soenv.in b/set_soenv.in
index 64a0418..2ea044a 100755
--- a/set_soenv.in
+++ b/set_soenv.in
@@ -2263,7 +2263,7 @@ sub PathFormat
        # Replace absolute paths or DOS paths with ...
        if ( ( $variable =~ m/^\// ) or ( $variable =~ m/:/ ) ) {
            # mixed mode paths
-           chomp( $variable = qx{realpath "$variable"} );
+           chomp( $variable = qx{realpath "$variable"} ) unless ($variable =~ m/:/);
            chomp( $variable = qx{cygpath -m "$variable"} );
        }
    }


More information about the Libreoffice-commits mailing list