[Libreoffice-commits] .: chart2/source extensions/source sc/source

Julien Nabet serval2412 at kemper.freedesktop.org
Fri Sep 9 23:11:42 PDT 2011


 chart2/source/view/axes/VPolarGrid.cxx          |   10 ++--------
 extensions/source/propctrlr/standardcontrol.cxx |    2 +-
 sc/source/ui/vba/vbarange.cxx                   |    2 +-
 3 files changed, 4 insertions(+), 10 deletions(-)

New commits:
commit 581a04f2ce1db710186f2c11585eadd1ff32440d
Author: Julien Nabet <serval2412 at yahoo.fr>
Date:   Sat Sep 10 08:11:19 2011 +0200

    Some cppcheck cleaning

diff --git a/chart2/source/view/axes/VPolarGrid.cxx b/chart2/source/view/axes/VPolarGrid.cxx
index 1d9a3cb..f318301 100644
--- a/chart2/source/view/axes/VPolarGrid.cxx
+++ b/chart2/source/view/axes/VPolarGrid.cxx
@@ -131,19 +131,13 @@ void VPolarGrid::create2DAngleGrid( const Reference< drawing::XShapes >& xLogicT
 
     double fLogicInnerRadius = m_pPosHelper->getInnerLogicRadius();
     double fLogicOuterRadius = m_pPosHelper->getOuterLogicRadius();
-    double fLogicZ      = 1.0;//as defined
 
     sal_Int32 nLinePropertiesCount = rLinePropertiesList.size();
     ::std::vector< ::std::vector< TickInfo > >::iterator aDepthIter             = rAngleTickInfos.begin();
-    sal_Int32 nDepth=0;
-    /*
-    //no subgrids so far for polar angle grid (need different radii)
-    const ::std::vector< ::std::vector< TickInfo > >::const_iterator aDepthEnd  = rAngleTickInfos.end();
-    for( ; aDepthIter != aDepthEnd && nDepth < nLinePropertiesCount
-         ; aDepthIter++, nDepth++ )
-    */
     if(nLinePropertiesCount)
     {
+        double fLogicZ      = 1.0;//as defined
+        sal_Int32 nDepth=0;
         //create axis main lines
         drawing::PointSequenceSequence aAllPoints;
         ::std::vector< TickInfo >::iterator             aTickIter = (*aDepthIter).begin();
diff --git a/extensions/source/propctrlr/standardcontrol.cxx b/extensions/source/propctrlr/standardcontrol.cxx
index 6f5c934..b065ee6 100644
--- a/extensions/source/propctrlr/standardcontrol.cxx
+++ b/extensions/source/propctrlr/standardcontrol.cxx
@@ -1260,7 +1260,6 @@ namespace pcr
     long DropDownEditControl::FindPos(long nSinglePos)
     {
         long nPos=0;
-        long nDiff=0;
         String aOutput;
         String aStr=m_pFloatingEdit->getEdit()->GetText();
         String aStr1 = GetText();
@@ -1272,6 +1271,7 @@ namespace pcr
 
         if (aStr.Len()>0)
         {
+            long nDiff=0;
             sal_Int32 nCount = aStr.GetTokenCount('\n');
 
             String aInput = aStr.GetToken(0,'\n' );
diff --git a/sc/source/ui/vba/vbarange.cxx b/sc/source/ui/vba/vbarange.cxx
index 3e26ff6..7252cc6 100644
--- a/sc/source/ui/vba/vbarange.cxx
+++ b/sc/source/ui/vba/vbarange.cxx
@@ -5488,10 +5488,10 @@ ScVbaRange::AutoFill(  const uno::Reference< excel::XRange >& Destination, const
 
     // default to include the number of Rows in the source range;
     SCCOLROW nSourceCount = ( sourceRange.aEnd.Row() - sourceRange.aStart.Row() ) + 1;
-    SCCOLROW nCount = 0;
 
     if ( sourceRange != destRange )
     {
+        SCCOLROW nCount = 0;
         // Find direction of fill, vertical or horizontal
         if ( sourceRange.aStart == destRange.aStart )
         {


More information about the Libreoffice-commits mailing list