[Libreoffice-commits] .: 2 commits - sc/qa test/inc test/source

[Kohei Yoshida]

 sc/qa/extras/sceditfieldobj-cell.cxx   |    3 ++-
 sc/qa/extras/sceditfieldobj-header.cxx |    3 ++-
 test/inc/test/beans/xpropertyset.hxx   |    2 +-
 test/source/beans/xpropertyset.cxx     |    5 +++--
 4 files changed, 8 insertions(+), 5 deletions(-)

New commits:
commit 4712cd34531f1f257238b5ededaa5f130db2abec
Author: Kohei Yoshida <kohei.yoshida at gmail.com>
Date:   Mon Apr 30 16:31:23 2012 -0400

    Test setPropertyValue().
    
    Change-Id: Idbad933cf5e3b297e7131e66202a0250b4c3def8

diff --git a/sc/qa/extras/sceditfieldobj-cell.cxx b/sc/qa/extras/sceditfieldobj-cell.cxx
index ab3217a..0f582cf 100644
--- a/sc/qa/extras/sceditfieldobj-cell.cxx
+++ b/sc/qa/extras/sceditfieldobj-cell.cxx
@@ -39,7 +39,7 @@
 #include <com/sun/star/sheet/XSpreadsheetDocument.hpp>
 #include <com/sun/star/sheet/XSpreadsheet.hpp>
 
-#define NUMBER_OF_TESTS 5
+#define NUMBER_OF_TESTS 6
 
 namespace sc_apitest {
 
@@ -60,6 +60,7 @@ public:
     // XPropertySet
     CPPUNIT_TEST(testGetPropertySetInfo);
     CPPUNIT_TEST(testGetPropertyValue);
+    CPPUNIT_TEST(testSetPropertyValue);
 
     // XTextField
     CPPUNIT_TEST(testGetPresentation);
diff --git a/sc/qa/extras/sceditfieldobj-header.cxx b/sc/qa/extras/sceditfieldobj-header.cxx
index e11dfde..69a62b8 100644
--- a/sc/qa/extras/sceditfieldobj-header.cxx
+++ b/sc/qa/extras/sceditfieldobj-header.cxx
@@ -42,7 +42,7 @@
 #include <com/sun/star/sheet/XSpreadsheet.hpp>
 #include <com/sun/star/sheet/XHeaderFooterContent.hpp>
 
-#define NUMBER_OF_TESTS 4
+#define NUMBER_OF_TESTS 5
 
 namespace sc_apitest {
 
@@ -63,6 +63,7 @@ public:
     // XPropertySet
     CPPUNIT_TEST(testGetPropertySetInfo);
     CPPUNIT_TEST(testGetPropertyValue);
+    CPPUNIT_TEST(testSetPropertyValue);
 
     // XTextContent
     CPPUNIT_TEST(testGetAnchor);
commit 5c03dca7a983b40e2870f9b72850a80e8766b157
Author: Kohei Yoshida <kohei.yoshida at gmail.com>
Date:   Mon Apr 30 16:26:07 2012 -0400

    More descriptive method name.
    
    Change-Id: I7f0d68ee59e7a36254267d652de398cc371c7f8c

diff --git a/test/inc/test/beans/xpropertyset.hxx b/test/inc/test/beans/xpropertyset.hxx
index 7479541..c69024c 100644
--- a/test/inc/test/beans/xpropertyset.hxx
+++ b/test/inc/test/beans/xpropertyset.hxx
@@ -57,7 +57,7 @@ public:
     void testRemoveVetoableChangeListener();
 
 protected:
-    virtual bool isChangeable(const rtl::OUString& rName);
+    virtual bool isPropertyValueChangeable(const rtl::OUString& rName);
 
 private:
     void fillPropsToTest(const uno::Reference<beans::XPropertySetInfo>& xPropInfo);
diff --git a/test/source/beans/xpropertyset.cxx b/test/source/beans/xpropertyset.cxx
index 1c83390..ffa1a01 100644
--- a/test/source/beans/xpropertyset.cxx
+++ b/test/source/beans/xpropertyset.cxx
@@ -69,6 +69,7 @@ void XPropertySet::testAddVetoableChangeListener()
 void XPropertySet::testSetPropertyValue()
 {
     testGetPropertySetInfo();
+    uno::Reference<beans::XPropertySet> xPropSet(init(), UNO_QUERY_THROW);
 
     // TODO: implement this.
 }
@@ -103,7 +104,7 @@ void XPropertySet::testRemoveVetoableChangeListener()
     // TODO: implement this.
 }
 
-bool XPropertySet::isChangeable(const rtl::OUString& rName)
+bool XPropertySet::isPropertyValueChangeable(const rtl::OUString& rName)
 {
     uno::Reference<beans::XPropertySet> xPropSet(init(), UNO_QUERY_THROW);
     try
@@ -177,7 +178,7 @@ void XPropertySet::fillPropsToTest(const uno::Reference<beans::XPropertySetInfo>
 
         bool bBound       = (aProp.Attributes & beans::PropertyAttribute::BOUND) != 0;
         bool bConstrained = (aProp.Attributes & beans::PropertyAttribute::CONSTRAINED) != 0;
-        bool bCanChange = isChangeable(aProp.Name);
+        bool bCanChange = isPropertyValueChangeable(aProp.Name);
 
         if (bBound && bCanChange)
             maPropsToTest.bound.push_back(aProp.Name);