[Libreoffice-commits] .: Branch 'feature/gbuild_ure' - cli_ure/CustomTarget_cli_ure_assemblies.mk cli_ure/source solenv/gbuild

[David Tardon]

Hi,

On Mon, Aug 06, 2012 at 02:26:57PM -0700, Matus Kukan wrote:
>  cli_ure/CustomTarget_cli_ure_assemblies.mk |    6 +++---
>  cli_ure/source/native/path.cxx             |    2 +-
>  solenv/gbuild/CliLibrary.mk                |    1 -
>  solenv/gbuild/platform/WNT_INTEL_MSC.mk    |    2 +-
>  4 files changed, 5 insertions(+), 6 deletions(-)
> 
>     - export random symbol so that we get icli_cppuhelper_native.lib file
>       created
>     
> diff --git a/cli_ure/source/native/path.cxx b/cli_ure/source/native/path.cxx
> index 087e0cf..97c7f36 100644
> --- a/cli_ure/source/native/path.cxx
> +++ b/cli_ure/source/native/path.cxx
> @@ -30,7 +30,7 @@
>  
>  namespace cli_ure {
>  
> -WCHAR * filename(WCHAR * path) {
> +SAL_DLLPUBLIC_EXPORT WCHAR * filename(WCHAR * path) {
>      WCHAR * f = path;
>      for (WCHAR * p = path;;) {
>          switch (*p++) {

There is something fishy going on there. filename is only used in the
same compilation unit (and not mentioned in any header, either), so it
ought not to be exported. If you send me the error message, maybe I can
find the problem. Also, marking it static instead of SAL_DLLPUBLIC_EXPORT
could help.

D.