[Libreoffice-commits] .: sw/source

Michael Stahl mst at kemper.freedesktop.org
Tue Aug 7 12:05:13 PDT 2012


 sw/source/ui/misc/redlndlg.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8a66a7789698b12f2c07169e0106413de2f39fb8
Author: Michael Stahl <mstahl at redhat.com>
Date:   Tue Aug 7 20:58:22 2012 +0200

    fdo#51832: SwRedlineAcceptDlg: fix STL conversion:
    
    62b7606fddfef9e1a7645a2d3d605f1fa3aee263 wrongly converted the call to
    aRedlineParents.DeleteAndDestroy() in
    SwRedlineAcceptDlg::RemoveParents() and erases one element less than
    the old code, which results in access to deleted SvListEntry and crash.
    
    Change-Id: Ie2749cb3f17b36649adff46c166642fccde31329

diff --git a/sw/source/ui/misc/redlndlg.cxx b/sw/source/ui/misc/redlndlg.cxx
index 6361533..ebf8dea 100644
--- a/sw/source/ui/misc/redlndlg.cxx
+++ b/sw/source/ui/misc/redlndlg.cxx
@@ -723,7 +723,7 @@ void SwRedlineAcceptDlg::RemoveParents(sal_uInt16 nStart, sal_uInt16 nEnd)
     // unfortunately by Remove it was selected from the TLB always again ...
     pTable->SelectAll(sal_False);
 
-    aRedlineParents.erase( aRedlineParents.begin() + nStart, aRedlineParents.begin() + nEnd);
+    aRedlineParents.erase( aRedlineParents.begin() + nStart, aRedlineParents.begin() + nEnd + 1);
 }
 
 void SwRedlineAcceptDlg::InsertParents(sal_uInt16 nStart, sal_uInt16 nEnd)


More information about the Libreoffice-commits mailing list