[Libreoffice-commits] .: logerrit
Libreoffice Gerrit user
logerrit at kemper.freedesktop.org
Wed Aug 22 05:15:30 PDT 2012
logerrit | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
New commits:
commit f9fa180e42453b95b75d97dc8e50eab7e38c7464
Author: Miklos Vajna <vmiklos at suse.cz>
Date: Wed Aug 22 14:14:46 2012 +0200
logerrit: --code-review=2 in review implies --submit
Change-Id: Ibd21dfdb76536ea0e0a71791a91ec87e31d49960
diff --git a/logerrit b/logerrit
index c936653..bb60473 100755
--- a/logerrit
+++ b/logerrit
@@ -146,6 +146,7 @@ case "$1" in
esac
read -p 'is the code looking good (+), bad (-) or none of that ()? ' CODEREVIEW
ask_tristate $CODEREVIEW
+ SUBMITFLAG=""
case "$ANSWER" in
"y")
read -p 'do you approve the change (+) too, or prefer someone else to do that ()? ' CODEREVIEW
@@ -153,6 +154,7 @@ case "$1" in
case "$ANSWER" in
"y")
CODEREVIEWFLAG="--code-review=2"
+ SUBMITFLAG="--submit"
;;
"n")
CODEREVIEWFLAG="--code-review=1"
@@ -185,7 +187,7 @@ case "$1" in
esac
read -p "please type a friendly comment$MESSAGEREQ: " MESSAGE
get_REVISION_for_change $CHANGEID
- ssh ${GERRITHOST?} gerrit review -m \"$MESSAGE\" $VERIFIEDFLAG $CODEREVIEWFLAG $REVISION
+ ssh ${GERRITHOST?} gerrit review -m \"$MESSAGE\" $VERIFIEDFLAG $CODEREVIEWFLAG $SUBMITFLAG $REVISION
;;
checkout)
get_SHA_for_change $2
More information about the Libreoffice-commits
mailing list