[Libreoffice-commits] .: filter/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Tue Dec 11 04:35:46 PST 2012


 filter/source/xsltdialog/xmlfiltertabdialog.cxx |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit c88508bc53e7df7ead7bc1b102da3d7dd81f7688
Author: Ivan Timofeev <timofeev.i.s at gmail.com>
Date:   Tue Dec 11 16:24:26 2012 +0400

    OUString::replaceAll unused results
    
    Change-Id: I8d8dd139e57fb00decda8705157480439009cde8

diff --git a/filter/source/xsltdialog/xmlfiltertabdialog.cxx b/filter/source/xsltdialog/xmlfiltertabdialog.cxx
index 9e9f462..2808375 100644
--- a/filter/source/xsltdialog/xmlfiltertabdialog.cxx
+++ b/filter/source/xsltdialog/xmlfiltertabdialog.cxx
@@ -55,7 +55,7 @@ XMLFilterTabDialog::XMLFilterTabDialog( Window *pParent, ResMgr& rResMgr, const
     mpNewInfo = new filter_info_impl( *mpOldInfo );
 
     OUString aTitle( GetText() );
-    aTitle.replaceAll("%s", mpNewInfo->maFilterName);
+    aTitle = aTitle.replaceAll("%s", mpNewInfo->maFilterName);
     SetText( aTitle );
 
     maTabCtrl.Show();
@@ -277,12 +277,12 @@ bool XMLFilterTabDialog::onOk()
 
         if( aReplace2.getLength() )
         {
-            aMessage.replaceAll( "%s1", aReplace1 );
-            aMessage.replaceAll( "%s2", aReplace2 );
+            aMessage = aMessage.replaceAll( "%s1", aReplace1 );
+            aMessage = aMessage.replaceAll( "%s2", aReplace2 );
         }
         else if( aReplace1.getLength() )
         {
-            aMessage.replaceAll( "%s", aReplace1 );
+            aMessage = aMessage.replaceAll( "%s", aReplace1 );
         }
 
         ErrorBox aBox(this, (WinBits)(WB_OK), aMessage );


More information about the Libreoffice-commits mailing list