[Libreoffice-commits] .: sal/inc

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Tue Dec 11 05:23:33 PST 2012


 sal/inc/rtl/ustring.hxx |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

New commits:
commit abca8e3afa1c9c42266e89b863ee69cca4b93e21
Author: Ivan Timofeev <timofeev.i.s at gmail.com>
Date:   Tue Dec 11 17:07:26 2012 +0400

    use SAL_WARN_UNUSED_RESULT for OUString::replaceAll
    
    Change-Id: I30754e4d0cb0c490e6c125ba034e2e0eac3751e7
    Reviewed-on: https://gerrit.libreoffice.org/1297
    Reviewed-by: Michael Stahl <mstahl at redhat.com>
    Tested-by: Michael Stahl <mstahl at redhat.com>

diff --git a/sal/inc/rtl/ustring.hxx b/sal/inc/rtl/ustring.hxx
index bd1b9cb..5760914 100644
--- a/sal/inc/rtl/ustring.hxx
+++ b/sal/inc/rtl/ustring.hxx
@@ -1614,7 +1614,9 @@ public:
 
       @since LibreOffice 4.0
     */
-    OUString replaceAll(OUString const & from, OUString const & to, sal_Int32 fromIndex = 0) const {
+    SAL_WARN_UNUSED_RESULT OUString replaceAll(
+        OUString const & from, OUString const & to, sal_Int32 fromIndex = 0) const
+    {
         rtl_uString * s = 0;
         rtl_uString_newReplaceAllFromIndex(&s, pData, from.pData, to.pData, fromIndex);
         return OUString(s, SAL_NO_ACQUIRE);
@@ -1634,7 +1636,7 @@ public:
       @since LibreOffice 3.6
     */
     template< typename T >
-    typename internal::ConstCharArrayDetector< T, OUString >::Type replaceAll( T& from, OUString const & to) const
+    SAL_WARN_UNUSED_RESULT typename internal::ConstCharArrayDetector< T, OUString >::Type replaceAll( T& from, OUString const & to) const
     {
         rtl_uString * s = 0;
         assert( strlen( from ) == internal::ConstCharArrayDetector< T >::size - 1 );
@@ -1656,7 +1658,7 @@ public:
       @since LibreOffice 3.6
     */
     template< typename T1, typename T2 >
-    typename internal::ConstCharArrayDetector< T1, typename internal::ConstCharArrayDetector< T2, OUString >::Type >::Type
+    SAL_WARN_UNUSED_RESULT typename internal::ConstCharArrayDetector< T1, typename internal::ConstCharArrayDetector< T2, OUString >::Type >::Type
         replaceAll( T1& from, T2& to ) const
     {
         rtl_uString * s = 0;


More information about the Libreoffice-commits mailing list