[Libreoffice-commits] .: Branch 'libreoffice-3-6' - writerfilter/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Wed Dec 12 07:38:41 PST 2012


 writerfilter/source/dmapper/DomainMapper_Impl.cxx |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

New commits:
commit 8454a88e1818fa498c6860a2db434ad51591257c
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Jul 5 21:37:49 2012 +0100

    Resolves: fdo#49587 apparent loop in style hierarchy
    
    Change-Id: I32317a1a6500377f7e7bb98d1dcc65ad86feb9a2
    (cherry picked from commit 7e3923520c27ff139bc3abab35a1c01e1a785fb1)
    
    Signed-off-by: Michael Stahl <mstahl at redhat.com>

diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 951d500..2296761 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -572,7 +572,14 @@ uno::Any DomainMapper_Impl::GetPropertyFromStyleSheet(PropertyIds eId)
             }
         }
         //search until the property is set or no parent is available
-        pEntry = GetStyleSheetTable()->FindParentStyleSheet(pEntry->sBaseStyleIdentifier);
+        StyleSheetEntryPtr pNewEntry = GetStyleSheetTable()->FindParentStyleSheet(pEntry->sBaseStyleIdentifier);
+
+        SAL_WARN_IF( pEntry == pNewEntry, "writerfilter", "circular loop in style hierarchy?");
+
+        if (pEntry == pNewEntry) //fdo#49587
+            break;
+
+        pEntry = pNewEntry;
     }
     return uno::Any();
 }


More information about the Libreoffice-commits mailing list