[Libreoffice-commits] .: sc/source

Julien Nabet serval2412 at kemper.freedesktop.org
Sat Feb 4 12:52:27 PST 2012


 sc/source/ui/app/scmod.cxx    |    2 +-
 sc/source/ui/view/cellsh1.cxx |    2 +-
 sc/source/ui/view/editsh.cxx  |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit bf2300fb0704f92f312b96b2e624a1730df5dd45
Author: Julien Nabet <serval2412 at yahoo.fr>
Date:   Sat Feb 4 21:50:55 2012 +0100

    Fix 3 "Possible inefficient checking"

diff --git a/sc/source/ui/app/scmod.cxx b/sc/source/ui/app/scmod.cxx
index 47ef6b9..a9da20e 100644
--- a/sc/source/ui/app/scmod.cxx
+++ b/sc/source/ui/app/scmod.cxx
@@ -2162,7 +2162,7 @@ sal_Bool  ScModule::UnregisterRefWindow( sal_uInt16 nSlotId, Window *pWnd )
 
     rlRefWindow.erase( i );
 
-    if( !rlRefWindow.size() )
+    if( rlRefWindow.empty() )
         m_mapRefWindow.erase( nSlotId );
 
     return sal_True;
diff --git a/sc/source/ui/view/cellsh1.cxx b/sc/source/ui/view/cellsh1.cxx
index e9a574f..603d7b8 100644
--- a/sc/source/ui/view/cellsh1.cxx
+++ b/sc/source/ui/view/cellsh1.cxx
@@ -1836,7 +1836,7 @@ void ScCellShell::ExecuteEdit( SfxRequest& rReq )
                                 pScMod->InputKeyEvent( KeyEvent('=',KeyCode()) );
 
                                 std::vector<rtl::OUString> aNames = pDlg->GetSelectedNames();
-                                if (aNames.size())
+                                if (!aNames.empty())
                                 {
                                     rtl::OUStringBuffer aBuffer;
                                     for (std::vector<rtl::OUString>::const_iterator itr = aNames.begin();
diff --git a/sc/source/ui/view/editsh.cxx b/sc/source/ui/view/editsh.cxx
index c843e96..e339b2c 100644
--- a/sc/source/ui/view/editsh.cxx
+++ b/sc/source/ui/view/editsh.cxx
@@ -438,7 +438,7 @@ void ScEditShell::Execute( SfxRequest& rReq )
                 if ( nRet == BTN_PASTE_NAME )
                 {
                     std::vector<rtl::OUString> aNames = pDlg->GetSelectedNames();
-                    if (aNames.size())
+                    if (!aNames.empty())
                     {
                         rtl::OUStringBuffer aBuffer;
                         for (std::vector<rtl::OUString>::const_iterator itr = aNames.begin();


More information about the Libreoffice-commits mailing list