[Libreoffice-commits] .: Branch 'libreoffice-3-5' - connectivity/source

Radek Doulík rodo at kemper.freedesktop.org
Mon Feb 13 07:35:21 PST 2012


 connectivity/source/drivers/postgresql/pq_databasemetadata.cxx |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

New commits:
commit d951032005eabd1beb49b3c4c47ab560143e9ae9
Author: Lionel Elie Mamane <lionel at mamane.lu>
Date:   Thu Feb 9 18:34:04 2012 +0100

    fdo#45249 declare support for Core SQL -> Base allows user aggregate functions

diff --git a/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx b/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx
index d2e4927..b2afc79 100644
--- a/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx
+++ b/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx
@@ -724,7 +724,12 @@ sal_Bool DatabaseMetaData::supportsMinimumSQLGrammar(  ) throw (SQLException, Ru
 sal_Bool DatabaseMetaData::supportsCoreSQLGrammar(  ) throw (SQLException, RuntimeException)
 {
     // LEM: jdbc driver says not, although the comments in it seem old
-    return sal_False;
+    //      fdo#45249 Base query design won't use any aggregate function
+    //      (except COUNT(*) unless we say yes, so say yes.
+    //      Actually, Base assumes *also* support for aggregate functions "collect, fusion, intersection"
+    //      as soon as supportsCoreSQLGrammar() returns true.
+    //      Those are *not* Core SQL, though. They are in optional feature S271 "Basic multiset support"
+    return sal_True;
 }
 
 sal_Bool DatabaseMetaData::supportsExtendedSQLGrammar(  ) throw (SQLException, RuntimeException)


More information about the Libreoffice-commits mailing list