[Libreoffice-commits] .: oox/source
Thorsten Behrens
thorsten at kemper.freedesktop.org
Thu Feb 16 01:39:21 PST 2012
oox/source/drawingml/diagram/diagramlayoutatoms.cxx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 905df1bae9cab296ee7dd07e88813c667788ed8a
Author: Thorsten Behrens <tbehrens at suse.com>
Date: Thu Feb 16 10:35:12 2012 +0100
Fix crash in smartart import
Rather check iterator validity *before* accessing it. valgrind
warning on linux, and crash on windows for e.g. doc at n#736495.
diff --git a/oox/source/drawingml/diagram/diagramlayoutatoms.cxx b/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
index 493dcf2..29a9cb9 100644
--- a/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
+++ b/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
@@ -394,8 +394,8 @@ bool LayoutNode::setupShape( const ShapePtr& rShape, const Diagram& rDgm, sal_uI
{
// find the data node to grab text from
DiagramData::PointsNameMap::const_iterator aDataNode=rDgm.getData()->getPointsPresNameMap().find(msName);
- if( aDataNode->second.size() > nIdx &&
- aDataNode != rDgm.getData()->getPointsPresNameMap().end() )
+ if( aDataNode != rDgm.getData()->getPointsPresNameMap().end() &&
+ aDataNode->second.size() > nIdx )
{
OSL_TRACE( "Filling content from %d th layout node named \"%s\", modelId \"%s\"",
nIdx,
More information about the Libreoffice-commits
mailing list