[Libreoffice-commits] .: solenv/bin

Miklos Vajna vmiklos at kemper.freedesktop.org
Thu Jan 26 08:35:00 PST 2012


 solenv/bin/modules/installer/scriptitems.pm |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 439e5279c5d334f849a6ab7b51bad1bb12f13aae
Author: Miklos Vajna <vmiklos at frugalware.org>
Date:   Thu Jan 26 17:27:03 2012 +0100

    solenv: handle error code from ./g
    
    This avoids "Cannot find the git binary! Is git installed and is in
    PATH?" strings in the about dialog when building from a tarball.

diff --git a/solenv/bin/modules/installer/scriptitems.pm b/solenv/bin/modules/installer/scriptitems.pm
index a8963a4..905b37e 100644
--- a/solenv/bin/modules/installer/scriptitems.pm
+++ b/solenv/bin/modules/installer/scriptitems.pm
@@ -815,8 +815,8 @@ sub replace_setup_variables
 
     if ( $localbuild =~ /^\s*(\w+?)(\d+)\s*$/ ) { $localbuild = $2; }   # using "680" instead of "src680"
 
-    my $buildidstring = `$ENV{'SRC_ROOT'}/g -s log -n 1 --pretty=format:%h- ; git describe --abbrev=0`;
-    if (!$buildidstring) {
+    my $buildidstring = `$ENV{'SRC_ROOT'}/g -s log -n 1 --pretty=format:%h- && git describe --abbrev=0`;
+    if ($? || !$buildidstring) {
         $buildidstring = $localbuild . $localminor . "(Build:" . $installer::globals::buildid . ")";
     }
     else {


More information about the Libreoffice-commits mailing list