[Libreoffice-commits] Changes to 'feature/gsoc-calc-perf2'

Kohei Yoshida kohei at kemper.freedesktop.org
Thu Jul 19 18:27:04 PDT 2012


New branch 'feature/gsoc-calc-perf2' available with the following commits:
commit eb00ef223ff39a8baebe7cefd7e37a2b013f9da3
Author: Daniel Bankston <daniel.e.bankston at gmail.com>
Date:   Sat Jul 14 00:53:07 2012 -0500

    Revert "Fix for ods matrix import performance"
    
    This reverts commit cb14c160489254298eb03f7406107e06395943d1.
    
    This approach causes problems with chained matrix cell dependencies
    initally after load.

commit de9c56a0a73ef5a2c761c6107428a5725a7399b3
Author: Daniel Bankston <daniel.e.bankston at gmail.com>
Date:   Fri Jul 13 00:27:36 2012 -0500

    Fix for ods matrix import performance
    
    Our latest changes that recalculate volatile formulas at the end of import
    resulted in several seconds performance loss on a large matrix test file
    with complex formulas.
    
    When the matrix cells are put in the document, ScFormulaCell::SetDirty()
    gets called.  Although the cells are set clean during import after this,
    SetDirty() also uses ScDocument::TrackFormulas() which puts the cells in
    the formula tree.  So when we call ScDocument::DoRecalc() at the end of
    import, the interpreter goes through all matrix cells because they are
    in the formula tree.
    
    This commit prevent that from happening, which gives us back our performance.
    
    Change-Id: Icdf436065e4a238aa0bf910badfd58757087803a

commit b6723d28cbdb2b7b1b4c7a41a7b437d41f40319d
Author: Daniel Bankston <daniel.e.bankston at gmail.com>
Date:   Thu Jul 12 08:48:40 2012 -0500

    Disable adjust height flag once for whole doc instead for each tab
    
    Change-Id: Ib82a72d257772b3dcdf9368c4ee5850a6f411d6e

commit e77d1f923f4d429006b67802d8125e6d5fc52c5d
Author: Daniel Bankston <daniel.e.bankston at gmail.com>
Date:   Thu Jul 12 08:23:54 2012 -0500

    Check for more cases of functions that should always be recalculated
    
    Thanks to Eike Rathke for pointing this out.
    
    Change-Id: Ie2ce2ebe54cd290a7bf1c55d58790e21833b1105



More information about the Libreoffice-commits mailing list