[Libreoffice-commits] .: 3 commits - forms/source sfx2/inc sfx2/source sw/source
Kohei Yoshida
kohei at kemper.freedesktop.org
Wed Jul 25 13:23:59 PDT 2012
forms/source/component/clickableimage.cxx | 21 ---------------------
sfx2/inc/sfx2/docfile.hxx | 1 -
sfx2/inc/sfx2/objsh.hxx | 1 -
sfx2/source/appl/fileobj.cxx | 2 --
sfx2/source/bastyp/sfxhtml.cxx | 10 +---------
sfx2/source/doc/docfile.cxx | 11 -----------
sfx2/source/doc/objmisc.cxx | 14 --------------
sfx2/source/doc/objstor.cxx | 5 +----
sw/source/core/unocore/unocrsrhelper.cxx | 1 -
sw/source/filter/html/htmlcss1.cxx | 4 ----
sw/source/ui/uiview/view2.cxx | 2 +-
11 files changed, 3 insertions(+), 69 deletions(-)
New commits:
commit 3824ec8ea57db309f00b79337c81b7401dc19c58
Author: Kohei Yoshida <kohei.yoshida at gmail.com>
Date: Wed Jul 25 16:24:31 2012 -0400
Fix the dbgutil build.
Change-Id: Ic6142550a7e76b2b1cd8ff6d53d503d771c32b7c
diff --git a/sfx2/source/doc/objstor.cxx b/sfx2/source/doc/objstor.cxx
index c5645fd..ed80ba2 100644
--- a/sfx2/source/doc/objstor.cxx
+++ b/sfx2/source/doc/objstor.cxx
@@ -1643,7 +1643,7 @@ sal_Bool SfxObjectShell::SaveTo_Impl
else if (!pMedium->GetName().isEmpty()
|| ( pMedium->HasStorage_Impl() && pMedium->WillDisposeStorageOnClose_Impl() ) )
{
- OSL_ENSURE( pMedium->GetName().Len(), "Fallback is used, the medium without name should not dispose the storage!\n" );
+ OSL_ENSURE(!pMedium->GetName().isEmpty(), "Fallback is used, the medium without name should not dispose the storage!\n");
// copy storage of old medium to new temporary storage and take this over
if( !ConnectTmpStorage_Impl( pMedium->GetStorage(), pMedium ) )
{
commit 73bc1c8b7a43ce74540556ef458212c1873d9160
Author: Kohei Yoshida <kohei.yoshida at gmail.com>
Date: Wed Jul 25 16:23:13 2012 -0400
Referer was set to SfxMedium but was never used. Removing it.
Change-Id: I88ab874d4efc60d58722f0bb175d14a4d443398b
diff --git a/forms/source/component/clickableimage.cxx b/forms/source/component/clickableimage.cxx
index 8896be8..e58d914 100644
--- a/forms/source/component/clickableimage.cxx
+++ b/forms/source/component/clickableimage.cxx
@@ -790,26 +790,12 @@ namespace frm
#ifdef USE_REGISTER_TRANSFER
if( pObjSh )
{
- // Medium registrieren, damit abgebrochen werden kann
- pObjSh->RegisterTransfer( *m_pMedium );
-
// Target-Frame uebertragen, damit auch javascript:-URLs
// "geladen" werden koennen.
const SfxMedium *pShMedium = pObjSh->GetMedium();
if( pShMedium )
m_pMedium->SetLoadTargetFrame(pShMedium->GetLoadTargetFrame());
}
- else
- {
- // Keine Object-Shell, aber ein Medium? Dann uebernehmen wir
- // zumindest den Referer.
- if( xModel.is() )
- {
- ::rtl::OUString sReferer( xModel->getURL() );
- if( sReferer.getLength() )
- m_pMedium->SetReferer( OUStringToString(sReferer, CHARSET_SYSTEM) );
- }
- }
#else
if( pObjSh )
{
@@ -819,13 +805,6 @@ namespace frm
if( pShMedium )
m_pMedium->SetLoadTargetFrame(pShMedium->GetLoadTargetFrame());
}
-
- if( xModel.is() )
- {
- ::rtl::OUString sReferer( xModel->getURL() );
- if( !sReferer.isEmpty() )
- m_pMedium->SetReferer( sReferer );
- }
#endif
// Downloading-Flag auf sal_True setzen. Es werden dann auch
diff --git a/sfx2/inc/sfx2/docfile.hxx b/sfx2/inc/sfx2/docfile.hxx
index deaa077..abf61a0 100644
--- a/sfx2/inc/sfx2/docfile.hxx
+++ b/sfx2/inc/sfx2/docfile.hxx
@@ -122,7 +122,6 @@ public:
void SetLoadTargetFrame(SfxFrame* pFrame );
SfxFrame* GetLoadTargetFrame() const;
- void SetReferer( const String& rRefer );
void SetFilter(const SfxFilter *pFlt, sal_Bool bResetOrig = sal_False);
const SfxFilter* GetFilter() const;
const SfxFilter * GetOrigFilter( sal_Bool bNotCurrent = sal_False ) const;
diff --git a/sfx2/inc/sfx2/objsh.hxx b/sfx2/inc/sfx2/objsh.hxx
index 1fad0b6..29710c6 100644
--- a/sfx2/inc/sfx2/objsh.hxx
+++ b/sfx2/inc/sfx2/objsh.hxx
@@ -433,7 +433,6 @@ public:
// Transfer IFace
void AbortImport();
sal_Bool IsAbortingImport() const;
- void RegisterTransfer( SfxMedium& rMedium );
sal_Bool IsReloading() const;
void FinishedLoading( sal_uInt16 nWhich = SFX_LOADED_ALL );
void TemplateDisconnectionAfterLoad();
diff --git a/sfx2/source/appl/fileobj.cxx b/sfx2/source/appl/fileobj.cxx
index e223d3c..9a9c6ff 100644
--- a/sfx2/source/appl/fileobj.cxx
+++ b/sfx2/source/appl/fileobj.cxx
@@ -267,8 +267,6 @@ sal_Bool SvFileObject::LoadFile_Impl()
xMed->setStreamToLoadFrom(
aStreamToLoadFrom.m_xInputStreamToLoadFrom,
aStreamToLoadFrom.m_bIsReadOnly);
- if( sReferer.Len() )
- xMed->SetReferer( sReferer );
if( !bSynchron )
{
diff --git a/sfx2/source/bastyp/sfxhtml.cxx b/sfx2/source/bastyp/sfxhtml.cxx
index 7ddd42f..fd6578d 100644
--- a/sfx2/source/bastyp/sfxhtml.cxx
+++ b/sfx2/source/bastyp/sfxhtml.cxx
@@ -225,21 +225,13 @@ IMAPOBJ_SETEVENT:
return bNewArea;
}
-
-void SfxHTMLParser::StartFileDownload( const String& rURL,
- SfxObjectShell *pSh )
+void SfxHTMLParser::StartFileDownload( const String& rURL, SfxObjectShell* /*pSh*/ )
{
DBG_ASSERT( !pDLMedium, "StartFileDownload when active Download" );
if( pDLMedium )
return;
pDLMedium = new SfxMedium( rURL, SFX_STREAM_READONLY );
- if( pSh )
- {
- // Register the medium, so that it can be stopped.
- pSh->RegisterTransfer( *pDLMedium );
- }
-
pDLMedium->DownLoad();
}
diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx
index 99758f4..e8534ad 100644
--- a/sfx2/source/doc/docfile.cxx
+++ b/sfx2/source/doc/docfile.cxx
@@ -287,7 +287,6 @@ public:
const SfxFilter* pOrigFilter;
rtl::OUString aOrigURL;
- String aReferer;
DateTime aExpireTime;
SfxFrameWeak wLoadTargetFrame;
SvKeyValueIteratorRef xAttributes;
@@ -3007,15 +3006,6 @@ const INetURLObject& SfxMedium::GetURLObject() const
return *pImp->m_pURLObj;
}
-//----------------------------------------------------------------
-
-void SfxMedium::SetReferer( const String& rRefer )
-{
- pImp->aReferer = rRefer;
-}
-
-//----------------------------------------------------------------
-
void SfxMedium::SetExpired_Impl( const DateTime& rDateTime )
{
pImp->aExpireTime = rDateTime;
diff --git a/sfx2/source/doc/objmisc.cxx b/sfx2/source/doc/objmisc.cxx
index 4a147c5..5aa85a2 100644
--- a/sfx2/source/doc/objmisc.cxx
+++ b/sfx2/source/doc/objmisc.cxx
@@ -1043,20 +1043,6 @@ void SfxObjectShell::SetActivateEvent_Impl(sal_uInt16 nId )
pImp->nEventId = nId;
}
-//--------------------------------------------------------------------
-
-void SfxObjectShell::RegisterTransfer( SfxMedium& rMedium )
-/* [Description]
-
- All media, which are placed in order to load parts of a document must be
- registered by a related SfxObjectShell. Thus documents can be canceled.
-*/
-{
- rMedium.SetReferer( GetMedium()->GetName() );
-}
-
-//-------------------------------------------------------------------------
-
void SfxObjectShell::PrepareReload( )
/* [Description]
diff --git a/sfx2/source/doc/objstor.cxx b/sfx2/source/doc/objstor.cxx
index c0c33fb..c5645fd 100644
--- a/sfx2/source/doc/objstor.cxx
+++ b/sfx2/source/doc/objstor.cxx
@@ -1622,9 +1622,6 @@ sal_Bool SfxObjectShell::SaveTo_Impl
AddLog( ::rtl::OUString( OSL_LOG_PREFIX "Medium commit." ) );
- // transfer data to its destinated location
- // the medium commits the storage or the stream it is based on
- RegisterTransfer( rMedium );
bOk = rMedium.Commit();
if ( bOk )
diff --git a/sw/source/core/unocore/unocrsrhelper.cxx b/sw/source/core/unocore/unocrsrhelper.cxx
index 3ee52b0..f66a4fb 100644
--- a/sw/source/core/unocore/unocrsrhelper.cxx
+++ b/sw/source/core/unocore/unocrsrhelper.cxx
@@ -875,7 +875,6 @@ void InsertFile(SwUnoCrsr* pUnoCrsr,
// this sourcecode is not responsible for the lifetime of the shell, SfxObjectShellLock should not be used
SfxObjectShellRef aRef( pDocSh );
- pDocSh->RegisterTransfer( *pMed );
pMed->DownLoad(); // if necessary: start the download
if( aRef.Is() && 1 < aRef->GetRefCount() ) // Ref still valid?
{
diff --git a/sw/source/filter/html/htmlcss1.cxx b/sw/source/filter/html/htmlcss1.cxx
index 36dfe97..ecc0f58 100644
--- a/sw/source/filter/html/htmlcss1.cxx
+++ b/sw/source/filter/html/htmlcss1.cxx
@@ -1742,10 +1742,6 @@ sal_Bool SwHTMLParser::FileDownload( const String& rURL,
// Ein Medium anlegen
SfxMedium aDLMedium( rURL, STREAM_READ | STREAM_SHARE_DENYWRITE );
- // Medium registrieren, damit abgebrochen werden kann
- if( pDoc->GetDocShell() )
- pDoc->GetDocShell()->RegisterTransfer( aDLMedium );
-
SvStream* pStream = aDLMedium.GetInStream();
if( pStream )
{
diff --git a/sw/source/ui/uiview/view2.cxx b/sw/source/ui/uiview/view2.cxx
index 9ca89f8..7dfbe02 100644
--- a/sw/source/ui/uiview/view2.cxx
+++ b/sw/source/ui/uiview/view2.cxx
@@ -2032,7 +2032,7 @@ long SwView::InsertMedium( sal_uInt16 nSlotId, SfxMedium* pMedium, sal_Int16 nVe
delete pMedium;
return -1;
}
- pDocSh->RegisterTransfer( *pMedium );
+
pMedium->DownLoad(); // ggfs. den DownLoad anstossen
if( aRef.Is() && 1 < aRef->GetRefCount() ) // noch gueltige Ref?
{
commit dd41664543a9ae09d73dd1bb157ffd1e792731f8
Author: Kohei Yoshida <kohei.yoshida at gmail.com>
Date: Wed Jul 25 15:59:11 2012 -0400
Nobody uses this guy.
Change-Id: I514852cabb785cc3a3e9efd934e4e435a5379495
diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx
index 5e6851b..99758f4 100644
--- a/sfx2/source/doc/docfile.cxx
+++ b/sfx2/source/doc/docfile.cxx
@@ -287,7 +287,6 @@ public:
const SfxFilter* pOrigFilter;
rtl::OUString aOrigURL;
- String aPreRedirectionURL;
String aReferer;
DateTime aExpireTime;
SfxFrameWeak wLoadTargetFrame;
More information about the Libreoffice-commits
mailing list