[Libreoffice-commits] .: 2 commits - sc/source

[Eike Rathke]

 sc/source/core/tool/interpr1.cxx |    4 ++--
 sc/source/core/tool/token.cxx    |   13 -------------
 2 files changed, 2 insertions(+), 15 deletions(-)

New commits:
commit 1e8650e0c0902181ac4431fc4fded40abe55a781
Author: Eike Rathke <erack at redhat.com>
Date:   Tue Jun 26 21:57:33 2012 +0200

    removed unused lcl_IsReference()
    
    Change-Id: I1f79bf11105e06cf713db11a6e00cd41a3aab06b

diff --git a/sc/source/core/tool/token.cxx b/sc/source/core/tool/token.cxx
index 99b0713..1d7f2a1 100644
--- a/sc/source/core/tool/token.cxx
+++ b/sc/source/core/tool/token.cxx
@@ -116,19 +116,6 @@ IMPL_FIXEDMEMPOOL_NEWDEL( ScSingleRefToken )
 // Need quite a lot of ScDoubleRefToken
 IMPL_FIXEDMEMPOOL_NEWDEL( ScDoubleRefToken )
 
-// --- helpers --------------------------------------------------------------
-
-inline bool lcl_IsReference( OpCode eOp, StackVar eType )
-{
-    return
-        (eOp == ocPush && (eType == svSingleRef || eType == svDoubleRef))
-        || (eOp == ocColRowNameAuto && eType == svDoubleRef)
-        || (eOp == ocColRowName && eType == svSingleRef)
-        || (eOp == ocMatRef && eType == svSingleRef)
-        ;
-}
-
-
 // --- class ScRawToken -----------------------------------------------------
 
 xub_StrLen ScRawToken::GetStrLen( const sal_Unicode* pStr )
commit a323d44a95c8e4a82599fa33d7d78d4d407741d0
Author: Eike Rathke <erack at redhat.com>
Date:   Tue Jun 26 21:49:01 2012 +0200

    bring some sense into translated comment
    
    Change-Id: I045927b3310ddef6208a1d0a837ed6bc098f9ca8

diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx
index f3090bf..a7f6572 100644
--- a/sc/source/core/tool/interpr1.cxx
+++ b/sc/source/core/tool/interpr1.cxx
@@ -2970,14 +2970,14 @@ void ScInterpreter::ScN()
 
 void ScInterpreter::ScTrim()
 {
-    // Doesn't only trim but writes out twice!
+    // Doesn't only trim but also removes duplicated blanks within!
     String aVal = comphelper::string::strip(GetString(), ' ');
     String aStr;
     register const sal_Unicode* p = aVal.GetBuffer();
     register const sal_Unicode* const pEnd = p + aVal.Len();
     while ( p < pEnd )
     {
-        if ( *p != ' ' || p[-1] != ' ' )    // ' ' can't be first, -1 is fine too
+        if ( *p != ' ' || p[-1] != ' ' )    // first can't be ' ', so -1 is fine
             aStr += *p;
         p++;
     }