[Libreoffice-commits] .: logerrit

Miklos Vajna vmiklos at kemper.freedesktop.org
Fri Jun 29 00:59:33 PDT 2012


 logerrit |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

New commits:
commit 616ad0b94ca3f200809999d19595b6a69a2a6969
Author: Miklos Vajna <vmiklos at suse.cz>
Date:   Fri Jun 29 09:59:14 2012 +0200

    logerrit review: fix missing escaping, codereview -> code-review
    
    Change-Id: Icf5facbb59cba2116ae3fc6bdfc035673cf47985

diff --git a/logerrit b/logerrit
index 52be193..851af7d 100755
--- a/logerrit
+++ b/logerrit
@@ -127,13 +127,13 @@ case "$1" in
 				ask_tristate $CODEREVIEW
 				case "$ANSWER" in
 					"y")
-						CODEREVIEWFLAG="--codereview=2"
+						CODEREVIEWFLAG="--code-review=2"
 					;;
 					"n")
-						CODEREVIEWFLAG="--codereview=1"
+						CODEREVIEWFLAG="--code-review=1"
 					;;
 					*)
-						CODEREVIEWFLAG="--codereview=1"
+						CODEREVIEWFLAG="--code-review=1"
 					;;
 				esac
 			;;
@@ -142,15 +142,15 @@ case "$1" in
 				ask_tristate $CODEREVIEW
 				case "$ANSWER" in
 					"y")
-						CODEREVIEWFLAG="--codereview=-1"
+						CODEREVIEWFLAG="--code-review=-1"
 						MESSAGEREQ="$MESSAGEREQ and explain why you have reservations about the code"
 					;;
 					"n")
-						CODEREVIEWFLAG="--codereview=-2"
+						CODEREVIEWFLAG="--code-review=-2"
 						MESSAGEREQ="$MESSAGEREQ and explain why you want to block this"
 					;;
 					*)
-						CODEREVIEWFLAG="--codereview=-1"
+						CODEREVIEWFLAG="--code-review=-1"
 						MESSAGEREQ="$MESSAGEREQ and explain why you have reservations about the code"
 					;;
 				esac
@@ -159,7 +159,7 @@ case "$1" in
 			;;
 		esac
 		read -p "please type a friendly comment$MESSAGEREQ: " MESSAGE
-		echo ssh ${GERRITHOST?} gerrit review -m \"$MESSAGE\" $VERIFIEDFLAG $CODEREVIEWFLAG $CHANGEID
+		echo ssh ${GERRITHOST?} gerrit review -m '\"'$MESSAGE'\"' $VERIFIEDFLAG $CODEREVIEWFLAG $CHANGEID
 	;;
 	checkout)
 		get_SHA_for_change $2


More information about the Libreoffice-commits mailing list