[Libreoffice-commits] .: Branch 'libreoffice-3-5' - qadevOOo/tests

Michael Meeks michael at kemper.freedesktop.org
Thu Mar 8 03:42:57 PST 2012


 qadevOOo/tests/java/ifc/beans/_XPropertySet.java |    4 ++++
 1 file changed, 4 insertions(+)

New commits:
commit b4931cf9e7d5a4bcda7c52c46d6c4f5e32420396
Author: Michael Stahl <mstahl at redhat.com>
Date:   Tue Mar 6 23:51:54 2012 +0100

    qadevOOo: _XPropertySet.java: fix unrealistic expectations:
    
    We can't assume that when setting properties whose semantics we don't
    know to random values in an arbitrary order, a non-changing value
    indicates any kind of error.
    The only real error this test can detect is if setting a property
    crashes.
    
    Signed-off-by: Michael Meeks <michael.meeks at suse.com>

diff --git a/qadevOOo/tests/java/ifc/beans/_XPropertySet.java b/qadevOOo/tests/java/ifc/beans/_XPropertySet.java
index 07efacb..09e933f 100644
--- a/qadevOOo/tests/java/ifc/beans/_XPropertySet.java
+++ b/qadevOOo/tests/java/ifc/beans/_XPropertySet.java
@@ -319,11 +319,15 @@ public class _XPropertySet extends MultiMethodTest {
                         "property '"+ propertyName+"'");
                     e.printStackTrace(log);
                 } // end of try-catch
+                /*  this is stupid: we can't set properties whose semantics we
+                 *  don't know to random values in an arbitrary order and
+                 *  expect that to actually work.
                 if( gValue.equals(sValue) )
                 {
                     log.println("setting property '"+ propertyName+"' failed");
                     error = true;
                 }
+                */
             }
             tRes.tested("setPropertyValue()",!error);
         } //endif


More information about the Libreoffice-commits mailing list