[Libreoffice-commits] .: filter/source sal/osl

Julien Nabet serval2412 at kemper.freedesktop.org
Wed May 30 12:16:12 PDT 2012


 filter/source/graphicfilter/icgm/cgm.cxx |    2 +-
 sal/osl/unx/file.cxx                     |    2 --
 sal/osl/w32/file.cxx                     |    2 --
 3 files changed, 1 insertion(+), 5 deletions(-)

New commits:
commit e519306d498208484b72d935a3923af4a9adbbcb
Author: Julien Nabet <serval2412 at yahoo.fr>
Date:   Wed May 30 20:54:37 2012 +0200

    Some cppcheck cleaning
    
    More information on this thread:
    http://nabble.documentfoundation.org/Advice-needed-about-some-cppcheck-reports-td3986408.html
    
    Change-Id: Ib70532ad72e8418e1036bd52c07dc6452508cd12

diff --git a/filter/source/graphicfilter/icgm/cgm.cxx b/filter/source/graphicfilter/icgm/cgm.cxx
index 8023fa7..3dd2ccc 100644
--- a/filter/source/graphicfilter/icgm/cgm.cxx
+++ b/filter/source/graphicfilter/icgm/cgm.cxx
@@ -266,7 +266,7 @@ double CGM::ImplGetFloat( RealPrecision eRealPrecision, sal_uInt32 nRealSize )
             nRetValue += (double)nVal;
             if ( pLong[ nSwitch ] < 0 )
             {
-                nRetValue -= nRetValue;
+                nRetValue = -nRetValue;
             }
             nRetValue /= 65536;
         }
diff --git a/sal/osl/unx/file.cxx b/sal/osl/unx/file.cxx
index 1d8ab6c..3a5dac5 100644
--- a/sal/osl/unx/file.cxx
+++ b/sal/osl/unx/file.cxx
@@ -1257,8 +1257,6 @@ SAL_CALL osl_mapFile (
             if (nSize > 0)
             {
                 c^= pData[0];
-                pData += nSize;
-                nSize = 0;
             }
         }
     }
diff --git a/sal/osl/w32/file.cxx b/sal/osl/w32/file.cxx
index 341947f..70bca8b 100644
--- a/sal/osl/w32/file.cxx
+++ b/sal/osl/w32/file.cxx
@@ -876,8 +876,6 @@ SAL_CALL osl_mapFile(
         if (nSize > 0)
         {
             c ^= pData[0];
-            pData += nSize;
-            nSize -= nSize;
         }
     }
     return osl_File_E_None;


More information about the Libreoffice-commits mailing list