[Libreoffice-commits] .: 5 commits - bin/lo-commit-stat i18npool/source sw/qa tail_build/README
Korrawit Pruegsanusak
korrawit at kemper.freedesktop.org
Thu May 31 10:25:15 PDT 2012
bin/lo-commit-stat | 23 +++++++++++++----------
i18npool/source/breakiterator/data/README | 6 +++---
sw/qa/extras/README | 2 +-
tail_build/README | 2 +-
4 files changed, 18 insertions(+), 15 deletions(-)
New commits:
commit 07202af3c52c72fad974349c3b2046b0ee2ec162
Author: Korrawit Pruegsanusak <detective.conan.1412 at gmail.com>
Date: Fri Jun 1 00:24:24 2012 +0700
fix some typo
Change-Id: Ib88169968d164c88703505da022887ea8d53c721
diff --git a/i18npool/source/breakiterator/data/README b/i18npool/source/breakiterator/data/README
index 8d7598d..585ba16 100644
--- a/i18npool/source/breakiterator/data/README
+++ b/i18npool/source/breakiterator/data/README
@@ -2,11 +2,11 @@ The originals of these come from svn checkout
http://source.icu-project.org/repos/icu/icu/trunk/source/data/brkitr they no
longer appear in the icu tarballs, but are in icu's svn
-At various stages these copies have been customized and are not horribly out of
+At various stages these copies have been customized and are now horribly out of
sync. It unclear which diffs from the base versions are deliberate and which
are now accidental :-(
We need to review the various issues referenced in the commits that caused
-custimizations and see if they're still relevant or not, write regression tests
-for them, if any are still relavant then apply the changes back on top of the
+customizations and see if they're still relevant or not, write regression tests
+for them, if any are still relevant then apply the changes back on top of the
latest versions.
diff --git a/sw/qa/extras/README b/sw/qa/extras/README
index 49dc9aa..ae174a5 100644
--- a/sw/qa/extras/README
+++ b/sw/qa/extras/README
@@ -123,7 +123,7 @@ similarly to the property you want (getXYZ()). If there is none, it is most
probably a property that can be read using XPropertySet:
uno::Reference<beans::XPropertySet> properties(textDocument, uno::UNO_QUERY);
-sal_Int32 value; // the right type for the property
+sal_Int32 val; // the right type for the property
properties->getPropertyValue("CharacterCount") >>= val;
If there is a function to obtain the property, you need access it using the right interface.
diff --git a/tail_build/README b/tail_build/README
index 6648f76..4ce9228 100644
--- a/tail_build/README
+++ b/tail_build/README
@@ -5,7 +5,7 @@ A few module that normally get built at the end of the build process
are already converted. this 'pseudo-module' build them all as one.
As module get converted to gbuild they can be added to this module
-if they fix the neceesary pre-requisite. that is:
+if they fix the necessary pre-requisite. that is:
To qualify a module must not be the dependant of any other module,
except postprocess or if the other module itself is under tail_build
commit efecdeceb8f58563623a105f464cce72a09768a9
Author: Korrawit Pruegsanusak <detective.conan.1412 at gmail.com>
Date: Fri Jun 1 00:24:22 2012 +0700
lo-commit-stat: better formatting for bug fix commits
* some used "resolved" instead of "resolves"
* some didn't have a colon after that
* some inserted a space after bug ID and a separator
* some used a "-" as a separator
Change-Id: Iee6a0f0346a257124e9488fc8f3bbdc59b32cbac
diff --git a/bin/lo-commit-stat b/bin/lo-commit-stat
index 1b49525..0697432 100755
--- a/bin/lo-commit-stat
+++ b/bin/lo-commit-stat
@@ -42,9 +42,9 @@ sub search_bugs($$$$)
# print " found $bug\n";
# remove bug number from the comment; it will be added later a standardized way
$bug_orig =~ s/\#/\\#/;
- $line =~ s/[Rr]esolves:\s*$bug_orig\s*//;
+ $line =~ s/[Rr]esolve[ds]:?\s*$bug_orig\s*//;
$line =~ s/\s*-\s*$bug_orig\s*//;
- $line =~ s/\(?$bug_orig\)?[:,]?\s*//;
+ $line =~ s/\(?$bug_orig\)?\s*[:,-]?\s*//;
# bnc# is preferred over n# for novell bugs
$bug =~ s/^n\#/bnc#/;
commit 9feed9c7a51d4dbba269971d165746bd36bb4a67
Author: Korrawit Pruegsanusak <detective.conan.1412 at gmail.com>
Date: Fri Jun 1 00:24:20 2012 +0700
lo-commit-stat: we don't have 'bootstrap' repo anymore
Change-Id: I2c5a73f992f204bccf8f1d125334d2746a1884fa
diff --git a/bin/lo-commit-stat b/bin/lo-commit-stat
index 885d053..1b49525 100755
--- a/bin/lo-commit-stat
+++ b/bin/lo-commit-stat
@@ -387,7 +387,7 @@ sub usage()
" --bug-numbers print just fixed bug numbers\n" .
" --rev-list use \"git rev-list\" instead of \"git log\"; useful to check\n" .
" differences between branches\n" .
- " topdir directory with the libreoffice/bootstrap clone; the piece repos\n" .
+ " topdir directory with the libreoffice/core clone; the piece repos\n" .
" must be cloned in the main-repo-root/clone/<piece> subdirectories\n" .
" git_arg extra parameters passed to the git command to define\n" .
" the area of interest; The default command is \"git log\" and\n" .
@@ -422,7 +422,7 @@ foreach my $arg (@ARGV) {
usage();
exit;
} elsif ($arg eq '--no-pieces') {
- $piece = "bootstrap";
+ $piece = "core";
} elsif ($arg =~ m/--piece=(.*)/) {
$piece = $1;
} elsif ($arg =~ m/--log-suffix=(.*)/) {
commit f439d765a4d6c68e2a3ee524255161cd6b65355e
Author: Korrawit Pruegsanusak <detective.conan.1412 at gmail.com>
Date: Fri Jun 1 00:24:18 2012 +0700
lo-commit-stat: lowercase first char if the word contains only lowercase chars
For Example:
* ScConditionalFormat -> no change
* SVG -> no change
* WaE -> no change
* Some -> some
After this change, we now have to sort case-insensitively,
or the lines starting with uppercase will clog up together.
Change-Id: If08cbaa19e6f3496dd1f07920464d16140e2aa3a
diff --git a/bin/lo-commit-stat b/bin/lo-commit-stat
index f1677b2..885d053 100755
--- a/bin/lo-commit-stat
+++ b/bin/lo-commit-stat
@@ -63,10 +63,12 @@ sub standardize_summary($)
$line =~ s/^\s*//;
$line =~ s/\s*$//;
- # lower first letter
- $line =~ m/(^.)/;
- my $first_char = lc($1);
- $line =~ s/^./$first_char/;
+ # lower first letter if the word contains only lowercase letter
+ if ( $line =~ m/(^.[a-z]+\b)/ ) {
+ $line =~ m/(^.)/;
+ my $first_char = lc($1);
+ $line =~ s/^./$first_char/;
+ }
# FIXME: remove do at the end of line
# remove bug numbers
@@ -259,7 +261,7 @@ sub print_stat($$)
my $old_summary="";
my %authors = ();
my %bugs = ();
- foreach my $id ( sort { $pdata->{$piece}{$a}{'summary'} cmp $pdata->{$piece}{$b}{'summary'} } keys %{$pdata->{$piece}}) {
+ foreach my $id ( sort { lc $pdata->{$piece}{$a}{'summary'} cmp lc $pdata->{$piece}{$b}{'summary'} } keys %{$pdata->{$piece}}) {
my $summary = $pdata->{$piece}{$id}{'summary'};
if ($summary ne $old_summary) {
print_summary_in_stat($old_summary, \$piece_title, \%bugs, \%authors, " + ", $log);
commit 6858c3eb53717cc312133646e6c621e7ca4956cf
Author: Korrawit Pruegsanusak <detective.conan.1412 at gmail.com>
Date: Fri Jun 1 00:24:16 2012 +0700
lo-commit-stat: bug ID should have >= 4 digits
This is to avoid capturing stack frame numbers as bug ID.
http://lists.freedesktop.org/archives/libreoffice/2012-February/027133.html
Change-Id: I14169d3a7db73a5d10df01ad1fd9fb95e4c0bd2f
diff --git a/bin/lo-commit-stat b/bin/lo-commit-stat
index 1572924..f1677b2 100755
--- a/bin/lo-commit-stat
+++ b/bin/lo-commit-stat
@@ -26,7 +26,8 @@ sub search_bugs($$$$)
while (defined $bug) {
# match fdo#123, rhz#123, i#123
- if ( $line =~ m/(\w*\#+\d+)/ ) {
+ # but match only bug number with >= 4 digits
+ if ( $line =~ m/(\w*\#+\d{4,})/ ) {
$bug_orig = $1;
$bug = $1;
# match #i123#
More information about the Libreoffice-commits
mailing list