[Libreoffice-commits] .: editeng/inc editeng/source

[Libreoffice Gerrit user]

 editeng/inc/editeng/hangulhanja.hxx |    8 ++++----
 editeng/source/misc/hangulhanja.cxx |   27 ---------------------------
 2 files changed, 4 insertions(+), 31 deletions(-)

New commits:
commit b4410c49063a5ba1c005929ffa8fb06b41cfef91
Author: Matteo Casalin <matteo.casalin at gmx.com>
Date:   Sun Nov 4 23:29:58 2012 +0100

    Make HangulHanjaConversion an abstract class
    
    Change-Id: Ie39801fc14a66af8b338188c74af9f6e52031e60
    Reviewed-on: https://gerrit.libreoffice.org/987
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/editeng/inc/editeng/hangulhanja.hxx b/editeng/inc/editeng/hangulhanja.hxx
index bbdbe59..614ad6c 100644
--- a/editeng/inc/editeng/hangulhanja.hxx
+++ b/editeng/inc/editeng/hangulhanja.hxx
@@ -158,7 +158,7 @@ namespace editeng
         virtual void    GetNextPortion(
                 ::rtl::OUString& /* [out] */ _rNextPortion,
                 LanguageType& /* [out] */ _rLangOfPortion,
-                sal_Bool /* [in] */ _bAllowImplicitChangesForNotConvertibleText );
+                sal_Bool /* [in] */ _bAllowImplicitChangesForNotConvertibleText ) = 0;
 
         /** announces a new "current unit"
 
@@ -188,7 +188,7 @@ namespace editeng
 
             @see GetNextPortion
         */
-        virtual void    HandleNewUnit( const sal_Int32 _nUnitStart, const sal_Int32 _nUnitEnd );
+        virtual void    HandleNewUnit( const sal_Int32 _nUnitStart, const sal_Int32 _nUnitEnd ) = 0;
 
         /** replaces a text unit within a text portion with a new text
 
@@ -254,7 +254,7 @@ namespace editeng
                             const ::com::sun::star::uno::Sequence< sal_Int32 > &_rOffsets,
                             ReplacementAction _eAction,
                             LanguageType *pNewUnitLanguage
-                        );
+                        ) = 0;
 
         /** specifies if rubies are supported by the document implementing
             this class.
@@ -262,7 +262,7 @@ namespace editeng
             @return
                 <TRUE/> if rubies are supported.
         */
-        virtual sal_Bool    HasRubySupport() const;
+        virtual sal_Bool    HasRubySupport() const = 0;
     };
 
     sal_Bool HangulHanjaConversion::IsSimplified( LanguageType nLang )
diff --git a/editeng/source/misc/hangulhanja.cxx b/editeng/source/misc/hangulhanja.cxx
index 9a3c6e3..e42ba1f 100644
--- a/editeng/source/misc/hangulhanja.cxx
+++ b/editeng/source/misc/hangulhanja.cxx
@@ -1027,33 +1027,6 @@ namespace editeng
         return m_pImpl->IsInteractive();
     }
 
-    void HangulHanjaConversion::HandleNewUnit( const sal_Int32, const sal_Int32 )
-    {
-        // nothing to do, only derived classes need this.
-    }
-
-    void HangulHanjaConversion::GetNextPortion( ::rtl::OUString&, LanguageType&, sal_Bool )
-    {
-        OSL_FAIL( "HangulHanjaConversion::GetNextPortion: to be overridden!" );
-    }
-
-    void HangulHanjaConversion::ReplaceUnit(
-            const sal_Int32, const sal_Int32,
-            const ::rtl::OUString&,
-            const ::rtl::OUString&,
-            const ::com::sun::star::uno::Sequence< sal_Int32 > &,
-            ReplacementAction,
-            LanguageType * )
-    {
-        OSL_FAIL( "HangulHanjaConversion::ReplaceUnit: to be overridden!" );
-    }
-
-    sal_Bool HangulHanjaConversion::HasRubySupport() const
-    {
-        OSL_FAIL( "HangulHanjaConversion::HasRubySupport: to be overridden!" );
-        return sal_False;
-    }
-
     void HangulHanjaConversion::ConvertDocument()
     {
         if ( m_pImpl->IsValid() )