[Libreoffice-commits] .: sal/inc sal/qa

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Fri Nov 30 23:46:23 PST 2012


 sal/inc/rtl/ustrbuf.hxx                             |    2 +-
 sal/qa/rtl/strings/test_oustring_stringliterals.cxx |    1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 10cecb81dbd897aaea5188c9249770877ac20771
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Fri Nov 30 20:24:18 2012 -0600

    OUStringBuffer constructor from OUStringBuffer should use const arg
    
    Change-Id: I9f9e072c0a7ebde2de9be811f2378143b2b7abc6
    Reviewed-on: https://gerrit.libreoffice.org/1209
    Reviewed-by: Luboš Luňák <l.lunak at suse.cz>
    Tested-by: Luboš Luňák <l.lunak at suse.cz>

diff --git a/sal/inc/rtl/ustrbuf.hxx b/sal/inc/rtl/ustrbuf.hxx
index d8db905..6338dd1 100644
--- a/sal/inc/rtl/ustrbuf.hxx
+++ b/sal/inc/rtl/ustrbuf.hxx
@@ -409,7 +409,7 @@ public:
 
         @since LibreOffice 4.0
      */
-    OUStringBuffer & append(OUStringBuffer &str)
+    OUStringBuffer & append(const OUStringBuffer &str)
     {
         if(str.getLength() > 0)
         {
diff --git a/sal/qa/rtl/strings/test_oustring_stringliterals.cxx b/sal/qa/rtl/strings/test_oustring_stringliterals.cxx
index e02bd93..09b55c6 100644
--- a/sal/qa/rtl/strings/test_oustring_stringliterals.cxx
+++ b/sal/qa/rtl/strings/test_oustring_stringliterals.cxx
@@ -181,7 +181,6 @@ void test::oustring::StringLiterals::checkBuffer()
     buf.insert( 3, "baz" );
     CPPUNIT_ASSERT_EQUAL( rtl::OUString( "foobazbar" ), buf.toString());
     char d[] = "d";
-    CPPUNIT_ASSERT( !VALID_CONVERSION( buf.append( d )));
     CPPUNIT_ASSERT( !VALID_CONVERSION( buf.insert( 0, d )));
 }
 


More information about the Libreoffice-commits mailing list