[Libreoffice-commits] .: Branch 'feature/android-single-dso' - 6 commits - android/experimental configure.in cppuhelper/source cui/source sd/source sw/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Mon Oct 8 23:37:58 PDT 2012


 android/experimental/DocumentLoader/Makefile |    5 +++++
 configure.in                                 |    2 +-
 cppuhelper/source/shlib.cxx                  |    4 ----
 cui/source/factory/dlgfact.cxx               |   14 +++++++-------
 cui/source/factory/dlgfact.hxx               |    4 ++--
 sd/source/ui/dlg/sddlgfact.cxx               |   10 +++++-----
 sd/source/ui/dlg/sddlgfact.hxx               |    4 ++--
 sw/source/ui/dialog/swdialmgr.cxx            |    6 ++++--
 sw/source/ui/dialog/swdlgfact.cxx            |   16 ++++++++--------
 sw/source/ui/dialog/swdlgfact.hxx            |    4 ++--
 sw/source/ui/frmdlg/frmpage.cxx              |   12 ++++++------
 11 files changed, 42 insertions(+), 39 deletions(-)

New commits:
commit 9c8f84c160576e207764036079a98a949242f1ff
Author: Tor Lillqvist <tml at iki.fi>
Date:   Tue Oct 9 09:28:46 2012 +0300

    More libs
    
    Change-Id: I7921ac41a31f545a74ec2981dda9c30f40d4b4d9

diff --git a/android/experimental/DocumentLoader/Makefile b/android/experimental/DocumentLoader/Makefile
index 2e65f1d..3c1ebbd 100644
--- a/android/experimental/DocumentLoader/Makefile
+++ b/android/experimental/DocumentLoader/Makefile
@@ -29,6 +29,7 @@ LIBS = \
 	acclo \
 	ascii_expat_xmlparse \
 	avmedialo \
+	basctllo \
 	basebmp \
 	basegfxlo \
 	bootstrap.uno \
@@ -39,6 +40,7 @@ LIBS = \
 	configmgr.uno \
 	cppcanvaslo \
 	crypto \
+	cuilo \
 	dbalo \
 	dbaxmllo \
 	dbtoolslo \
@@ -51,6 +53,7 @@ LIBS = \
 	egilo \
 	emelo \
 	epblo \
+	epglo \
 	epplo \
 	epslo \
 	eptlo \
@@ -145,6 +148,7 @@ LIBS = \
 	spllo \
 	stocservices.uno \
 	store \
+	sunjavaplugin \
 	svgfilterlo \
 	svllo \
 	svtlo \
@@ -152,6 +156,7 @@ LIBS = \
 	svxlo \
 	swdlo \
 	swlo \
+	swuilo \
 	t602filterlo \
 	textconv_dict \
 	textconversiondlgslo \
commit e0805024d8e9ebc2467bcc6e263140264e8b77ad
Author: Tor Lillqvist <tml at iki.fi>
Date:   Tue Oct 9 09:28:09 2012 +0300

    De-duplicate aEmptyStr and pSwResMgr
    
    Change-Id: I129754d1180ea15d815b2b4d2533f911f10116c3

diff --git a/sw/source/ui/dialog/swdialmgr.cxx b/sw/source/ui/dialog/swdialmgr.cxx
index d8fb185..364416d 100644
--- a/sw/source/ui/dialog/swdialmgr.cxx
+++ b/sw/source/ui/dialog/swdialmgr.cxx
@@ -30,13 +30,15 @@
 #include "tools/string.hxx"
 #include <sfx2/app.hxx>
 
+#ifndef DISABLE_DYNLOADING
 //copy from core\bastyp\swtypes.cxx
 String aEmptyStr; // constant strings
-
-ResMgr* pSwResMgr=0;
+#endif
 
 ResMgr* SwDialogsResMgr::GetResMgr()
 {
+    static ResMgr* pSwResMgr=0;
+
     if ( !pSwResMgr )
     {
         pSwResMgr = SfxApplication::CreateResManager( "sw" );
commit 9a1f34b1dc6316893ca1154d4745b200e5522f4f
Author: Tor Lillqvist <tml at iki.fi>
Date:   Tue Oct 9 09:27:32 2012 +0300

    Make lcl functions static
    
    Change-Id: Ia8439fda69324a48660e6b6c5b954c6d3eb14bc9

diff --git a/sw/source/ui/frmdlg/frmpage.cxx b/sw/source/ui/frmdlg/frmpage.cxx
index b05b030..2a0ee4e 100644
--- a/sw/source/ui/frmdlg/frmpage.cxx
+++ b/sw/source/ui/frmdlg/frmpage.cxx
@@ -394,7 +394,7 @@ static sal_uInt16 aAddPgRg[] = {
     0
 };
 
-size_t lcl_GetFrmMapCount( const FrmMap* pMap)
+static size_t lcl_GetFrmMapCount( const FrmMap* pMap)
 {
     if ( pMap )
     {
@@ -567,7 +567,7 @@ SvxSwFramePosString::StringId lcl_ChangeResIdToVerticalOrRTL(SvxSwFramePosString
 
 // helper method in order to determine all possible
 // listbox relations in a relation map for a given relation
-sal_uLong lcl_GetLBRelationsForRelations( const sal_uInt16 _nRel )
+static sal_uLong lcl_GetLBRelationsForRelations( const sal_uInt16 _nRel )
 {
     sal_uLong nLBRelations = 0L;
 
@@ -585,9 +585,9 @@ sal_uLong lcl_GetLBRelationsForRelations( const sal_uInt16 _nRel )
 
 // helper method on order to determine all possible
 // listbox relations in a relation map for a given string ID
-sal_uLong lcl_GetLBRelationsForStrID( const FrmMap* _pMap,
-                                  const SvxSwFramePosString::StringId _eStrId,
-                                  const bool _bUseMirrorStr )
+static sal_uLong lcl_GetLBRelationsForStrID( const FrmMap* _pMap,
+                                             const SvxSwFramePosString::StringId _eStrId,
+                                             const bool _bUseMirrorStr )
 {
     sal_uLong nLBRelations = 0L;
 
@@ -2736,7 +2736,7 @@ IMPL_LINK_NOARG(SwFrmURLPage, InsertFileHdl)
     return 0;
 }
 
-void lcl_Move(Window& rWin, sal_Int32 nDiff)
+static void lcl_Move(Window& rWin, sal_Int32 nDiff)
 {
     Point aPos(rWin.GetPosPixel());
     aPos.Y() -= nDiff;
commit 203a9b863bd1165c0abb2a90d4b5cd91cd6e4e22
Author: Tor Lillqvist <tml at iki.fi>
Date:   Tue Oct 9 09:25:16 2012 +0300

    De-duplicate AbstractSfxDialog_Impl
    
    Change-Id: Iddf2222aa75b21dd60472fa8dc979ddbdc18dcba

diff --git a/cui/source/factory/dlgfact.cxx b/cui/source/factory/dlgfact.cxx
index 0af0745..b0afe0e 100644
--- a/cui/source/factory/dlgfact.cxx
+++ b/cui/source/factory/dlgfact.cxx
@@ -109,7 +109,7 @@ using ::com::sun::star::uno::Reference;
 
 using namespace svx;
 // AbstractTabDialog implementations just forwards everything to the dialog
-IMPL_ABSTDLG_BASE(AbstractSfxDialog_Impl)
+IMPL_ABSTDLG_BASE(CuiAbstractSfxDialog_Impl)
 IMPL_ABSTDLG_BASE(CuiVclAbstractDialog_Impl)
 IMPL_ABSTDLG_BASE(VclAbstractRefreshableDialog_Impl);
 IMPL_ABSTDLG_BASE(CuiAbstractTabDialog_Impl);
@@ -230,17 +230,17 @@ String CuiAbstractTabDialog_Impl::GetText() const
 }
 
 
-const SfxItemSet* AbstractSfxDialog_Impl::GetOutputItemSet() const
+const SfxItemSet* CuiAbstractSfxDialog_Impl::GetOutputItemSet() const
 {
     return pDlg->GetOutputItemSet();
 }
 
-void AbstractSfxDialog_Impl::SetText( const XubString& rStr )
+void CuiAbstractSfxDialog_Impl::SetText( const XubString& rStr )
 {
     pDlg->SetText( rStr );
 }
 
-String AbstractSfxDialog_Impl::GetText() const
+String CuiAbstractSfxDialog_Impl::GetText() const
 {
     return pDlg->GetText();
 }
@@ -1318,7 +1318,7 @@ SfxAbstractDialog* AbstractDialogFactory_Impl::CreateSfxDialog( sal_uInt32 nResI
     }
 
     if ( pDlg )
-        return new AbstractSfxDialog_Impl( pDlg );
+        return new CuiAbstractSfxDialog_Impl( pDlg );
     return 0;
 }
 
@@ -1648,7 +1648,7 @@ SfxAbstractDialog* AbstractDialogFactory_Impl::CreateSfxDialog( Window* pParent,
     }
 
     if ( pDlg )
-        return new AbstractSfxDialog_Impl( pDlg );
+        return new CuiAbstractSfxDialog_Impl( pDlg );
     return 0;
 }
 
@@ -1675,7 +1675,7 @@ SfxAbstractDialog* AbstractDialogFactory_Impl::CreateSfxDialog( Window* pParent,
     }
 
     if ( pDlg )
-        return new AbstractSfxDialog_Impl( pDlg );
+        return new CuiAbstractSfxDialog_Impl( pDlg );
     return 0;
 }
 
diff --git a/cui/source/factory/dlgfact.hxx b/cui/source/factory/dlgfact.hxx
index 232e0d1..c91d8fe 100644
--- a/cui/source/factory/dlgfact.hxx
+++ b/cui/source/factory/dlgfact.hxx
@@ -118,9 +118,9 @@ class VclAbstractRefreshableDialog_Impl : public VclAbstractRefreshableDialog
 };
 //for ActualizeProgress end
 
-class AbstractSfxDialog_Impl : public SfxAbstractDialog
+class CuiAbstractSfxDialog_Impl : public SfxAbstractDialog
 {
-    DECL_ABSTDLG_BASE(AbstractSfxDialog_Impl,SfxModalDialog)
+    DECL_ABSTDLG_BASE(CuiAbstractSfxDialog_Impl,SfxModalDialog)
     virtual const SfxItemSet*   GetOutputItemSet() const;
 
         //From class Window.
diff --git a/sd/source/ui/dlg/sddlgfact.cxx b/sd/source/ui/dlg/sddlgfact.cxx
index dbff1fc..44c0c81 100644
--- a/sd/source/ui/dlg/sddlgfact.cxx
+++ b/sd/source/ui/dlg/sddlgfact.cxx
@@ -75,7 +75,7 @@ IMPL_ABSTDLG_BASE(AbstractSdInsertPagesObjsDlg_Impl);
 IMPL_ABSTDLG_BASE(AbstractMorphDlg_Impl);
 IMPL_ABSTDLG_BASE(AbstractSdStartPresDlg_Impl);
 IMPL_ABSTDLG_BASE(AbstractSdPresLayoutDlg_Impl);
-IMPL_ABSTDLG_BASE(AbstractSfxDialog_Impl);
+IMPL_ABSTDLG_BASE(SdAbstractSfxDialog_Impl);
 IMPL_ABSTDLG_BASE(AbstractSdVectorizeDlg_Impl);
 IMPL_ABSTDLG_BASE(AbstractSdPublishingDlg_Impl);
 IMPL_ABSTDLG_BASE(AbstractHeaderFooterDialog_Impl);
@@ -332,15 +332,15 @@ void AbstractSdPresLayoutDlg_Impl::GetAttr( SfxItemSet& rOutAttrs )
 // AbstractSdPresLayoutDlg_Impl end
 
 //SfxAbstractDialog_Impl begin
-const SfxItemSet* AbstractSfxDialog_Impl::GetOutputItemSet() const
+const SfxItemSet* SdAbstractSfxDialog_Impl::GetOutputItemSet() const
 {
     return pDlg->GetOutputItemSet();
 }
-void AbstractSfxDialog_Impl::SetText( const XubString& rStr )
+void SdAbstractSfxDialog_Impl::SetText( const XubString& rStr )
 {
     pDlg->SetText( rStr );
 }
-String AbstractSfxDialog_Impl::GetText() const
+String SdAbstractSfxDialog_Impl::GetText() const
 {
     return pDlg->GetText();
 }
@@ -520,7 +520,7 @@ SfxAbstractTabDialog *  SdAbstractDialogFactory_Impl::CreateSdTabTemplateDlg( ::
 
 SfxAbstractDialog* SdAbstractDialogFactory_Impl::CreatSdActionDialog( ::Window* pParent, const SfxItemSet* pAttr, ::sd::View* pView )
 {
-    return new AbstractSfxDialog_Impl( new SdActionDlg( pParent, pAttr, pView ) );
+    return new SdAbstractSfxDialog_Impl( new SdActionDlg( pParent, pAttr, pView ) );
 }
 
 // add for SdVectorizeDlg begin
diff --git a/sd/source/ui/dlg/sddlgfact.hxx b/sd/source/ui/dlg/sddlgfact.hxx
index 6970d71..e29d2d2 100644
--- a/sd/source/ui/dlg/sddlgfact.hxx
+++ b/sd/source/ui/dlg/sddlgfact.hxx
@@ -218,9 +218,9 @@ class AbstractSdPresLayoutDlg_Impl : public AbstractSdPresLayoutDlg
 };
 
 // add for SdActionDlg
-class AbstractSfxDialog_Impl : public SfxAbstractDialog
+class SdAbstractSfxDialog_Impl : public SfxAbstractDialog
 {
-    DECL_ABSTDLG_BASE(AbstractSfxDialog_Impl,SfxModalDialog)
+    DECL_ABSTDLG_BASE(SdAbstractSfxDialog_Impl,SfxModalDialog)
     virtual const SfxItemSet*   GetOutputItemSet() const;
     virtual void        SetText( const XubString& rStr );
     virtual String      GetText() const;
diff --git a/sw/source/ui/dialog/swdlgfact.cxx b/sw/source/ui/dialog/swdlgfact.cxx
index 868b487..6763551 100644
--- a/sw/source/ui/dialog/swdlgfact.cxx
+++ b/sw/source/ui/dialog/swdlgfact.cxx
@@ -107,7 +107,7 @@ using namespace ::com::sun::star;
 
 IMPL_ABSTDLG_BASE(AbstractSwWordCountFloatDlg_Impl);
 IMPL_ABSTDLG_BASE(AbstractSwInsertAbstractDlg_Impl);
-IMPL_ABSTDLG_BASE(AbstractSfxDialog_Impl);
+IMPL_ABSTDLG_BASE(SwAbstractSfxDialog_Impl);
 IMPL_ABSTDLG_BASE(AbstractSwAsciiFilterDlg_Impl);
 IMPL_ABSTDLG_BASE(VclAbstractDialog_Impl);
 IMPL_ABSTDLG_BASE(AbstractSplitTableDialog_Impl);
@@ -178,17 +178,17 @@ sal_uInt8 AbstractSwInsertAbstractDlg_Impl::GetPara() const
 }
 
 //add for SwAddrDlg, SwDropCapsDlg ,SwBackgroundDlg, SwNumFmtDlg SwBorderDlg SwWrapDlg  SwFldEditDlg begin
-const SfxItemSet* AbstractSfxDialog_Impl::GetOutputItemSet() const
+const SfxItemSet* SwAbstractSfxDialog_Impl::GetOutputItemSet() const
 {
     return pDlg->GetOutputItemSet();
 }
 
-void AbstractSfxDialog_Impl::SetText( const XubString& rStr )
+void SwAbstractSfxDialog_Impl::SetText( const XubString& rStr )
 {
     pDlg->SetText( rStr );
 }
 
-String AbstractSfxDialog_Impl::GetText() const
+String SwAbstractSfxDialog_Impl::GetText() const
 {
     return pDlg->GetText();
 }
@@ -667,7 +667,7 @@ SfxAbstractDialog* SwAbstractDialogFactory_Impl::CreateSfxDialog( Window* pParen
     }
 
     if ( pDlg )
-        return new AbstractSfxDialog_Impl( pDlg );
+        return new SwAbstractSfxDialog_Impl( pDlg );
     return 0;
 }
 
@@ -1019,7 +1019,7 @@ SfxAbstractDialog * SwAbstractDialogFactory_Impl::CreateSwBorderDlg (Window* pPa
     }
 
     if ( pDlg )
-        return new AbstractSfxDialog_Impl( pDlg );
+        return new SwAbstractSfxDialog_Impl( pDlg );
     return 0;
 }
 
@@ -1036,7 +1036,7 @@ SfxAbstractDialog* SwAbstractDialogFactory_Impl::CreateSwWrapDlg ( Window* pPare
     }
 
     if ( pDlg )
-        return new AbstractSfxDialog_Impl( pDlg );
+        return new SwAbstractSfxDialog_Impl( pDlg );
     return 0;
 }
 
@@ -1108,7 +1108,7 @@ SfxAbstractDialog*   SwAbstractDialogFactory_Impl::CreateSwFldEditDlg ( SwView&
     }
 
     if ( pDlg )
-        return new AbstractSfxDialog_Impl( pDlg );
+        return new SwAbstractSfxDialog_Impl( pDlg );
     return 0;
 }
 
diff --git a/sw/source/ui/dialog/swdlgfact.hxx b/sw/source/ui/dialog/swdlgfact.hxx
index 159f6e3..9d0ffc6 100644
--- a/sw/source/ui/dialog/swdlgfact.hxx
+++ b/sw/source/ui/dialog/swdlgfact.hxx
@@ -95,9 +95,9 @@ class AbstractSwInsertAbstractDlg_Impl : public AbstractSwInsertAbstractDlg
 
 // add for SwAddrDlg, SwDropCapsDlg, SwBackgroundDlg SwNumFmtDlg  SwWrapDlg SwBorderDlg, SwFldEditDlg  begin
 class SfxSingleTabDialog;
-class AbstractSfxDialog_Impl :public SfxAbstractDialog
+class SwAbstractSfxDialog_Impl :public SfxAbstractDialog
 {
-    DECL_ABSTDLG_BASE(AbstractSfxDialog_Impl,SfxModalDialog)
+    DECL_ABSTDLG_BASE(SwAbstractSfxDialog_Impl,SfxModalDialog)
     virtual const SfxItemSet*   GetOutputItemSet() const;
     virtual void        SetText( const XubString& rStr );
     virtual String      GetText() const;
commit 53291aaf7ceb24916a8bc81065c91214c129cad6
Author: Tor Lillqvist <tml at iki.fi>
Date:   Tue Oct 9 09:23:52 2012 +0300

    I want to see what unknown library is required always
    
    Change-Id: I7e0eb7ba3be8ac2b70e6a56d84c1a890be0ba396

diff --git a/cppuhelper/source/shlib.cxx b/cppuhelper/source/shlib.cxx
index 6da2759..9bbdb8c 100644
--- a/cppuhelper/source/shlib.cxx
+++ b/cppuhelper/source/shlib.cxx
@@ -41,9 +41,7 @@
 
 #include "com/sun/star/beans/XPropertySet.hpp"
 
-#if OSL_DEBUG_LEVEL > 1
 #include <stdio.h>
-#endif
 #include <vector>
 
 #ifdef ANDROID
@@ -581,9 +579,7 @@ Reference< XInterface > SAL_CALL loadSharedLibComponentFactory(
         }
         if ( pSym == NULL )
         {
-#if OSL_DEBUG_LEVEL > 1
             fprintf( stderr, "attempting to load unknown library %s\n", OUStringToOString( rLibName, RTL_TEXTENCODING_ASCII_US ).getStr() );
-#endif
             assert( !"Attempt to load unknown library" );
         }
     }
commit 47849404685bf140a5fecc355be66590c8833202
Author: Tor Lillqvist <tml at iki.fi>
Date:   Tue Oct 9 09:03:04 2012 +0300

    Do generate Thumb code, I think the current NDK (r8b) handles it fine
    
    Change-Id: If331d969f419d72076faff661bd0fbeb52bd24c4

diff --git a/configure.in b/configure.in
index 4335a6e..e58db23 100644
--- a/configure.in
+++ b/configure.in
@@ -180,7 +180,7 @@ if test -n "$with_android_ndk"; then
 
     if test $host_cpu = arm; then
         ANDROID_APP_ABI=armeabi-v7a
-        ANDROIDCFLAGS="-march=armv7-a -mfloat-abi=softfp -mfpu=neon -Wl,--fix-cortex-a8"
+        ANDROIDCFLAGS="-march=armv7-a -mfloat-abi=softfp -mthumb -mfpu=neon -Wl,--fix-cortex-a8"
     elif test $host_cpu = mips; then
         ANDROID_APP_ABI=mips
         ANDROIDCFLAGS=""


More information about the Libreoffice-commits mailing list