[Libreoffice-commits] .: sc/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Thu Sep 13 20:48:39 PDT 2012


 sc/source/core/data/fillinfo.cxx |   13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

New commits:
commit 732f3546c4051d92e544df6462022e7d07765e83
Author: Kohei Yoshida <kohei.yoshida at gmail.com>
Date:   Wed Sep 12 15:35:05 2012 -0400

    Let's just remove this.
    
    Commit 291c919cf98347703e7ad2216b2b79aacd7cdfac made this dangling
    code block.
    
    Change-Id: Id8d09f1c364d621661c9d6584cd863f253c01d95

diff --git a/sc/source/core/data/fillinfo.cxx b/sc/source/core/data/fillinfo.cxx
index 1ee5a51..65b93cb 100644
--- a/sc/source/core/data/fillinfo.cxx
+++ b/sc/source/core/data/fillinfo.cxx
@@ -511,17 +511,8 @@ void ScDocument::FillInfo( ScTableInfo& rTabInfo, SCCOL nX1, SCROW nY1, SCCOL nX
                                 pInfo->pShadowAttr  = pShadowAttr;
                                 //  nWidth wird nicht mehr einzeln gesetzt
 
-                                bool bEmbed = false; //bIsEmbedded &&
-#if 0 // Huh? Is this intentional or accidental? Clang warns
-      // "expression result unused", so ifdef out these lines. The
-      // code has been like this since 2004.
-                                        nTab    >= aEmbedRange.aStart.Tab() &&
-                                        nTab    <= aEmbedRange.aEnd.Tab()   &&
-                                        nX      >= aEmbedRange.aStart.Col() &&
-                                        nX      <= aEmbedRange.aEnd.Col()   &&
-                                        nCurRow >= aEmbedRange.aStart.Row() &&
-                                        nCurRow <= aEmbedRange.aEnd.Row();
-#endif
+                                bool bEmbed = false;
+
                                 if (bScenario)
                                 {
                                     pInfo->pBackground = ScGlobal::GetButtonBrushItem();


More information about the Libreoffice-commits mailing list