[Libreoffice-commits] core.git: drawinglayer/source oox/source

Julien Nabet serval2412 at yahoo.fr
Mon Apr 1 09:15:55 PDT 2013


 drawinglayer/source/processor2d/vclhelperbufferdevice.cxx |    2 +-
 oox/source/drawingml/table/tableproperties.cxx            |   14 ++++++--------
 2 files changed, 7 insertions(+), 9 deletions(-)

New commits:
commit 182059964fb566c16348b6bec0869a19894bfdc7
Author: Julien Nabet <serval2412 at yahoo.fr>
Date:   Mon Apr 1 18:13:16 2013 +0200

    Prefer prefix ++/-- operators for non-primitive types
    
    Change-Id: Ie155215aea1d6f15e51bf5e64bab10eb2198d4de

diff --git a/drawinglayer/source/processor2d/vclhelperbufferdevice.cxx b/drawinglayer/source/processor2d/vclhelperbufferdevice.cxx
index 0832e4d..f87afc62 100644
--- a/drawinglayer/source/processor2d/vclhelperbufferdevice.cxx
+++ b/drawinglayer/source/processor2d/vclhelperbufferdevice.cxx
@@ -89,7 +89,7 @@ namespace
             bool bOkay(false);
             aBuffers::iterator aFound(maFreeBuffers.end());
 
-            for(aBuffers::iterator a(maFreeBuffers.begin()); a != maFreeBuffers.end(); a++)
+            for(aBuffers::iterator a(maFreeBuffers.begin()); a != maFreeBuffers.end(); ++a)
             {
                 OSL_ENSURE(*a, "Empty pointer in VDevBuffer (!)");
 
diff --git a/oox/source/drawingml/table/tableproperties.cxx b/oox/source/drawingml/table/tableproperties.cxx
index e9d7e5e..440a0a5 100644
--- a/oox/source/drawingml/table/tableproperties.cxx
+++ b/oox/source/drawingml/table/tableproperties.cxx
@@ -139,12 +139,14 @@ void TableProperties::pushToPropSet( const ::oox::core::XmlFilterBase& rFilterBa
 
     const TableStyle& rTableStyle( getUsedTableStyle( rFilterBase ) );
     sal_Int32 nRow = 0;
-    std::vector< TableRow >::iterator aTableRowIter( mvTableRows.begin() );
-    while( aTableRowIter != mvTableRows.end() )
+    const std::vector< TableRow >::const_iterator aTableRowEnd( mvTableRows.end() );
+    for (std::vector< TableRow >::iterator aTableRowIter( mvTableRows.begin() );
+         aTableRowIter != aTableRowEnd ; ++aTableRowIter, ++nRow)
     {
         sal_Int32 nColumn = 0;
-        std::vector< TableCell >::iterator aTableCellIter( aTableRowIter->getTableCells().begin() );
-        while( aTableCellIter != aTableRowIter->getTableCells().end() )
+        const std::vector< TableCell >::const_iterator aTableCellEnd( aTableRowIter->getTableCells().end() );
+        for (std::vector< TableCell >::iterator aTableCellIter( aTableRowIter->getTableCells().begin() );
+            aTableCellIter != aTableCellEnd ; ++aTableCellIter, ++nColumn)
         {
             TableCell& rTableCell( *aTableCellIter );
             if ( !rTableCell.getvMerge() && !rTableCell.gethMerge() )
@@ -157,11 +159,7 @@ void TableProperties::pushToPropSet( const ::oox::core::XmlFilterBase& rFilterBa
                 rTableCell.pushToXCell( rFilterBase, pMasterTextListStyle, xCellRange->getCellByPosition( nColumn, nRow ), *this, rTableStyle,
                     nColumn, aTableRowIter->getTableCells().size(), nRow, mvTableRows.size() );
             }
-            nColumn++;
-            aTableCellIter++;
         }
-        nRow++;
-        aTableRowIter++;
     }
 }
 


More information about the Libreoffice-commits mailing list