[Libreoffice-commits] core.git: Branch 'feature/formula-core-rework' - sc/source

Kohei Yoshida kohei.yoshida at gmail.com
Mon Apr 29 14:20:07 PDT 2013


 sc/source/core/data/formulacell.cxx |    6 ++++++
 1 file changed, 6 insertions(+)

New commits:
commit 36dd73bbe0b098ddb677724eec799f4e9fb47dc8
Author: Kohei Yoshida <kohei.yoshida at gmail.com>
Date:   Mon Apr 29 17:22:31 2013 -0400

    Some comment.
    
    Change-Id: Ie7015231944547254562031864e7691333f02947

diff --git a/sc/source/core/data/formulacell.cxx b/sc/source/core/data/formulacell.cxx
index 236474d..5753e44 100644
--- a/sc/source/core/data/formulacell.cxx
+++ b/sc/source/core/data/formulacell.cxx
@@ -2993,6 +2993,12 @@ bool ScFormulaCell::InterpretFormulaGroup()
                     // Fetch double array guarantees that the length of the
                     // returned array equals or greater than the requested
                     // length.
+
+                    // TODO: For now, it returns an array pointer only when
+                    // the entire array is in contiguous memory space.  Once
+                    // we finish cell storage rework, we'll support temporary
+                    // generation of a double array which is a combination of
+                    // multiple cell array segments.
                     const double* pArray = pDocument->FetchDoubleArray(aCxt, aRefPos, xGroup->mnLength);
                     if (!pArray)
                         return false;


More information about the Libreoffice-commits mailing list