[Libreoffice-commits] core.git: svx/source

Ivan Timofeev timofeev.i.s at gmail.com
Thu Aug 8 07:58:50 PDT 2013


 svx/source/svdraw/svdotext.cxx |    2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 2a0dd33a384009dcc92238cec344c9b0e98cf25f
Author: Ivan Timofeev <timofeev.i.s at gmail.com>
Date:   Thu Aug 8 18:44:57 2013 +0400

    fdo#67871: Revert "coverity#705731 Resource leak"
    
    ... and delete pContourPolyPolygon instead. Otherwise there is a null pointer
    dereference.
    
    This reverts commit e3258713793f03d6cf96c19ff4c5d15a0cd666f1.
    
    Change-Id: Id9d8c514c786b42233a35a9ade55d0c05986fb08

diff --git a/svx/source/svdraw/svdotext.cxx b/svx/source/svdraw/svdotext.cxx
index 4a5a646..64cdc5b 100644
--- a/svx/source/svdraw/svdotext.cxx
+++ b/svx/source/svdraw/svdotext.cxx
@@ -601,6 +601,7 @@ void SdrTextObj::ImpSetContourPolygon( SdrOutliner& rOutliner, Rectangle& rAncho
     {
         // Take line width into account.
         // When doing the hit test, avoid this. (Performance!)
+        pContourPolyPolygon = new basegfx::B2DPolyPolygon();
 
         // test if shadow needs to be avoided for TakeContour()
         const SfxItemSet& rSet = GetObjectItemSet();
@@ -636,6 +637,7 @@ void SdrTextObj::ImpSetContourPolygon( SdrOutliner& rOutliner, Rectangle& rAncho
     }
 
     rOutliner.SetPolygon(aXorPolyPolygon, pContourPolyPolygon);
+    delete pContourPolyPolygon;
 }
 
 void SdrTextObj::TakeUnrotatedSnapRect(Rectangle& rRect) const


More information about the Libreoffice-commits mailing list