[Libreoffice-commits] core.git: 2 commits - editeng/source

Tor Lillqvist tml at iki.fi
Tue Aug 13 01:07:02 PDT 2013


 editeng/source/editeng/impedit2.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c625772a6fed6f67d62c140de06798f6ecb4a9a8
Author: Tor Lillqvist <tml at iki.fi>
Date:   Tue Aug 13 10:50:54 2013 +0300

    Avoid warning: rtl_uString_newFromLiteral - Found char > 127
    
    Using a literal string that includes non-ASCII character(s) to initialise an
    OUString causes a warning "sal/rtl/strtmpl.cxx:1338:
    rtl_uString_newFromLiteral - Found char > 127".
    
    I doubt the '\xFF' in the aWordDelimiters initialiser makes sense. The
    initialiser contained "\0xFF" since the beginning of time, which (as said in
    e7a958441a19a4e14bf12aac09fa566de0f263ee) means a zero byte '\0' followed by
    "xFF".
    
    So '\xFF' was not included in the initialiser during all that time
    either. Whatever the '\xFF' means in the set of "word delimiters", quite
    possibly it is handled explicitly in the code anyway (grep for
    CH_FEATURE_OLD).
    
    Change-Id: I2998a13e6e573f85c92e66ff6edbb6354ba11b5b

diff --git a/editeng/source/editeng/impedit2.cxx b/editeng/source/editeng/impedit2.cxx
index 4c1a72a..dc71b16 100644
--- a/editeng/source/editeng/impedit2.cxx
+++ b/editeng/source/editeng/impedit2.cxx
@@ -83,7 +83,7 @@ ImpEditEngine::ImpEditEngine( EditEngine* pEE, SfxItemPool* pItemPool ) :
     aMinAutoPaperSize( 0x0, 0x0 ),
     aMaxAutoPaperSize( 0x7FFFFFFF, 0x7FFFFFFF ),
     aEditDoc( pItemPool ),
-    aWordDelimiters(" .,;:-'`'?!_=\"{}()[]\xFF"),
+    aWordDelimiters(" .,;:-'`'?!_=\"{}()[]"),
     bKernAsianPunctuation(false),
     bAddExtLeading(false),
     bIsFormatting(false),
commit 3440201b75bddd88d02127983995ac4db823bc98
Author: Tor Lillqvist <tml at iki.fi>
Date:   Tue Aug 13 10:49:39 2013 +0300

    Remove duplicated space in aWordDelimiters initialiser
    
    Change-Id: Idf191ab3dfa7f6fde190c55d4d1d228a49ecf771

diff --git a/editeng/source/editeng/impedit2.cxx b/editeng/source/editeng/impedit2.cxx
index 89c0908..4c1a72a 100644
--- a/editeng/source/editeng/impedit2.cxx
+++ b/editeng/source/editeng/impedit2.cxx
@@ -83,7 +83,7 @@ ImpEditEngine::ImpEditEngine( EditEngine* pEE, SfxItemPool* pItemPool ) :
     aMinAutoPaperSize( 0x0, 0x0 ),
     aMaxAutoPaperSize( 0x7FFFFFFF, 0x7FFFFFFF ),
     aEditDoc( pItemPool ),
-    aWordDelimiters("  .,;:-'`'?!_=\"{}()[]\xFF"),
+    aWordDelimiters(" .,;:-'`'?!_=\"{}()[]\xFF"),
     bKernAsianPunctuation(false),
     bAddExtLeading(false),
     bIsFormatting(false),


More information about the Libreoffice-commits mailing list