[Libreoffice-commits] core.git: chart2/source

Julien Nabet serval2412 at yahoo.fr
Wed Aug 14 15:13:16 PDT 2013


 chart2/source/controller/itemsetwrapper/GraphicPropertyItemConverter.cxx |   12 +++-------
 1 file changed, 4 insertions(+), 8 deletions(-)

New commits:
commit 226f212668550a6ca8a128a21fa70cbcdafcb4b2
Author: Julien Nabet <serval2412 at yahoo.fr>
Date:   Thu Aug 15 00:12:45 2013 +0200

    cppcheck: fix redundant assignments
    
    Change-Id: Ia4c81fefc914aaaead6f8e47ae2818e139357bb4

diff --git a/chart2/source/controller/itemsetwrapper/GraphicPropertyItemConverter.cxx b/chart2/source/controller/itemsetwrapper/GraphicPropertyItemConverter.cxx
index 620bbda..460d3db 100644
--- a/chart2/source/controller/itemsetwrapper/GraphicPropertyItemConverter.cxx
+++ b/chart2/source/controller/itemsetwrapper/GraphicPropertyItemConverter.cxx
@@ -327,8 +327,7 @@ void GraphicPropertyItemConverter::FillSpecialItem(
 
                 // translate model name to UI-name for predefined entries, so
                 // that the correct entry is chosen in the list of UI-names
-                XLineDashItem * pItemToPut = & aItem;
-                pItemToPut = aItem.checkForUniqueItem( & m_rDrawModel );
+                XLineDashItem * pItemToPut = aItem.checkForUniqueItem( & m_rDrawModel );
 
                 rOutItemSet.Put( * pItemToPut );
             }
@@ -351,8 +350,7 @@ void GraphicPropertyItemConverter::FillSpecialItem(
 
                 // translate model name to UI-name for predefined entries, so
                 // that the correct entry is chosen in the list of UI-names
-                XFillGradientItem * pItemToPut = & aItem;
-                pItemToPut = aItem.checkForUniqueItem( & m_rDrawModel );
+                XFillGradientItem * pItemToPut = aItem.checkForUniqueItem( & m_rDrawModel );
 
                 rOutItemSet.Put( * pItemToPut );
             }
@@ -375,8 +373,7 @@ void GraphicPropertyItemConverter::FillSpecialItem(
 
                 // translate model name to UI-name for predefined entries, so
                 // that the correct entry is chosen in the list of UI-names
-                XFillHatchItem * pItemToPut = & aItem;
-                pItemToPut = aItem.checkForUniqueItem( & m_rDrawModel );
+                XFillHatchItem * pItemToPut = aItem.checkForUniqueItem( & m_rDrawModel );
 
                 rOutItemSet.Put( * pItemToPut );
             }
@@ -394,8 +391,7 @@ void GraphicPropertyItemConverter::FillSpecialItem(
 
                 // translate model name to UI-name for predefined entries, so
                 // that the correct entry is chosen in the list of UI-names
-                XFillBitmapItem * pItemToPut = & aItem;
-                pItemToPut = aItem.checkForUniqueItem( & m_rDrawModel );
+                XFillBitmapItem * pItemToPut = aItem.checkForUniqueItem( & m_rDrawModel );
 
                 rOutItemSet.Put( * pItemToPut );
             }


More information about the Libreoffice-commits mailing list