[Libreoffice-commits] core.git: 2 commits - bin/fixincludeguards.sh

[Tor Lillqvist]

 bin/fixincludeguards.sh |    9 +++++++++
 1 file changed, 9 insertions(+)

New commits:
commit 5b710a4ef36cde0d680add3e7fcf437cf4d1c557
Author: Tor Lillqvist <tml at collabora.com>
Date:   Fri Dec 6 13:13:48 2013 +0200

    Add comment about portability
    
    Change-Id: I289d3233f99b61115ed8efdea93cfabfbc53bcd7

diff --git a/bin/fixincludeguards.sh b/bin/fixincludeguards.sh
index 907e4aa..ceed3a3 100755
--- a/bin/fixincludeguards.sh
+++ b/bin/fixincludeguards.sh
@@ -17,6 +17,9 @@
 # ...
 # #endif // OTHER_BAR_HXX
 
+# TODO: Make this portable. As it is now, it likely only works on Linux, or
+# other platforms with a purely GNU toolset.
+
 guard_prefix="INCLUDED_"
 
 for fn in "$@"; do
commit 1637bcc408600df9a81d439d0d764f1447d3996a
Author: Tor Lillqvist <tml at collabora.com>
Date:   Fri Dec 6 13:12:04 2013 +0200

    Revert "The TODO seems to be DONE"
    
    Actually I am not sure at all.
    
    This reverts commit 3b56738d88d881d023bdefda2222d99663f12b9f.

diff --git a/bin/fixincludeguards.sh b/bin/fixincludeguards.sh
index 5a6347f..907e4aa 100755
--- a/bin/fixincludeguards.sh
+++ b/bin/fixincludeguards.sh
@@ -11,6 +11,12 @@
 # a) fixincludeguards.sh header.hxx
 # b) find . -name *.hxx -or -name *.h | xargs sh fixincludeguards.sh
 
+# TODO: This doesn't fix wrong #endif comments, like:
+# #ifndef FOO_BAR_HXX
+# #define FOO_BAR_HXX
+# ...
+# #endif // OTHER_BAR_HXX
+
 guard_prefix="INCLUDED_"
 
 for fn in "$@"; do