[Libreoffice-commits] core.git: 3 commits - vcl/osx vcl/quartz

Tor Lillqvist tml at collabora.com
Thu Dec 26 08:08:57 PST 2013


 vcl/osx/salframe.cxx        |    1 -
 vcl/osx/salsys.cxx          |    2 +-
 vcl/quartz/salgdicommon.cxx |    1 +
 3 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 05fad0744c81a359c5cadb3f5a3c20551677db23
Author: Tor Lillqvist <tml at collabora.com>
Date:   Thu Dec 26 18:03:44 2013 +0200

    WaE: unused variable 'aRet'
    
    Change-Id: Ic998a1eeddd89f45e12e4036dcbc21be534830ce

diff --git a/vcl/osx/salframe.cxx b/vcl/osx/salframe.cxx
index cf1fe45..6d47cc6 100644
--- a/vcl/osx/salframe.cxx
+++ b/vcl/osx/salframe.cxx
@@ -700,7 +700,6 @@ void AquaSalFrame::SetScreenNumber(unsigned int nScreen)
     SalData::ensureThreadAutoreleasePool();
 
     NSArray* pScreens = [NSScreen screens];
-    Rectangle aRet;
     NSScreen* pScreen = nil;
     if( pScreens && nScreen < [pScreens count] )
     {
commit 80b6f48d5e86c1489d1ae4a20fd5dcf5c324d33f
Author: Tor Lillqvist <tml at collabora.com>
Date:   Thu Dec 26 18:02:53 2013 +0200

    WaE: unused variable 'aRefreshRect'
    
    Change-Id: Ib327646572890b13f7049d2ba106c465d7c855f7

diff --git a/vcl/quartz/salgdicommon.cxx b/vcl/quartz/salgdicommon.cxx
index 3c0ca49..d5c1f88 100644
--- a/vcl/quartz/salgdicommon.cxx
+++ b/vcl/quartz/salgdicommon.cxx
@@ -747,6 +747,7 @@ void AquaSalGraphics::drawLine( long nX1, long nY1, long nX2, long nY2 )
     CGContextDrawPath( mrContext, kCGPathStroke );
 
     Rectangle aRefreshRect( nX1, nY1, nX2, nY2 );
+    (void) aRefreshRect;
     // Is a call to RefreshRect( aRefreshRect ) missing here?
 }
 
commit 765cd0ebaabf9cf7948ae1424681de144c7d267e
Author: Tor Lillqvist <tml at collabora.com>
Date:   Thu Dec 26 18:00:28 2013 +0200

    WaE: format string is not a string literal (potentially insecure)
    
    Change-Id: I1f67fca5b66c41d633924ffbf763db03756c8ca7

diff --git a/vcl/osx/salsys.cxx b/vcl/osx/salsys.cxx
index 9ac4b5a..e31044e 100644
--- a/vcl/osx/salsys.cxx
+++ b/vcl/osx/salsys.cxx
@@ -155,7 +155,7 @@ int AquaSalSystem::ShowNativeMessageBox( const OUString& rTitle,
     }
 
 
-    int nResult = NSRunAlertPanel( pTitle, pMessage, pDefText, pAltText, pOthText );
+    int nResult = NSRunAlertPanel( pTitle, @"%@", pDefText, pAltText, pOthText, pMessage );
 
     if( pTitle )
         [pTitle release];


More information about the Libreoffice-commits mailing list