[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - sw/source

Zolnai Tamás tamas.zolnai at collabora.com
Sat Dec 28 00:46:50 PST 2013


 sw/source/ui/misc/redlndlg.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 70f90c08592ef3e50840afda20428078c25c463a
Author: Zolnai Tamás <tamas.zolnai at collabora.com>
Date:   Fri Dec 27 09:45:05 2013 +0100

    Fix stepping to the next change
    
    Bug description:
    In the "Accept or Reject Changes" dialog, when select a change
    (it should be after the first few ones) and clicking "Accept"
    or "Reject" button, acception/rejection is made but after it
    not the next change is selected for futher work,
    but a random one. This bug doesn't appear in all case,
    just if changes are complex enough.
    
    Solution:
    The nPos means absolute position so we have to get the next entry
    with the corresponding GetEntryAtAbsPos() method. It seems simple
    position can differ from absolute positions if changes are
    complex enough.
    
    Change-Id: I7996f81c2a09c492f9334f071591291d200d533f
    (cherry picked from commit dbd8a631bb23c588f52102e5dd2a61c9cd854bc3)
    Reviewed-on: https://gerrit.libreoffice.org/7209
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sw/source/ui/misc/redlndlg.cxx b/sw/source/ui/misc/redlndlg.cxx
index 7885bb4..f1cc96d 100644
--- a/sw/source/ui/misc/redlndlg.cxx
+++ b/sw/source/ui/misc/redlndlg.cxx
@@ -830,9 +830,9 @@ void SwRedlineAcceptDlg::CallAcceptReject( sal_Bool bSelect, sal_Bool bAccept )
     {
         if( nPos >= pTable->GetEntryCount() )
             nPos = pTable->GetEntryCount() - 1;
-        pEntry = pTable->GetEntry( nPos );
+        pEntry = pTable->GetEntryAtAbsPos( nPos );
         if( !pEntry && nPos-- )
-            pEntry = pTable->GetEntry( nPos );
+            pEntry = pTable->GetEntryAtAbsPos( nPos );
         if( pEntry )
         {
             pTable->Select( pEntry );


More information about the Libreoffice-commits mailing list