[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - vcl/source

Julien Nabet serval2412 at yahoo.fr
Sun Dec 29 10:45:45 PST 2013


 vcl/source/gdi/gdimtf.cxx |   14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

New commits:
commit 6cc888babdc3e6414e55f57c0df65135f2ef4804
Author: Julien Nabet <serval2412 at yahoo.fr>
Date:   Sun Dec 29 19:06:11 2013 +0100

    Resolves: fdo#72961 Crash when you open ODFver.1.0/1.1 created by LibO-3.5/3.6
    
    It seems pAction may be NULL so let's keep on to check it.
    
    Change-Id: Ie1a48c96bfa930364053c7c3ad0c940559544e33
    Reviewed-on: https://gerrit.libreoffice.org/7228
    Reviewed-by: Andrzej Hunt <andrzej.hunt at collabora.com>
    Tested-by: Andrzej Hunt <andrzej.hunt at collabora.com>

diff --git a/vcl/source/gdi/gdimtf.cxx b/vcl/source/gdi/gdimtf.cxx
index 1d89dea..2e74172 100644
--- a/vcl/source/gdi/gdimtf.cxx
+++ b/vcl/source/gdi/gdimtf.cxx
@@ -2765,15 +2765,17 @@ SvStream& operator>>( SvStream& rIStm, GDIMetaFile& rGDIMetaFile )
             {
                 pAction = MetaAction::ReadMetaAction( rIStm, &aReadData );
 
-                if (pAction->GetType() == META_COMMENT_ACTION)
-                {
-                    MetaCommentAction* pCommentAct = static_cast<MetaCommentAction*>(pAction);
-                    if ( pCommentAct->GetComment() == "EMF_PLUS" )
-                        rGDIMetaFile.UseCanvas( sal_True );
-                }
 
                 if( pAction )
+                {
+                    if (pAction->GetType() == META_COMMENT_ACTION)
+                    {
+                        MetaCommentAction* pCommentAct = static_cast<MetaCommentAction*>(pAction);
+                        if ( pCommentAct->GetComment() == "EMF_PLUS" )
+                            rGDIMetaFile.UseCanvas( sal_True );
+                    }
                     rGDIMetaFile.AddAction( pAction );
+                }
             }
         }
         else


More information about the Libreoffice-commits mailing list