[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sc/source

Markus Mohrhard markus.mohrhard at googlemail.com
Fri Feb 1 09:08:00 PST 2013


 sc/source/core/data/colorscale.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 008b8c4ca907950af543da91986ba89b0de1ae15
Author: Markus Mohrhard <markus.mohrhard at googlemail.com>
Date:   Sat Jan 26 23:32:03 2013 +0100

    we need to use SCROW for row numbers, fdo#59894
    
    This caused an overflow and resulted in adding endless number of values
    until a bad_alloc was thrown.
    
    Change-Id: I954acd801eb18e2c2fe6a449048856cb95d0d8b0
    Reviewed-on: https://gerrit.libreoffice.org/1945
    Reviewed-by: Kohei Yoshida <kohei.yoshida at gmail.com>
    Tested-by: Kohei Yoshida <kohei.yoshida at gmail.com>

diff --git a/sc/source/core/data/colorscale.cxx b/sc/source/core/data/colorscale.cxx
index 55b8b43..3fe033a 100644
--- a/sc/source/core/data/colorscale.cxx
+++ b/sc/source/core/data/colorscale.cxx
@@ -293,7 +293,7 @@ std::vector<double>& ScColorFormat::getValues() const
             SCTAB nTab = pRange->aStart.Tab();
             for(SCCOL nCol = pRange->aStart.Col(); nCol <= pRange->aEnd.Col(); ++nCol)
             {
-                for(SCCOL nRow = pRange->aStart.Row(); nRow <= pRange->aEnd.Row(); ++nRow)
+                for(SCROW nRow = pRange->aStart.Row(); nRow <= pRange->aEnd.Row(); ++nRow)
                 {
                     ScAddress aAddr(nCol, nRow, nTab);
                     CellType eType = mpDoc->GetCellType(aAddr);


More information about the Libreoffice-commits mailing list